Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7db869ea-c355-01a3-1d09-541473e1e8b8@nvidia.com>
Date:   Mon, 14 Nov 2022 10:57:12 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host
 controller binding
To:     Rob Herring <robh@kernel.org>
Cc:     Wayne Chang <waynec@nvidia.com>, mathias.nyman@intel.com,
        p.zabel@pengutronix.de, devicetree@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-tegra@vger.kernel.org,
        singhanc@nvidia.com, balbi@kernel.org,
        linux-phy@lists.infradead.org, vkoul@kernel.org,
        thierry.reding@gmail.com, ajayg@nvidia.com,
        heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
        treding@nvidia.com, jckuo@nvidia.com, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org
References: <20221111101509.999589-1-waynec@nvidia.com>
 <20221111101509.999589-3-waynec@nvidia.com>
 <166817308790.3060162.14990231448404857914.robh@kernel.org>
 <5782d31a-9a0c-33da-ff84-20cae29f977e@nvidia.com>
 <20221111173236.GA3561612-robh@kernel.org>
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221111173236.GA3561612-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkliQmdOU2wzVUpXeStPZ1loeURDa2xzRkoxRlY3QkQ0YkdpTktLNHJpSjUr?=
 =?utf-8?B?RVhPbzk1bjJqNWU0clI1RFlpT1N6aXd0NlVhQk1MSFhrdFJNSjRpeitCcmYr?=
 =?utf-8?B?UkRFWlBmM1JvNkNKaENjMEFJTVZpQnhTTkpyUCtZV0tzbVE4bDNpbHNhTVVU?=
 =?utf-8?B?d0tEYUYwS2hoZENFZCtYTGNEbGJmUXVwOUVaODRWTGptZ0VtRFlpM1V4SlM5?=
 =?utf-8?B?anpubkt3SjQ4c3VZdW1ubGRXWTM1dVpSVzV6NHdHVVhadmIydStqQ21tdmJy?=
 =?utf-8?B?N0xqUFpiajR5RDgvZ2dRMGsySDRvV2lRckZrenBhUkpESGFEc1gwVkdzay9k?=
 =?utf-8?B?eXJvaWZ1bUVnN3haSGd0b1crd1M3VzFrUEVGNkZPL2Q4cFBmVjlhcDNCbFdz?=
 =?utf-8?B?VnJqNXlLZS9tM0NSekdES1pTSXhyWnJpUTNZV3JyWXZDcXZTY2xYVTgrQ0pX?=
 =?utf-8?B?eitMTFlaNDMxNWMwWXFkWkFvM2F6N1Q3YUJncUZTRnpGdWxhdUFTUVUyQWhF?=
 =?utf-8?B?eE4wdkUyeElWUW94L3NCT2tqRG5IOGxqRVpYYWxjc0l0dnpQQUF2NldSNHIz?=
 =?utf-8?B?ZUpENG8xU2VkOHBPZmx2MnVEOUVzSUdzWUhsUDAxR1ZlbmR2eDg3RXNBNk9o?=
 =?utf-8?B?KzhJS0U0cllVTGV3RFRFTXpLRFAxU2grUHNFN0lnUEhIQjg0OXlLc0VHVW8z?=
 =?utf-8?B?d2NnQlY4MzBuTnhvaXAzTEZYTEtIQnVmRWdmOEpvdFR1N2xtMTVWRFAraTZ5?=
 =?utf-8?B?UWdrMXI2Uk1lNElOamlDREl5a2ExTGdEaVRldXd0WjdLQ09zaWhFbFd5SFZz?=
 =?utf-8?B?eFo2YWVvYUJaUHJpMEtSRHJsNmhqeEdXY3FrTVUwSTNxYkQ5cTNZczlXSWw1?=
 =?utf-8?B?R0I1dGpBbDdWcXpPaXJUZ3JrUnJJZERid2tUU08xMUlJWXo2Z0xxYlhIcUkz?=
 =?utf-8?B?TGxBeERyVkcyVDhWOVVIRVloNG81YmsyaFdmb2UvNjZiUE5LVjRCY3d3Q0hv?=
 =?utf-8?B?WkdFQ3VtenMwcXR5NVhNY1J1WnhGSDN4M2szZ2N4cUVZME0zN2Y1TFdNbHJh?=
 =?utf-8?B?T2VsUlN2N2JXWXprSGhMTW1uWXEweWYwdjRiWDlROWVIOTVCTnN0OW5ha21M?=
 =?utf-8?B?L2xpNlRZc1NjeGxkdjlUcjNzV2IwNllPMUZwUHBndjhiN25LaUthazR0Lzdp?=
 =?utf-8?B?aGJJclJoVGV2OXlmSHlRRlpJd2xGOWh2ZmI4UWgydzdMSVVCT1ovQS9YSHgz?=
 =?utf-8?B?Q0pnQWx6bFFRaVNTSzNwZ1FEd090a2ptZXQ4dWdNSm8waXNlUGx1c1U5N0dC?=
 =?utf-8?B?NjVMVVVndXgzTURFM2hzU3JPTG5WVmxGV2IyR2xZaVU0bTNDbTl5cElqcVJu?=
 =?utf-8?B?WG02elZGYXJJaEJ4Nis2bi9SclRUR21tOExsZUYxRkZHTWVud3dkWHF1cHg5?=
 =?utf-8?B?dGpHRnFJeGc4Y3VQOUxwVTlLL0NhOC9ia2tOM2ZIOW1RZ2V4TTcvU1U3WXdO?=
 =?utf-8?B?aFBWOEJmcElWeFpLcEU5OHZ6d1J1NnFPb3gwZHM2UHJNT1E1bEJaUkRldjV1?=
 =?utf-8?B?ZEZwRTQ1cjVRa3o2dkg4aXBmZW5TSFluRkw2c3kySEc0SkU4bytwRnhUZ2Z2?=
 =?utf-8?B?bFAyL1RKY2t4dVVnNGZJS0pTb1JCeTJVSTVhdDZEd0ZldjljckVobzh5RGsv?=
 =?utf-8?B?ZENub2FEMGxNZmhWWkdFL0lmVHBGLzhLS3hlcWFKUTk5bElnd1NCazJ0YlBW?=
 =?utf-8?B?TDBKWkpRaVJudTM0ZnpOanRMTFN4UzVhNEg3L09ob0lhem1jeC9hVGpaSWNi?=
 =?utf-8?B?MVlWWGx3WTY4VlpFZU5TZWllU1psMVdYZHhBM0xWNk9aczJtdTZlTGpYaUFI?=
 =?utf-8?B?UzFFQmF1aTIyTEZFWFRING5oNHFPNGcyYXNyMHNHMU8xeUhpckFBSjlMeDk5?=
 =?utf-8?B?SndKUlBSd09TbGloTlhWWW91eEdMdEwxZmdCdlFRc0VXUlhUOFBKNVhYVEo4?=
 =?utf-8?B?bzBxL3hsS0YveWp6VGFaZDBMOFp2MWRXWUhqNmNTbWhyd00rME50RW9iMFFO?=
 =?utf-8?B?dkkzVzhQQ1VkSXJZMEFuektCd1dkclBRb3l0eVA0N3ptS2JERjN0UjZKV3lJ?=
 =?utf-8?B?N0NzWjNwRWQxOWdtVURFVjEvNXM4eDNVZk5xcHFDbnRwMkNSWEFXUTk3UXlv?=
 =?utf-8?Q?WdnXO2xRnhr3tiJUHIBYrhFTYccx95xh7y6pgWvolLkU?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 633b34ef-1554-49bd-7288-08dac62f0076
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 10:57:21.2693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WTvYdRnprq0Jup6DhPdZLKv6dvxtzA0Zecj8a3b1bAMd0hyk/PAcjAQBYffojnfDygvZavxk1+0CD9sH1VR3oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5116
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/11/2022 17:32, Rob Herring wrote:
> On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:
>>
>> On 11/11/2022 13:30, Rob Herring wrote:
>>>
>>> On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
>>>> Add device-tree binding documentation for the XUSB host controller present
>>>> on Tegra234 SoC. This controller supports the USB 3.1 specification.
>>>>
>>>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>>>> ---
>>>> V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
>>>>    .../bindings/usb/nvidia,tegra234-xusb.yaml    | 159 ++++++++++++++++++
>>>>    1 file changed, 159 insertions(+)
>>>>    create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
>>>>
>>>
>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
>>> FATAL ERROR: Unable to parse input tree
>>> make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1492: dt_binding_check] Error 2
>>
>> This compiles fine on top of -next. We are just missing the change that
>> populates the required definitions.
> 
> Where exactly is that mentioned in the commit msg?

It is mentioned in the cover-letter.

> No maintainer can take patches which apply against linux-next, so not a
> good dependency to mention either.

Yes understand, I was just trying to indicate that there is a known 
dependency here that we need to handle.

Jon

-- 
nvpublic