Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5af4537-0be0-4e2e-bbb2-4c3af8810060@suse.com>
Date:   Mon, 14 Nov 2022 11:55:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too
Content-Language: en-US
To:     =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= 
        <marmarek@invisiblethingslab.com>
Cc:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        "moderated list:XEN HYPERVISOR INTERFACE" 
        <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
References: <20221114103110.1519413-1-marmarek@invisiblethingslab.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221114103110.1519413-1-marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk4xMmYxaENEU3p6MDVJMnN6d2ZQRm5Fb2ZhTUFCdDhidm92OS95ZG9BVVVH?=
 =?utf-8?B?V2E0ck1UditzdEhwY2JHSlphMDZUSGhDVmllTG5nankwQTVQZzQreHZ2V0F0?=
 =?utf-8?B?ek9zMVg3OWE2VitNdFBDVnBxWlNSTjRWUGxwUGNUYzY5TEZUNkJQUjlkclFJ?=
 =?utf-8?B?WkloZkpOV2JxTXlyV21KYUYxU3M1SnluVkpqN3AzL1EzbHUrVW56Mk5wdlF0?=
 =?utf-8?B?UW0zTStJdm1wOGUyd3krY2hUV29Ca0xhNFk0VW8zWEhCQ0pqRGZrOFlkbWVP?=
 =?utf-8?B?NkgrRldiMnNkN0J4ZGFEYmFoQk9wcXNWSlowQ0VTOHNmT3RNbnEvN3Y0UVJJ?=
 =?utf-8?B?SVZTUEtQVTZHK29HQlFFN2hoL1hVc3dOVDRqclRZdmovREtYeTJpdmVGYkxI?=
 =?utf-8?B?V3hTOUk1UTRQeVJZVCtSM0dZb1NXSjY3eDdZQ01oUHFQdXlabWZVMXo0RGJP?=
 =?utf-8?B?S2F4bU0waVpLT3lhM1hBVEVYRUFTUFlRNlBwWFJGRVNYclJHMmhpOTFydzJW?=
 =?utf-8?B?TGJ2SEVqOHEraWlNWEZMaWNQSjBrNWw0ZE4raWlOb1lFS1kvTCtjTlByTDJl?=
 =?utf-8?B?YVFKQTUzTlBRNE5xdm9tNjdVUVg3Q2hmWkF2UmNBMUwxZ0xEWEpWbVExSVpv?=
 =?utf-8?B?eTRqSjZTOUF5ditBdjNOazYxb2x3VlZaclpNaUt4Y0V3Qk9zUE5HRkRTcGly?=
 =?utf-8?B?RUt6N2JPNlNBZUEzU1cwOFQ5ZGVPSWRpSFRBRE9QOW9Id3M3SXVnV1RoZDcz?=
 =?utf-8?B?V3NsMG1ZN2pScHQ1RjBUbWlKMk45bFY3Z3VzRTQ4WW9oc3QxSENpWE4vVnpk?=
 =?utf-8?B?UmFTbXE1TG9BaTBYV292SmkzMjVwNS9KUnMvbkJYZFJxZG4vcWkzMzZ4QmUz?=
 =?utf-8?B?ZmRKUWsrSkhGdVdZM3Y2TXRTQ00rUnNHUUx5dTJhbDRhOSt0YXl3YitsSlVq?=
 =?utf-8?B?VXlUUFM1cmNRR3luQmR3S0hrU09TUXpOYmRyTzVJWTErSm5hY3pFYXNOV1o4?=
 =?utf-8?B?VERQNGNwY3hPa2w4aDg3OUJsR3o0MWdMRTlPR0VFQng3S1ZoRG91a1pEWTZG?=
 =?utf-8?B?L3NYRUVhZWpJbnBMMnNucm10MFp0S0xpaUdqcGJJZXRvY3RTdU1ZMVgvOWhU?=
 =?utf-8?B?ZmdaZStLSmJBUDk1TXhXeGlYUFpERFZyUjFpcjVONk1Od2FJSzA0RXo4bnFi?=
 =?utf-8?B?My9ia1k0S2VOdWZ5OWxmWjZ2dEVzb3RqWHp3ZXZIRFFZZFQ0TmsrTTZONG11?=
 =?utf-8?B?clpsSEdubUtVaHY4Vk13SzlXVFV5cDVsSDVuL2RIMGIvUXlqVzZWMWJiVHRX?=
 =?utf-8?B?NTRLNU5WL0o3TmMyV3p2MVQ0WlhWbW5QZmhVcW81UWFyOTNQSWdyYXBEZ1cr?=
 =?utf-8?B?Sk5qZWxLK25Ib05Qc3U4R0VtMjcyajdybTIzZWRwRHN0QzRnNnE1cVFRTnpo?=
 =?utf-8?B?Z3g4N2MvREgzUVJJL0xQd085OFZlNDVBbzFRMm9UL1RkYUM1dTlkblRVRjFU?=
 =?utf-8?B?bWVVdktVeEkrSnpSb3dmbStDdnVtRjJIQldZT3AzZUo3MS9tbmUzMEUwcmxp?=
 =?utf-8?B?VlEzUk5rUCt0OHF5SlV4L1FiRVpQQ3J5djNmUXpCNU9PSGZxcEpTdWhEREtr?=
 =?utf-8?B?YklzcnhySkw1cmoyZjNPZ0hGQ28wa3RIeVMyQ3RmVkhuMm5uUTBRZEpRSGJM?=
 =?utf-8?B?b3ZBRE5OOG56TzlRcGQ1ajY4NFk4VVRENEFGek5wTmwyc1BFWnNjQVFGNGRl?=
 =?utf-8?B?MjFWOGQxSXcxL2dNYk1mQ0lhbjNhbmlVNTZySk4xSnFaQjhkRnM4K2JiVnNM?=
 =?utf-8?B?TVZsaHBDa3ZLcE5oZUNWbi9HVlVQWEZEOXpTMFM5c1JEUmx4Qm14OERUN2VE?=
 =?utf-8?B?SmJOUm1WTFNFVzFZbkJNcDNJdmt3dnVJeEtxa2dRK1NocTNZSExQNjM1dHY1?=
 =?utf-8?B?cWd5S3FqZnBWVEdnWnlSby9BeUY0cFNqODZockFrT0UxbHJXK0l3anQwZ2p2?=
 =?utf-8?B?RS9OS3gzZUNST3RkRFZzbUN5MmliYlN6bUpHb0htTzljN0FhWkNNM3pQbmxQ?=
 =?utf-8?B?cnV6MHlOTlR3VWpmcEk2WUJncUY2RUtkNUVPNTJiaFd0NUEwOXNEdDhGRExl?=
 =?utf-8?Q?0QX8+eWMgygfodDIQ9aw8DTw5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3502c171-6bf9-42af-43e0-08dac62eb36d
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 10:55:10.9142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mvDG+OiCzV7sjqgVkKx0dSOwnK96JyHcif9fHryrLDyqX0k5lcL2deqgeTRjex47fq/9FGBpFihSM0syrkxyXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9309
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14.11.2022 11:31, Marek Marczykowski-Górecki wrote:
> When Xen domain configures MSI-X, the usual approach is to enable MSI-X
> together with masking all of them via the config space, then fill the
> table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via
> QEMU running in a stub domain.
> 
> Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the
> whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE
> bit too.
> 
> Note the Xen hypervisor intercepts this write anyway, and may keep the
> PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the
> guest-requested state and will apply it eventually.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>