Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in
 stratix10_svc_drv_probe()
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <dinguyen@kernel.org>, <richard.gong@intel.com>,
        <atull@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221114025921.1194834-1-cuigaosheng1@huawei.com>
 <Y3HtGbqAvb15Sa9a@kroah.com>
From:   cuigaosheng <cuigaosheng1@huawei.com>
Message-ID: <4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com>
Date:   Mon, 14 Nov 2022 19:11:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <Y3HtGbqAvb15Sa9a@kroah.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

> How was this found and tested?

Thanks for taking time to review this patch.
I found this through the cocci script, I made the patch based on the code logic,
but I have not tested it due to the lack of hardware devices.

On 2022/11/14 15:24, Greg KH wrote:
> On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
>> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
>> IS_ERR() to check the return value, and return it on failure.
> How was this found and tested?
>
> thanks,
>
> greg k-h
> .