Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85b3be01-315b-cb3e-f974-898cd76b683c@suse.com>
Date:   Mon, 14 Nov 2022 12:26:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, matthias.bgg@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        matthias.bgg@gmail.com, frank-w@public-files.de
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221111113635.4603-1-matthias.bgg@kernel.org>
 <1683603c-8486-b7a7-e9d7-bddd28c1cd8c@collabora.com>
Content-Language: en-US
From:   Matthias Brugger <mbrugger@suse.com>
In-Reply-To: <1683603c-8486-b7a7-e9d7-bddd28c1cd8c@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmJ0M1E0Q3hKTVR1bXN6SmM5SnVjSUdFYUhkZ2V2bEVkSGdnb29VTGJFcndq?=
 =?utf-8?B?YkZHZ1hUM2FuR0k3KzdkMlZ1eFdqbXlUeHovOTkyRTRCQ2VFMEhZVTcwaGRO?=
 =?utf-8?B?ak92NzB6Q1pGUTFrbmlqRjZEUlB1OURnak9BV1dsSWtuR0c2S2pGVm10WUlB?=
 =?utf-8?B?bGpEQUVHUFVLUUtIKzF4MlplQTBqWjFLSEhtQ0RMMGpYR2swREhXUGVBWDlT?=
 =?utf-8?B?NjFhSXBqT3o1S01jODhobExTNkRiYU90WkkxY2tLYnVxaTNMc2xUN2F3d0xR?=
 =?utf-8?B?UkYrSHhDWVhDR2o4cTJkREVtcDV4REtzb2ZHL1VWYXhxTG9kcUt3N0tYY05U?=
 =?utf-8?B?aWRkQVVLS2cyWlBKNmZyTzJ6RGRkUXp6anVKUXRSNFdXaTBwU0NYM0I1SUhT?=
 =?utf-8?B?VzNPOVJUckZ6TE1oamRBZ3B3cEdaZlMxRlA1ZmJDLys4bmNFTFpQSTZEbVY5?=
 =?utf-8?B?QVQrT1pZdHQxN20rTXEwdHY3V2UySEdqVG1qQ2NtNGpPdXowcUJLWUV0dDMx?=
 =?utf-8?B?TExQeHRPMjFMYUxEZUFLQTd2WkUzOTVFY0E3YkZLalB3dUFtY0p0dnJuT05N?=
 =?utf-8?B?QU5sWlpleDUzbzVsU0hEa3pubmJxaFM1Uk5vOTF4bjZoM2M3bkh2Sk45SGsx?=
 =?utf-8?B?eEhCTlVNb2pCV1FDSkd6elFQclRhWWVmTnlaS3BINEE1aDhqa1A1dGN4QmE5?=
 =?utf-8?B?WGo4SG0xSWRTUTFGUXhRRFpQc0lRS0ZTSUo1akZrN1B0L1huNzl2ZmdYWnZx?=
 =?utf-8?B?TGl3Y3BXZTRyOXZkMmRJZFZOVVJYeXVBckNLSGMxenI4SzlmUklVYkNlQ0hi?=
 =?utf-8?B?ako3bFdLYkEyMWNLaGxTM2JKMjJXNS9NajFTakdiVDVLTVFudDNZdmRtaW5P?=
 =?utf-8?B?OFE1QXBsQWV5WkVDYmt4S2Y0MCtJMGo2YTVKYjNkanY4cUVPMGw4OENpdlR5?=
 =?utf-8?B?TEs5YTlGdHdVT1RLQjRGejdZUjFxOUdoU1l1L3oyOENDVVJZdTdVYlQyaTFW?=
 =?utf-8?B?bkdhNnJTS3dFUVU4V1ZPQVA4eFBITU9nelVtTWZVcno0RTloRm4zUHlwbDhz?=
 =?utf-8?B?SlBTYzJRbVhpYUpxY0lNVnptbzJWOEdVTW1kUjFUUmVqMm9YWHFPbGpyWGwy?=
 =?utf-8?B?OC9OdW4wTWl1d3o3bkNjRFFqSCtqdUdOUVZpWmU1MEIrendzUUxZdXgwNWRQ?=
 =?utf-8?B?S0VickhBQXZDMVN6eXN5Z01qYys3L0V1ckE0VzFiRWdPdGhlcjV3ZktVcndh?=
 =?utf-8?B?dkdDengyd2h0UjZDcUlXTC9oVUVaZXEvV0U4eVVoYjhPNGlxaXR5YVBmQXZS?=
 =?utf-8?B?cGttKzRLVCtCZ1lEWURQV1diakhJc0RCRWk1RUVhbTNVSkprZ1c3ZTFGMUpu?=
 =?utf-8?B?SGtISlNyUGxodDdnZ1lTbUtPWDEvL2ZwY0JrbTFFRSs3MHVpTGRQQmxtMUUy?=
 =?utf-8?B?dzgzdGNxblAyMEFqTjZqSmxBQkROQTI1blFMa1QyUmxOOWwyeUtZVGp0cm9m?=
 =?utf-8?B?Sk5RZ3BFb0pjcVVFbkEyalI4VUJ2QTRnaVJaUjFRclUxcWc5aTFkMGZxc0kv?=
 =?utf-8?B?VWsrblRVeit2ZjdmUWNwWStzczdqUHBIaDNzYjJrenVtQ3U4UERVNGU3Mkph?=
 =?utf-8?B?VEp4aVpXVXhKMjdtRzNjbENOZUVXamQxS3FKTFZLd0hqMmlyNm4xeU1sdjdF?=
 =?utf-8?B?MXpPR3AxV1dJS2QwSXFRUVdRVUNCcjZGWHFVaXVLb1FQbGJwc1M0NnhYMTlM?=
 =?utf-8?B?UlhmZXI5UU1RTkI3ZVZQbGpYRFpSRW9MT1luSlpwUGo5ZzJ2N3lHQ2k1eXpH?=
 =?utf-8?B?SnhNRHU1aFNmUHJROFZHZTRBOHlNVk9GZkNWZ1JmRnlFRE5VdlNFV2hjUWFC?=
 =?utf-8?B?K2VabXkyVVA5VVZwVStYZXRXVFVtRlJyVjBRcVN0RzBNMTZrMWVWK3AwYi9H?=
 =?utf-8?B?MkczNmVKekVkaDZzQ0U4VmVWSTkyZkJzaWNsMGovSWNLaFpaZmQrUnpaOGZt?=
 =?utf-8?B?TXdrajBaWXhnb3M5cWJqN2g4Ris3ZUpJdHdBMlFvWkp2SEFSOC83bzZuc2c5?=
 =?utf-8?B?aVRRTWJCcTJBUmc4Q2x4bTh2K1dzaHlMeHZsQUYzTDZLRWFuNDBtVkswNzZV?=
 =?utf-8?Q?mXdDVHC8CNIyZsScUTvi34hGv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fb8b41a-3bf7-4abc-7e35-08dac6330647
X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2789.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 11:26:07.8889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LxssCqXbEHdWxXjqzKOU1N1zEufx5829NRsHDxF4ys+/JUvwf3yunRhaAijgfMP96zJmoBF56E78LiGlsuIj9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7267
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:02, AngeloGioacchino Del Regno wrote:
> Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Missing SoC compatible in the board file causes dt bindings check.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
>>   arch/arm64/boot/dts/mediatek/mt7986a.dtsi    | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts 
>> b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> index afe37b702eef9..0e3b603159477 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> @@ -9,7 +9,7 @@
>>   / {
>>       model = "MediaTek MT7986a RFB";
>> -    compatible = "mediatek,mt7986a-rfb";
>> +    compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>>       aliases {
>>           serial0 = &uart0;
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> index 72e0d9722e07a..1191ecf345a7d 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> @@ -14,6 +14,8 @@ / {
>>       #address-cells = <2>;
>>       #size-cells = <2>;
>> +    compatible = "mediatek,mt7986a";
>> +
> 
> It's DTS that shall declare the machine compatible and it's expected that they
> all declare their own, so please drop this one.

SoC compatible should have a the compatible for it's SoC. But for style reasons 
it should be the first of the block, I'll fix that.

> 
> Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
> one too?
> 
>      compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";

Will do.

Thanks,
Matthias

> 
> Cheers,
> Angelo
> 
>