Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 11:31:52 +0000
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Alexandru Tachici <alexandru.tachici@analog.com>
Cc:     linux-kernel@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, steve.glendinning@shawell.net,
        UNGLinuxDriver@microchip.com, andre.edich@microchip.com,
        linux-usb@vger.kernel.org
Subject: Re: [net] net: usb: smsc95xx: fix external PHY reset
Message-ID: <Y3InKCr9BGaf8wiI@shell.armlinux.org.uk>
References: <20221114131643.19450-1-alexandru.tachici@analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221114131643.19450-1-alexandru.tachici@analog.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Mon, Nov 14, 2022 at 03:16:43PM +0200, Alexandru Tachici wrote:
> +	} else {
> +		/* Driver has no knowledge at this point about the external PHY.
> +		 * The 802.3 specifies that the reset process shall
> +		 * be completed within 0.5 s.
> +		 */
> +		fsleep(500000);
> +	}

It's slightly more code, but would it be better to do this in the
mdiobus reset() method?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!