Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 12:33:56 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     cuigaosheng <cuigaosheng1@huawei.com>
Cc:     dinguyen@kernel.org, richard.gong@intel.com, atull@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in
 stratix10_svc_drv_probe()
Message-ID: <Y3InpOKpj9qD8pYL@kroah.com>
References: <20221114025921.1194834-1-cuigaosheng1@huawei.com>
 <Y3HtGbqAvb15Sa9a@kroah.com>
 <4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com>
Precedence: bulk

On Mon, Nov 14, 2022 at 07:11:16PM +0800, cuigaosheng wrote:
> > How was this found and tested?
> 
> Thanks for taking time to review this patch.
> I found this through the cocci script, I made the patch based on the code logic,
> but I have not tested it due to the lack of hardware devices.

As per our documentation, you have to explain how stuff like this is
found and tested.

thanks,

greg k-h