Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5475572rwb; Mon, 14 Nov 2022 05:20:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf5IybcHUmsQXhKDbPCPUIU5H9Poow0cwbCBSrPv6YSkewlT9/U27riykIJeTgpOZrMwY4RI X-Received: by 2002:a17:903:2013:b0:186:be05:798e with SMTP id s19-20020a170903201300b00186be05798emr13526209pla.37.1668432030881; Mon, 14 Nov 2022 05:20:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668432030; cv=none; d=google.com; s=arc-20160816; b=Rb5UvOqYcPxE/1Eegk3qVpYPzRtJHW20kCNG4RWloacJN5QEKGii+UoAHY1a38ZE3n hUlt5CZ6PM4qGalk92XuN4leZrMZ2xfUFbma5J7WPaIhDiSWiyvk0ZJokHp8GaRJmiYR j568OTBpCc5YvBXbCqQzx93ahscSuiZrnAdh8hjCNPj9g7bOCR1rEYSBDQx0nDqi4JYT rkyvSDXaCFOLbUx0XS67wH20IdfZoytJP2N9aWXWvX4GcAbQM3v0+viNdq8I8EWT8VtC tXTEcHVYQmwXr0Ta5GNmnTbKwlDR1mtX1Ft+P+a2j+sMNyA8jwPrGD7aeoRuxFQqGNRX gScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=EMhSzxc71gtsWdv7tBdLboQapjVVOXhkp285VQ60rL4=; b=GxHZvTuZRzNYcps9W6lbromEN+z0G149n7vJ4cZt/7DUeDQM2D8EA7MfKV0k81dRgN PLWPFIGVX38FXBk6NN1xC9JeYHp7LqtRGJf4EuNCJzZguoD2bZzvxvqVtpU9yAGHK0rO Hsgxg/rI98Hhkl7xrvQBga3n8cQEqsmxaWL7SUjIgpH1u0WosqJyh4fuxZEC1EA8YJdk Z9F3VAAPtn5/uAQ8XP5NdKbITCLV3qbHXnbmw5VStGG9Y4eJdFTf4lYifXkkUxjEWu43 fFf0PbIYNfQht3lOJGwI85M8zP7BaQtuB4faAoi0MzwKA/gucl4MP9i6D4RrDok76ugi v3ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ePkLq0o9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a170902e84d00b001868bb70fd5si10718396plg.124.2022.11.14.05.20.09; Mon, 14 Nov 2022 05:20:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ePkLq0o9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236851AbiKNLrF (ORCPT + 88 others); Mon, 14 Nov 2022 06:47:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236387AbiKNLqP (ORCPT ); Mon, 14 Nov 2022 06:46:15 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C9A023140 for ; Mon, 14 Nov 2022 03:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668426280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMhSzxc71gtsWdv7tBdLboQapjVVOXhkp285VQ60rL4=; b=ePkLq0o9BjQOqKepKnXvafGshVpREYvO8QJShj6If/V4//GpXliYz+/bgM3VR+Tg9aJzUa LF+rCHGI6v1GuN2bQbosoJ4Nf2LVJeYI5gRvsigmrUKxcmLh4r2kVYAu+Szchp1Bh+BFFp MUkbOZtbBSQa3qU4lqdykLiPpbx/cT4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-Otw1wR4uPsei68QnsffE2A-1; Mon, 14 Nov 2022 06:44:37 -0500 X-MC-Unique: Otw1wR4uPsei68QnsffE2A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA228101A528; Mon, 14 Nov 2022 11:44:36 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id E805140C6EC2; Mon, 14 Nov 2022 11:44:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221111090813.72068-1-jefflexu@linux.alibaba.com> References: <20221111090813.72068-1-jefflexu@linux.alibaba.com> To: Jingbo Xu Cc: dhowells@redhat.com, xiang@kernel.org, chao@kernel.org, yinxin.x@bytedance.com, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] erofs: fix missing xas_retry() in fscache mode MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <575541.1668426273.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 14 Nov 2022 11:44:33 +0000 Message-ID: <575542.1668426273@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jingbo Xu wrote: > The xarray iteration only holds RCU I would say "the RCU read lock". Also, I think you've copied the code to which my dodgy-maths fix applies: https://lore.kernel.org/linux-fsdevel/166757988611.950645.762695906984689= 3164.stgit@warthog.procyon.org.uk/ David