Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-7-aidanmacdonald.0x0@gmail.com>
In-Reply-To: <20221112151835.39059-7-aidanmacdonald.0x0@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 14 Nov 2022 13:24:27 +0100
Message-ID: <CAMRc=McQCrYEo729k9cnH_bB0Vt5BSB1OHg0tsA3rBL51EdUKA@mail.gmail.com>
Subject: Re: [PATCH 06/18] mfd: max77650: Remove useless type_invert flag
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc:     lee@kernel.org, mani@kernel.org, cristian.ciocaltea@gmail.com,
        wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com,
        krzysztof.kozlowski@linaro.org, mazziesaccount@gmail.com,
        orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
        zhang.lyra@gmail.com, jernej.skrabec@gmail.com,
        samuel@sholland.org, linux-kernel@vger.kernel.org,
        linux-actions@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 12, 2022 at 4:19 PM Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> wrote:
>
> The type_invert flag does nothing when type_in_mask is set, and
> it's part of deprecated functionality in regmap-irq. Remove it.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>  drivers/mfd/max77650.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/max77650.c b/drivers/mfd/max77650.c
> index 777485a33bc0..3c07fcdd9d07 100644
> --- a/drivers/mfd/max77650.c
> +++ b/drivers/mfd/max77650.c
> @@ -138,7 +138,6 @@ static const struct regmap_irq_chip max77650_irq_chip = {
>         .status_base            = MAX77650_REG_INT_GLBL,
>         .mask_base              = MAX77650_REG_INTM_GLBL,
>         .type_in_mask           = true,
> -       .type_invert            = true,
>         .init_ack_masked        = true,
>         .clear_on_unmask        = true,
>  };
> --
> 2.38.1
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>