Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5477320rwb; Mon, 14 Nov 2022 05:22:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf7hp+hDYerWSeHyBZx3n2gTPJUpjrUoFT9AF2d03Dy/YAYhZZLicTaO9kSeqJctrDMdwCSP X-Received: by 2002:a17:902:cf06:b0:178:7040:9917 with SMTP id i6-20020a170902cf0600b0017870409917mr13578638plg.109.1668432132401; Mon, 14 Nov 2022 05:22:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668432132; cv=none; d=google.com; s=arc-20160816; b=O86aAkA4/HPvNcNNiA80RToYShTPW5FuY48EoN7J0fDA6c577YkLHsEgrvAf38Wie2 N0t0O+W17UkbNmEYvFdOijEeEFVeUVim0aNc7HP/WofuMm5d4GpGo1tsqGRTKs0ZVOKa rVzik/k/ZGilWXMrLo4HYEloOJA/wloRAPJDnWpBTAqZEoTUfcOWPhtPW469I/V7GNI2 Rp1CiFcuEQn6aZ/0XDyk2ukLPxgd1BPbNsj86efgAC9a47jIKSDbu+gMED56SNxfpE+G BUgkFz5PUkA2qo4Vy25iSdSvSgvIJntCUJkGStb+XDb+Yf/voQ8nJ6DsgpY53AoaNYu3 +y7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+IscYg0RCPY9exk27jIKrTfHjk8NzGeWxjP6FSmxPmg=; b=Kzqjb7+xQ/Ojdt49mRn4eIiobhkBOXlD9/bSYY1tKQR7gNKLollckZzCzq4sPE3vc0 wMae3i9Vg98dxbgsVYmbQo/r/f1FR7uNCPiBuwEz5QuN0BPOXAUQIEvMZnET0RtUUUyf ignIP7RdyHIFso+OK2lCYYf2StWRSLB+iOz6YPNRxiG6kj5Zer5+i/3UlLVHfs0FNLE1 Z+O6CsJHmqFmGQcBRGfWNVg2znJi12mLFDHKRnGs1LrDPrt7ZTsYUWBL7KEq21siGKL7 ZGbFKct+j6K98dPY614eaM6Huid0/bJTYCnuAh/fvYTAW13EPR7g9mRVGW9U6/lfyyHw fWxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iFqkOSzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a656641000000b004701c938a86si9253976pgv.517.2022.11.14.05.21.58; Mon, 14 Nov 2022 05:22:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iFqkOSzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237134AbiKNMVC (ORCPT + 88 others); Mon, 14 Nov 2022 07:21:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237116AbiKNMUw (ORCPT ); Mon, 14 Nov 2022 07:20:52 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1A2C23383 for ; Mon, 14 Nov 2022 04:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668428450; x=1699964450; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=rvPmNzCoa8n8SixsXezw6M9E+Ll3YuySZ4TJDTq+LLk=; b=iFqkOSzqKWaB3eqIebDkIQi3YhNm55JSM/bW8068GAS04dL0+Jla9SFv wqrYj87vBB0Yfmx80/4BivrOILvmeDGSBQiS6OOI7xnPWPvDQUFLSxuA7 HvA/v3XFVmrs3Lja2NlbnSAfXqUp4aiAMhSIxDSC8b9QVj9Z6MkHwT6Fe +iKVDCnrdWjdpX76BWXKeWWmZJyq4IQnsMxckKhYt08yyc5UngHnJEDlI SS2bL+xC8MWdBJAstPWJLPs+lVgKVIeW0+WQgl5HfMyITOskfPHqLa3gy 8skceTjX4H/lCVK5wMw2Ep0vPmD5DUs5emt7Uvzjifz5usWOgqqfndknt w==; X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="398245648" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="398245648" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 04:20:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="616291804" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="616291804" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by orsmga006.jf.intel.com with SMTP; 14 Nov 2022 04:20:46 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 14 Nov 2022 14:20:45 +0200 Date: Mon, 14 Nov 2022 14:20:45 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jim Cromie Cc: jbaron@akamai.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, linux@rasmusvillemoes.dk, seanpaul@chromium.org, joe@perches.com Subject: Re: [Intel-gfx] [PATCH 1/7] drm: mark drm.debug-on-dyndbg as BROKEN for now Message-ID: References: <20220912052852.1123868-1-jim.cromie@gmail.com> <20221111221715.563020-1-jim.cromie@gmail.com> <20221111221715.563020-2-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221111221715.563020-2-jim.cromie@gmail.com> X-Patchwork-Hint: comment X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2022 at 03:17:09PM -0700, Jim Cromie wrote: > drm.debug-on-dyndbg has a regression, due to a chicken-egg > initialization problem: > > 1- modprobe i915 > i915 needs drm.ko, which is loaded 1st > > 2- "modprobe drm drm.debug=0x1ff" (virtual/implied) > drm.debug is set post-initialization, from boot-args etc > > 3- `modprobe i915` finishes > > W/O drm.debug-on-dyndbg that just works, because all drm_dbg* > callsites use drm_debug_enabled() to check __drm_debug & DEM_UT_ > before printing. > > But the whole point of drm.debug-on-dyndbg is to avoid that runtime > test, by enabling (at post-modinit) a static-key at each callsite in > the just-loaded module. > > And since drm.ko is loaded before all dependent modules, none are > "just-loaded", and no drm.debug callsites are present yet, except > those in drm.ko itself. > > Signed-off-by: Jim Cromie > --- > drivers/gpu/drm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 34f5a092c99e..0d1e59e6bb7e 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -54,6 +54,7 @@ config DRM_DEBUG_MM > config DRM_USE_DYNAMIC_DEBUG > bool "use dynamic debug to implement drm.debug" > default y Could you switch to 'default n' as well? i915 CI actually enables BROKEN so that we can test some more experimental stuff which is hidden behind BROKEN for normal users. > + depends on BROKEN # chicken-egg initial enable problem > depends on DRM > depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE > depends on JUMP_LABEL > -- > 2.38.1 -- Ville Syrj?l? Intel