Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ab8b468-44ee-a488-0f74-eb9dccdd0247@gmx.de>
Date:   Mon, 14 Nov 2022 14:35:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v9 12/12] tpm, tpm_tis: Enable interrupt test
To:     peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc:     stefanb@linux.vnet.ibm.com, linux@mniewoehner.de,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        jandryuk@gmail.com, pmenzel@molgen.mpg.de, l.sanfilippo@kunbus.com,
        lukas@wunner.de, p.rosenberger@kunbus.com
References: <20221110152533.24243-1-LinoSanfilippo@gmx.de>
 <20221110152533.24243-13-LinoSanfilippo@gmx.de>
Content-Language: en-US
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
In-Reply-To: <20221110152533.24243-13-LinoSanfilippo@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:s51Kaw7iSjY=;uU+POoeyTnWG+Q1E/BBeATDyqdc
 YqDmqcbM8jYLypOaDS2ZDY8wONocgpOray4tX4XFbhXSI7J5LIRkoZO760mr1sFzJ4Nm6KMv6
 tMXTb89EbeeRum7NYqfP6+wFUbZKPi7qdw/YTQL6Q0m1B7NCIfOseSCq/Cksj/hjjN9DxsFbn
 BomcbK+KxIKB4fBj9hBKH9HWYZtXOatIwwmGbj/lojR1K/C4sL0xGsjODKYlCrqGZRjQ70UUs
 3L1xuHee/hTzZELpvDBII8vv9q1puJLix/vc/v0MJkd+ofrG879kwS16iYUNOzNeTV2QeC6uj
 oWHGP8JD340JKW5yNox7neMFTZJT8j2/Phhu7bztlBETFwY3vq5LWyZNlNO8R334EbE/uhVAT
 4SMQmwQSwp4GEOWD/MXfIwXwBpTHay9Mg6V5oThcNyctiHadEGHHUmZtNF138QbGxCZqmeReN
 +QJgF2jIfLRoiWLRZTZiIXzU6tArNI47SiPSKabpfmAehHcFBHJnhJOxas1XAsnZuRHHgCoz5
 lEN+tCJQsYcaEBtAMhgU1zjOYTHfLjyphxeUoXjQ/RFPWVXSAnSE5dYU9zA2GKZXmYLo34JPa
 eQmvrYixuxNV/RzxQkFuXNBAqzU5XIl56A1A4pIPcwIDxGlxBWJHHJqgzAxuXuek3Tojlf9V/
 YnBfXMHRYtbxtD5Je0BKdWYvGVWFCQipZaALSzT4dFcb358dGAJXpTK2BjIwoxFdFWyUPGvSz
 AKAKh6o4Mwt6XnM8JxSk2BqUcD8uHdFRxUuscCGQD5j3GMr2c1f9u5AUXs+I5s/xN/OdxSZj1
 afWPSC8of8urKjwN2pLf0E56fbjwqZb4OOhd0jnE9i3/PsClM2DfV41sslsFzGe4EuKSQcK9n
 N4IWIYaej22IdlaPiQdRoXqvHOJdKD4XAz9cESlGA6uEPAiBjuwdZk6JSKcpahkwtm7nQUz/I
 jH1wvgteX3nxxpg+O2Znwi7dS1Y=
Precedence: bulk


On 10.11.22 16:25, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> The test for interrupts in tpm_tis_send() is skipped if the flag
> TPM_CHIP_FLAG_IRQ is not set. Since the current code never sets the flag
> initially the test is never executed.
>
> Fix this by setting the flag in tpm_tis_gen_interrupt() right after
> interrupts have been enabled and before the test is executed.
>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
>  drivers/char/tpm/tpm_tis_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_=
core.c
> index 469a1db95941..1f78582264eb 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -793,6 +793,8 @@ static int tpm_tis_gen_interrupt(struct tpm_chip *ch=
ip)
>  	if (ret < 0)
>  		return ret;
>
> +	chip->flags |=3D TPM_CHIP_FLAG_IRQ;
> +
>  	if (chip->flags & TPM_CHIP_FLAG_TPM2)
>  		ret =3D tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
>  	else

Please ignore this patch. I will send another version in a v10 of this ser=
ies.

Regards,
Lino