Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 16:06:50 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Ian Cowan <ian@linux.cowan.aero>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: omap4iss: correct cacheflush import
Message-ID: <Y3JLenvvuRhb0xfZ@pendragon.ideasonboard.com>
References: <20221113003347.93483-1-ian@linux.cowan.aero>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221113003347.93483-1-ian@linux.cowan.aero>
Precedence: bulk

Hi Ian,

Thank you for the patch.

On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.

Unless I'm mistaken, it looks like the header is actually not needed at
all.

> Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
> ---
>  drivers/staging/media/omap4iss/iss_video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
>   * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
>   */
>  
> +#include <linux/cacheflush.h>
>  #include <linux/clk.h>
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
>  #include <media/v4l2-ioctl.h>
>  #include <media/v4l2-mc.h>
>  
> -#include <asm/cacheflush.h>
> -
>  #include "iss_video.h"
>  #include "iss.h"
>  

-- 
Regards,

Laurent Pinchart