Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5556544rwb; Mon, 14 Nov 2022 06:24:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf7+LONvz9Ldv56QiVYaPRXRkGoHBhji4JU81FBKuGhQQYeT9FAPGGNLZnE0vpFyjLbQS0nQ X-Received: by 2002:a17:907:8e8a:b0:7ad:83cb:85e6 with SMTP id tx10-20020a1709078e8a00b007ad83cb85e6mr10683357ejc.108.1668435874102; Mon, 14 Nov 2022 06:24:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668435874; cv=none; d=google.com; s=arc-20160816; b=ONkT5bpKVKLrkN6ZNMC58I+m2dobKKZcuWY1QIjMQ3zHLyn0apzs3KWxEDMBtdOnTs SR1wNYPV4e54GzsqmZ8cN2NARIStjeQIM7nzlVmjmYdP1U+YPXdL7O8hUvY3eCOZykfu V6FMLCzAgZRUXZN9cJdu0vd08hSZC6Q7rjeuDvT0WqAVAqU/B9I+uQH4yRKb69IQ+Pb/ XKTsEERW5F2PsYDSUfewSfIxJPmuFXlXVshVqPLsBcg6r8akGLIc64cg04AvLq6KvNqL CUZNXcbPUiS5fuH/7QbcJNbMCokC0aePKO2U+pqROAmTNipyAoRfyHIYuWn76xV5VWuK vbUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=Ug8PSO/OGEMZb5vyVVfvqPxGpgSwiji4/HyS/gm+NK8=; b=Yu1vxpAio5eXyrsukzjrI2N7nTNKG6uXVwZxOU3Y8PS5P44dWISOrOUi2Vs9bbAkFd 0bG3mMUqGmPS3km1pSvvNK5QrQhFSOkh0wCEXDKmG6M2N1GtniEiEm0KW87f6IMJVWua Ybw9Qoar1x3YyeS+HWJt/wah+UuXGVYl6heMSkfN1OQVYl0BUlduDZRv+EVsdVxaJcrB FA5or8PeTttqz81HkMw8Fo86hfFQ52YZQUeqdYvxquMlcByDsWQ0Ed+JF5Wi2PPttWPE Q8U8mzKltFGiw9rHLmyOua9umr1S1Ya04j+5WjK/D4dUT5w2aLU6TnpT5dmUgUSbbvKi 9m/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lvmTPGJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz3-20020a1709072ce300b007824b85978asi8905211ejc.81.2022.11.14.06.24.11; Mon, 14 Nov 2022 06:24:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lvmTPGJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236889AbiKNOJH (ORCPT + 87 others); Mon, 14 Nov 2022 09:09:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236843AbiKNOJE (ORCPT ); Mon, 14 Nov 2022 09:09:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE8D2AE0; Mon, 14 Nov 2022 06:09:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF03E611BE; Mon, 14 Nov 2022 14:09:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12D01C433C1; Mon, 14 Nov 2022 14:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668434942; bh=nc57LEG5jYTS9ueM1mkZq7Psxs0hzm5AUlc0Xu2jMjw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lvmTPGJP+pq6k8dwEaDeV5llMxQi20DQNpDeff+eY54E0HuuxHX2PQuPXq5XaE0KS ZQyzGXiE+m8FPm8f+BWk2EwHE6o1Ib+5Qo1kL2bRfzqffdbYEBVaKhZ1MAePUzmzfy ZKzyAHtg9tjb1g3zlYKWyuhLxe8XHEWHFo2iyr5ERXF1QvWRnFI2syCDuhDaGMdVpO sk+OpZZ2nWzpcNidIeCwckjlYoa0EIwugQSUCACCyRz5GAbHDH73/VvUjNKw4zCvPs Zqiv2tjqbFomwTjvxWD5Sr67RqB+9S+Dxg3NXjw0ND39PwRZXO/l2ELK1Dh8E0i4DZ eXfDmylS+0t6g== Date: Mon, 14 Nov 2022 15:09:00 +0100 (CET) From: Jiri Kosina To: Andreas Bergmeier cc: lains@riseup.net, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] HID: Print specific timeout error in probe In-Reply-To: <20221110204131.1354704-1-abergmeier@gmx.net> Message-ID: References: <20221110204131.1354704-1-abergmeier@gmx.net> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2022, Andreas Bergmeier wrote: > When -ETIMEOUT gets reported ensure that the error message mentiones > timeout. > > Signed-off-by: Andreas Bergmeier > --- > drivers/hid/hid-logitech-hidpp.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 20ae7f73ef08..a0c148a8df6c 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4438,12 +4438,16 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) > if (hidpp->quirks & HIDPP_QUIRK_UNIFYING) > hidpp_unifying_init(hidpp); > > - connected = hidpp_root_get_protocol_version(hidpp) == 0; > + ret = hidpp_root_get_protocol_version(hidpp); > + connected = ret == 0; > atomic_set(&hidpp->connected, connected); > if (!(hidpp->quirks & HIDPP_QUIRK_UNIFYING)) { > if (!connected) { > + if (ret == -ETIMEDOUT) > + hid_err(hdev, "Device connection timed out"); > + else > + hid_err(hdev, "Device not connected"); > ret = -ENODEV; > - hid_err(hdev, "Device not connected"); Printing as specific error as possible makes sense to me. I am however wondering whether the better aproach (covering all the cases, not just ETIMEDOUT specifically) wouldn't be to convert all the dbg_hid() in hidpp_send_message_sync() to be proper error messages instead? That would cover also your case, as ETIMEDOUT is handled there as well with debugging message. Thanks, -- Jiri Kosina SUSE Labs