Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 14:29:30 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <ojeda@kernel.org>, Viktor Garske <viktor@v-gar.de>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev
Subject: Re: [PATCH v1 09/28] rust: error: add codes from `errno-base.h`
Message-ID: <20221114142930.3a5a2157@GaryWorkstation>
In-Reply-To: <20221110164152.26136-10-ojeda@kernel.org>
References: <20221110164152.26136-1-ojeda@kernel.org>
        <20221110164152.26136-10-ojeda@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PIm7zOPM8yenkMcXDhGcx67YaHK9Rbx1Hmfn8dDvA1PF1oMIexiHxjIwMX9A?=
 =?us-ascii?Q?aaQCNcv9TrOK0jw2nf8tAM4qGzx5DzI4F/SGFAfnnkqtPZ7OCLWYQg/AJDC6?=
 =?us-ascii?Q?MVeT1k/euqVg4cHhhVqwOhRyXehlL1QVqYotkV/RdR/lX6xLjdofI0dd+GxV?=
 =?us-ascii?Q?pFeUYDgZAJju/eKb8D8JM1oXhNpUo+TWxZjj5hnbHgXaLwtLlFE4qA98/WWn?=
 =?us-ascii?Q?muycOhd9nJXH2lJdS1LYYQ1WGQLLd3cPecLY2hAvXszWDs8xhp8GSmT76UJN?=
 =?us-ascii?Q?MKDbCCJNeDB03i8mvcbcnoViCw6yAjZ9DYwYsXmvbKwfPVfAaxBAIwvr5hlN?=
 =?us-ascii?Q?SUSMXDXTrpfHOxqIYQTz6ee+8Au4tHcD7N/sDZd6v5NklytdchxmBMi/zMhy?=
 =?us-ascii?Q?c/wxIjVmCng7JElBd39n/NwbQc35hHYx9Maf38o8UF38ubbAYyhO6myG5U51?=
 =?us-ascii?Q?0QG/b8gDOEyVevmuaLYYvMqTP5cF0LH2SUApLtCUpCcOso9qKpDaGueR/dnE?=
 =?us-ascii?Q?Lkcc/0M336JIcDZYqL7wyg6WQFcGE2EB7KYHYo89ONCVyRmm3/GKK5n1AHDu?=
 =?us-ascii?Q?0yVUj/Luxelq2K3y6DzkENrNYsRRyeGi3DDqjidzFZip3Qb9/A+MRB+CEpYe?=
 =?us-ascii?Q?ZeEA+hrbUNMPBbvYnfCvch3pWqDK30xJEdgpTAXPxN80ULihfod8Erpg3PVX?=
 =?us-ascii?Q?28+ZH/5sKPgPWTb9OjyrzTWyDNB2Q4xokDUbTIt5pqr2JQaYdoULO/uhzCuG?=
 =?us-ascii?Q?CR7/kYMnQpzf94BxMAVQQM+omI6prJAJ07BJgqe12ge814RUuBXW46clyT44?=
 =?us-ascii?Q?537+e6O2FCNmFts8Zl37rJobbUGt+m4So5OgmFN4rWS8pEv61vUxaBzR9kPf?=
 =?us-ascii?Q?VlzuzJF5MhvVGxi4pcTieIKD0LEcEUEEanGPv2jSDnKEdjlM1bDxFvCITY0O?=
 =?us-ascii?Q?GRRzxLleHrI3/ELkqWPjLjw8dKVYlDpyQq1Ob4433avyv/V35h+lrUTUvDt5?=
 =?us-ascii?Q?BOEWsIOmpp4H96lx1RCTcTCSnrf9ARS8VeLtd4FKCmCI1MmA5QAgrgDP4cNY?=
 =?us-ascii?Q?T93FhQTarE8X7hHC7IjAaWkwIYrRL5JGn+rZYciPWyzP57l3qLqKdQ+w1Pv4?=
 =?us-ascii?Q?PlCAGoJ5PB67goQhHHOEp9+g+EE/iOqrT8Q6hpDX5dB0kLvzt+gb8qw/TKlT?=
 =?us-ascii?Q?A2VlAUktE6FGwgy+vym7jxCkVO3qJz91dgYp+Cdg0kXh1nb87JFQttCQBmb1?=
 =?us-ascii?Q?th37K8EMDULf2yNxLxgfAemCEq4tpDmfMjgCq8ytfQ4k0uWsvJnLoFXb+KFa?=
 =?us-ascii?Q?sOaR1SQfp5zWR0TnoQ6lbD4uW3CUvTKs+ZPEOvhmuAC9RHJJamC9Ygr51c1L?=
 =?us-ascii?Q?q8BNtBw41/yHq47m9BlppDe77gS/bGCGX9+tw4romS/iRtSP+iLyiBvLxElS?=
 =?us-ascii?Q?Tg8AT0DiV8jqXBsGz5W0IrSuYxO4glZhrB2rLhVkOvknNuaV0ybXPXPVRA4T?=
 =?us-ascii?Q?LkY2cEsem7MeHD1iZgny1P+C0LI1IwV9ltcPm/1GCge4W0tvjA3RU5tsCHu3?=
 =?us-ascii?Q?qjzS9zvAft5q7apdRIckFcBUNm5uW528VNqgDoLXjAs4wMDX5YWcCieJx4k7?=
 =?us-ascii?Q?yKx+2MtGYGad6Vzqm02/5piceUwH06Ra+arpzwSPfLDG?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb96af6-ab50-4e4b-f92a-08dac64ca4ed
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 14:29:31.4484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lOX4TpEdzG0MBgoMzY+8JZApz/8WFy7Ctfxxi4xFj0VLg1SV3N6gwxRVCcKJpGYooVz5qObJcYJofF0KptGusQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO6P265MB6873
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Nov 2022 17:41:21 +0100
Miguel Ojeda <ojeda@kernel.org> wrote:

> From: Viktor Garske <viktor@v-gar.de>
> 
> Only a few codes were added so far. With the `declare_err!`
> macro in place, add the remaining ones (which is most of them)
> from `include/uapi/asm-generic/errno-base.h`.
> 
> Co-developed-by: Wedson Almeida Filho <wedsonaf@gmail.com>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>
> Signed-off-by: Viktor Garske <viktor@v-gar.de>
> [Reworded, adapted for upstream and applied latest changes]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/error.rs | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index b843f3445483..861746f2422d 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -17,7 +17,40 @@ pub mod code {
>          };
>      }
>  
> +    declare_err!(EPERM, "Operation not permitted.");
> +    declare_err!(ENOENT, "No such file or directory.");
> +    declare_err!(ESRCH, "No such process.");
> +    declare_err!(EINTR, "Interrupted system call.");
> +    declare_err!(EIO, "I/O error.");
> +    declare_err!(ENXIO, "No such device or address.");
> +    declare_err!(E2BIG, "Argument list too long.");
> +    declare_err!(ENOEXEC, "Exec format error.");
> +    declare_err!(EBADF, "Bad file number.");
> +    declare_err!(ECHILD, "Exec format error.");
> +    declare_err!(EAGAIN, "Try again.");
>      declare_err!(ENOMEM, "Out of memory.");
> +    declare_err!(EACCES, "Permission denied.");
> +    declare_err!(EFAULT, "Bad address.");
> +    declare_err!(ENOTBLK, "Block device required.");
> +    declare_err!(EBUSY, "Device or resource busy.");
> +    declare_err!(EEXIST, "File exists.");
> +    declare_err!(EXDEV, "Cross-device link.");
> +    declare_err!(ENODEV, "No such device.");
> +    declare_err!(ENOTDIR, "Not a directory.");
> +    declare_err!(EISDIR, "Is a directory.");
> +    declare_err!(EINVAL, "Invalid argument.");
> +    declare_err!(ENFILE, "File table overflow.");
> +    declare_err!(EMFILE, "Too many open files.");
> +    declare_err!(ENOTTY, "Not a typewriter.");
> +    declare_err!(ETXTBSY, "Text file busy.");
> +    declare_err!(EFBIG, "File too large.");
> +    declare_err!(ENOSPC, "No space left on device.");
> +    declare_err!(ESPIPE, "Illegal seek.");
> +    declare_err!(EROFS, "Read-only file system.");
> +    declare_err!(EMLINK, "Too many links.");
> +    declare_err!(EPIPE, "Broken pipe.");
> +    declare_err!(EDOM, "Math argument out of domain of func.");
> +    declare_err!(ERANGE, "Math result not representable.");
>  }
>  
>  /// Generic integer kernel error.