Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 14:28:53 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <ojeda@kernel.org>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Finn Behrens <me@kloenk.dev>
Subject: Re: [PATCH v1 08/28] rust: error: declare errors using macro
Message-ID: <20221114142853.5200d36d@GaryWorkstation>
In-Reply-To: <20221110164152.26136-9-ojeda@kernel.org>
References: <20221110164152.26136-1-ojeda@kernel.org>
        <20221110164152.26136-9-ojeda@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3dRsfyZPPQmAzGWhjjiplqLeQWAvjvJK2iGZJPzdlSjWDaKzXVOcfCH16pY9?=
 =?us-ascii?Q?3Fa0yTAivbnEX66q6GRquiBoZSNVP+l+eKcFQaEq1L5xAspRklyCDAx6jSOw?=
 =?us-ascii?Q?2jdH2rfplctqmxbJ+29HFdj1UtNo5u9GvLGSEvlNoi/BxclixBmrUdx69oOO?=
 =?us-ascii?Q?DUpojqnBgXJ/AZ1BuAwPLigWo2fMPuI45xobKCMSPT8jTa1isF5Y7UtHjd4R?=
 =?us-ascii?Q?sPhTSrxoaCBl9z+19a98mhqdePyX1LiMLkguosSZrtUt8K8nQ3TZ2WCEl07/?=
 =?us-ascii?Q?5EdRAT6kIujOZr0unj2SNK3mdVLTpnwStbtlEb5TQ0fJCIJ/0Id+20xmmtGA?=
 =?us-ascii?Q?j6NZOPCYZ9IsIb+BZa6yf0cOYwsQcb9r93vzXBrZj2MGuSMyWtBaBg5kbNAx?=
 =?us-ascii?Q?YsSrX5b8i1fuUg/wffq+dihM7aY1S1s8alA9M+OfgcpMaRnsU8YJ80Iw1PcQ?=
 =?us-ascii?Q?kYtof+uK8ej6v+OTSGjyMfCHoMH3KLk+v7T6GMo7PhUWvK56NAVAIsAcfdAP?=
 =?us-ascii?Q?JHuccy1odv1rj2E/E9+nlyIwmDpLt4omyMhUwM4fkM/SlMNUND1/9sgZuk5w?=
 =?us-ascii?Q?v+ARbQsDO7ueKx2FYeDRR3UYYcOBo1li2Y5eFCwZH7N2uepnDUZET91YomyF?=
 =?us-ascii?Q?Gnqji4rKqYOvhUUim6E9Hw9QgJujxuZSJRv93Sp3a9CCFxZieSuhVU+um+z+?=
 =?us-ascii?Q?7roFVCZdKBV3mWZrTydGUchZDfygXSp37hjVmeTcpjC4cKBwX8AMLJB+j4/1?=
 =?us-ascii?Q?oCx5mW1MTLEaZsp5pMEKMMmigLKFAQvatvV2cQDon0i6pgcWvtZ+Z0VEoqMY?=
 =?us-ascii?Q?SdRjAbkKMP2HLdbfhIT4kZmNA3cec7RdsqH+YtYcdw/1vszfBK/0BUCqX2Px?=
 =?us-ascii?Q?vS+WkISYjRjYCYjwXk1rIKwJjUwCS6rGNc64FGHMWClNW8QNWdODpNgZ9Dku?=
 =?us-ascii?Q?/Lnexz8XSNdV1IbICcstqcjyvJS+gK8ryp8k+7VrqB7p7pX7meOm9JSBqw1S?=
 =?us-ascii?Q?ZEoY7cUVnHtn4m30yaubShr7VqU+yUvORCRAV9H5a7nsIRYk/dxB4cBoFYmA?=
 =?us-ascii?Q?EwArmYBOQCvAFH5+jkIH4VUm88h6c7OMP9aboUKy9/E/VMGlLT3gvwubMZr5?=
 =?us-ascii?Q?9kZYEGzf0AsYRPReNXGhA7IZtt0a8UIq0InCPYykHwPLdlvlqnr+IhfcXpUo?=
 =?us-ascii?Q?aBldw0YeybxoftyeJcO5b16OWl93uOrpcd4aY5Ae7Il5+57uC+VUg3XXCW46?=
 =?us-ascii?Q?WHdeqK6SQBZl8irgYAHIW3Ov50durbt/l8VKDj2/BpS+e7qbv87eqdFtZSAu?=
 =?us-ascii?Q?OMSIiIEWO86j1ADf90HZdE7gQ7P8bqmE3P3E+JkDG84bgt1gp8AAmRKqTdEq?=
 =?us-ascii?Q?JZ/JzL6mb3/2B6E9CXfs4RmaescczlCNN2ADKpUt36TfBf0Tp7Ag+h2b6Vkw?=
 =?us-ascii?Q?6R1b9QT+7YG/5ItjPRWWkVB9P94WJi2XFGF9yByR+5GgUO6bMGMBsi6GW0Jz?=
 =?us-ascii?Q?7z9Ut6Ed9HL4M6YTh8EWvOxF3PEOO9li5RtKLUe4OWRoThURI7bkjNz2MfJW?=
 =?us-ascii?Q?AMoS3S5Xk0PNZU4NFMHFbxKmK/inIBQu2a/yP+LUKuiOt7SMF/pj03xNy44+?=
 =?us-ascii?Q?b+BUUCTKZiM7KFNGDHvmBaLTcuV3heg/kpUyFSrjWTSU?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: cd24ea1b-eb7f-4b4f-b753-08dac64c8f03
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 14:28:54.6795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3DbFZQQCI847iG90NBSgYwziULVs8ZIdZIRWa20M1VinUs8UuiB41zTfX6yHxLnVf/vG7IYRS3Z+obpSugfCpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB2356
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Nov 2022 17:41:20 +0100
Miguel Ojeda <ojeda@kernel.org> wrote:

> From: Finn Behrens <me@kloenk.dev>
> 
> Add a macro to declare errors, which simplifies the work needed to
> add each one, avoids repetition of the code and makes it easier to
> change the way they are declared.
> 
> Signed-off-by: Finn Behrens <me@kloenk.dev>
> [Reworded, adapted for upstream and applied latest changes]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/error.rs | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 466b2a8fe569..b843f3445483 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -8,8 +8,16 @@ use alloc::collections::TryReserveError;
>  
>  /// Contains the C-compatible error codes.
>  pub mod code {
> -    /// Out of memory.
> -    pub const ENOMEM: super::Error = super::Error(-(crate::bindings::ENOMEM as i32));
> +    macro_rules! declare_err {
> +        ($err:tt $(,)? $($doc:expr),+) => {
> +            $(
> +            #[doc = $doc]
> +            )*
> +            pub const $err: super::Error = super::Error(-(crate::bindings::$err as i32));
> +        };
> +    }
> +
> +    declare_err!(ENOMEM, "Out of memory.");
>  }
>  
>  /// Generic integer kernel error.