Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 14:58:45 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <ojeda@kernel.org>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev
Subject: Re: [PATCH v1 22/28] rust: str: add `fmt!` macro
Message-ID: <20221114145845.519fe889@GaryWorkstation>
In-Reply-To: <20221110164152.26136-23-ojeda@kernel.org>
References: <20221110164152.26136-1-ojeda@kernel.org>
        <20221110164152.26136-23-ojeda@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sn/idpsNd7bssk5guTGsVDBJj3J4BxAMc0uUi0ADxWVRPR2om3jPXnamSwPy?=
 =?us-ascii?Q?Wd7rJkSberqmGdmoi9bVelXcbn2m4qnrbl0zzSrlTnEc09TNnUYXrUFeTKFg?=
 =?us-ascii?Q?Q+Sskjc3E6t76Ue9G9/uOpz42sTtu2ZNpj0PIRcGI7PNc2SsTBPPtXYl68Wv?=
 =?us-ascii?Q?QOayCtcw0f/ybaPeURocnacJ36pw+EySxP85CPHUEMn28zVOdqPVJFYhXEJs?=
 =?us-ascii?Q?eCHpMGsyDgGn9Na1XHe3AXNStCwoawNYv/o+dbggYyAHcC+4N0wuj+rGOs4k?=
 =?us-ascii?Q?f4/1XwxYgVymmCdRvO1UQzN06JuWP9ZaADWwuRWI2TE5szsn1Vpr6d7jy4rW?=
 =?us-ascii?Q?HBpiq44afTnsNv3Ou0NG0lyHzJb5eQG5QP5bwbcig1LFc4biGhSPjKH8s6Bz?=
 =?us-ascii?Q?2M9hnniFZQPWH8NMUA3y6wF8VsMvJJ2w4ZQAqpAKQOgVxfGYFIkTtIaAYCUx?=
 =?us-ascii?Q?mPqyw/PUw+WqQUs+vKxOBiJz2z9STYR0AFkaED/1Ztj1eDj7dmZlFHhGNMKY?=
 =?us-ascii?Q?NSkeQQQajqLe0g0ZIoDXnd/tTeWm3m4xb3ahtS9UtFRieWjC7MVwgDkpNLoR?=
 =?us-ascii?Q?KTcpYa6Y42wbg/XVYUryTU3NwXV//Jzzo6S9+3P3ZhJ4k9Rn0PiQs+oCw84/?=
 =?us-ascii?Q?4g0J2RS6yK79VJNQZHCeU5RM0yVrqsPr0s7HHnMFj2DgNhh5N35TG81++iq3?=
 =?us-ascii?Q?EGzoKzxGGY9pp88/Afjr+v2WZYD9shUAWqq1BDXEo4w7VtNa2XSbdYQ5xRUU?=
 =?us-ascii?Q?DtGpaf9Js2eRPfTbQxv58XAPnaukGZX5+IIJTImetG1T2s6fSjGlYb8cC3KE?=
 =?us-ascii?Q?9eKApolWphouwqHI4FU7/xlXipmpaMkH1c0pSY95WajY4VK0XBjA4JftZBxd?=
 =?us-ascii?Q?JOjOR4apsSCmD2AkXV+XrkhPq7ID3TOkVbogimKxPGt+X5M1LAUqwX8XzoLr?=
 =?us-ascii?Q?zaLHdkwCNf7T+Li4fcL2HXgwU4lX5vJcNYHgTgG+1vTvVKT8PWhzfWwDvKBn?=
 =?us-ascii?Q?+tUPYdiGbP2Y7SFZz33PUHyXBhJsInBrdwZez56OtY1wY6a419LNi9eZh+Nz?=
 =?us-ascii?Q?ULxVSnOr6ivDm4Ig6YzDwuguaXcWq8p/m0GQ1uKqyxpzUp98mZ4ZL4RzonpO?=
 =?us-ascii?Q?R98wk20mjfUkSFNwtgePlPj2BrcaJdjNU6qrZEc+M95lWlExVqPfsfXgWrPC?=
 =?us-ascii?Q?sfNkTkNW+JcKqsHNfGP4c3+JYjR1C8hSZSUtrjRKSpdhcE90rvE9S1vWQEVy?=
 =?us-ascii?Q?ZpNbSiOxuhiv0T58rtQQcY/VdRUSXIbccSQdeuhdAwgybK5TR+Gozwe9M2HN?=
 =?us-ascii?Q?iVYURdmha+iiDxct4TF/B7AOiYYIkgY63pMhkEtajr+LlpyNe4Iit40IjNfm?=
 =?us-ascii?Q?xft3jLEV/EBf4moQwth1NExqklE4DmoA9L6hoVFbST33xUJ5oDQUPW2ujsg0?=
 =?us-ascii?Q?Bf3NcQL2zRYPAiz6qhFefoGI5ORC1ePSe+r3jqr+3R3tuFEO9flD+8NSbZlU?=
 =?us-ascii?Q?pjp8IXOCBt2EburQ2aSev9zL627tUXsnCTD4oxDqyXp6fv+O/kwKuoZ/JiI4?=
 =?us-ascii?Q?IXGsaan5BF8ObKQabBi2VxNV7EDUPuyCXL73p1ZC6vtTVuoWXs6DSkB3gDQx?=
 =?us-ascii?Q?Yw0qNjYppIXXSBHhaqUgSjqpLJkZa5RqT48vrRJ/1FJk?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: ab11f999-36db-43de-d465-08dac650bb42
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 14:58:46.8373
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mwm0wezDzkrcyhzhMEVdjOPxETY3LEcYUK48Ggt6Y/IPt6iB1UPtLX8ANczZG8wmFtMPJvcj5IGD3Knt5ObFtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB1915
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Nov 2022 17:41:34 +0100
Miguel Ojeda <ojeda@kernel.org> wrote:

> From: Wedson Almeida Filho <wedsonaf@gmail.com>
> 
> Add the `fmt!` macro, which is a convenience alias for the Rust
> `core::format_args!` macro.
> 
> For instance, it may be used to create a `CString`:
> 
>     CString::try_from_fmt(fmt!("{}{}", "abc", 42))?
> 
> Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>
> [Reworded, adapted for upstream and applied latest changes]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/str.rs | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index 877148b77e71..ffac633423db 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -592,3 +592,9 @@ impl Deref for CString {
>          unsafe { CStr::from_bytes_with_nul_unchecked(self.buf.as_slice()) }
>      }
>  }
> +
> +/// A convenience alias for [`core::format_args`].
> +#[macro_export]
> +macro_rules! fmt {
> +    ($($f:tt)*) => ( core::format_args!($($f)*) )
> +}