Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>,
        Andrew Lunn <andrew@lunn.ch>
CC:     Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Topic: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Index: AQHY8+NzKrQRZ3k0YEy+QDrsvHgkC644DoaAgAAaV3CAADZxgIAAUdXAgAXC4QCAAARvAIAAAdMAgAAPjpA=
Date:   Mon, 14 Nov 2022 15:01:46 +0000
Message-ID: <PAXPR04MB91850496D46660D3B8394B7F89059@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20221109023147.242904-1-shenwei.wang@nxp.com>
 <4349bc93a5f2130a95305287141fde369245f921.camel@redhat.com>
 <PAXPR04MB91853A6A1DDDBB06F33C975E89019@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <20221110164321.3534977-1-alexandr.lobakin@intel.com>
 <PAXPR04MB9185CDDD50250DFE5E492C7189019@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <20221114133502.696740-1-alexandr.lobakin@intel.com>
 <Y3JHvo4p10iC4QFH@lunn.ch>
 <20221114135726.698089-1-alexandr.lobakin@intel.com>
In-Reply-To: <20221114135726.698089-1-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GuQjTXds0umjqxWFKK5MFZ4J5hKMiLwnIPpViRT9pdb4w+qmMe0kXKFsLuMT?=
 =?us-ascii?Q?0KjoBwykCU8+/UCp3jf6d6IJal6lBIQuHR3zHNtJe+JAI43UjohtHfTRkz45?=
 =?us-ascii?Q?BFtbyRvh/EGos1Uk4KYlX8N0XetcsZipZHUaGJn86sEN7NX/xoiBEsMIf13/?=
 =?us-ascii?Q?R2FELDwCLyfWB/hHPNp0EM18mVZ33swZ4A5QlseORSbukUd6wXGY4WivgGMR?=
 =?us-ascii?Q?qJK0TBqk5n1CnyU89LTO1EKYbcNKocVd6Rsrv1h8JhXtf3DmXv1Qq1JYPMus?=
 =?us-ascii?Q?SwFgED/rCEDK55FEOxsv/kS/L5F5N0mQTeQU+1oQHcoSGHySzBoNcrurLJmq?=
 =?us-ascii?Q?A95OvucXwsu8mwZuYxATi/b9m1gcxutCkkvG3OgsFhlGbFclQmb/On7LyxQy?=
 =?us-ascii?Q?cmGFL5lzlu41pU3keB5TD47LbjkBWn09f/UGPdUt9wVHkpLvkVbsCor7XT16?=
 =?us-ascii?Q?qxcsMq/roDCdVlB2os5/DTIwtZNSVNKQ9IKamps3Gatxln0LMVDav179Inkh?=
 =?us-ascii?Q?CcrEbNgolrOSfr2mgHdbgIbTpBM+3ViahmBWk75qX+qZoKeHhiGGTPH7yiYb?=
 =?us-ascii?Q?HxMhB6+4oyurDhPQKvX6ThSqYPcs3/nmaH9ryMlSdx0cl3uayxqNZMg6MsGk?=
 =?us-ascii?Q?TRuDgKN6O0d6gFY5ja9ov2xfN4SJXIT1639MImoGLhGNOnhlyGeNGXoWW9Le?=
 =?us-ascii?Q?bqXS3q9Ge81haZYqhjZ05Yygt90RT/Vm2hocNbJfDWFGwJenDhQdRqWHNX3E?=
 =?us-ascii?Q?eMhgW7rG1rgejR8owmc3npOzO52z4jbimEUoOqTshzGWRzcNGyx+sTzxJAp2?=
 =?us-ascii?Q?UPNj/s/2bOJDWNVfHJnBG+MZbpMi1Gcdoz6DbaBvJ3Kd/u+z1hW9rMR1d7Nv?=
 =?us-ascii?Q?F7usOhjoU4+Hx43EmBHsPgjqV2fXG8SSYX+9tovIUFBODlNdyXty9V/th8MY?=
 =?us-ascii?Q?akuLGLy6QZliE4OPD22U005lZ1PxAswu+4e1EeGQOobGuSoCC7fD5U6MP9xX?=
 =?us-ascii?Q?W4l8RK1eNt57M+/87ELoXv29ifthN4CorhmhqdXFR4c0KDww4wgPZ3rA6Aw0?=
 =?us-ascii?Q?wR9PCzYwSxffko92kZ+B93Qqsmh+Hj19QR+5WzYH28xwmImvsoWGy5/iGfJk?=
 =?us-ascii?Q?XaKeapCu5OF3hZdTKR7Nq4vHBCAoO1f3aNLLANLRjr9gvXRSjWBPvYPr4oPU?=
 =?us-ascii?Q?UBzx4fM2zxEPfLPGrD+1PJ0/ucfv/O6DLkkQ03Is3TRGPtSE1bKuT6E8haRk?=
 =?us-ascii?Q?7RXS+P5bgU3uvewQMnnDhkXI9bp+UAxNOaL1jgg+bw8c8boRwT7eS50bTGtl?=
 =?us-ascii?Q?CZmMxJQhm8kfY+2EMoAHoqIEYK89YmQXPFJhWzi/kvX3ZFLc2EFknVtCgLXL?=
 =?us-ascii?Q?jLDaoALOVkvER/aNcDRj8ebkocHsss6Ubo35e19KWVkOXAtuqv76pmI2Cr7u?=
 =?us-ascii?Q?D0qAG4x9p/b9ZtU4Y8ZWcUqkkkz5fXKESgkyBvzmOLbF7aPWxJ4HS5xqoF9b?=
 =?us-ascii?Q?NnZfkO7RIAP2jYspfwUDVulupQrezV0LOC0r1+C1NiX/JPYgTHl8UmC729JZ?=
 =?us-ascii?Q?w6l9raGHnHngO5/O2mf7r7+BsRMZyNZcn8AQmU/H?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e744bea-9cf2-4759-68e0-08dac651262e
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 15:01:46.1104
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NLyI+xkRxC9cvpmL0G2lIFHtNTFowN4OThiaKvshdjy420+vSDH6GP+8VUYYoiduJyPe5xv0zNNBNo1tCDHh/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7458
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> Sent: Monday, November 14, 2022 7:57 AM
> To: Andrew Lunn <andrew@lunn.ch>
> Cc: Alexander Lobakin <alexandr.lobakin@intel.com>; Shenwei Wang
> <shenwei.wang@nxp.com>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Alexei Starovoitov <ast@kernel.org>; Daniel
> Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer
> <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
> statistics
>=20
> Caution: EXT Email
>=20
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Mon, 14 Nov 2022 14:50:54 +0100
>=20
> > >    What is your machine and how fast your link is?
> >
> > Some FEC implementations are Fast Ethernet. Others are 1G.
> >
> > I expect Shenwei is testing on a fast 64 bit machine with 1G, but
> > there are slow 32bit machines with Fast ethernet or 1G.
>=20
> Okay. I can say I have link speed on 1G on MIPS32, even on those which ar=
e 1-
> core 600 MHz. And when I was adding more driver stats, all based on
> u64_stats_t, I couldn't spot any visible regression.
> 100-150 Kbps maybe?
>=20

I did implement a quick version of u64_stats_t counters, and the performanc=
e impact
was about 1~3Mbps on the i.MX8QXP which is 1.2GHz ARM64 Dual Core platform,=
 which
is about 1.5% performance decrease.

Regards,
Shenwei

> >
> >      Andrew
>=20
> Thanks,
> Olek