Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Alexander Lobakin <alexandr.lobakin@intel.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Topic: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Index: AQHY8+NzKrQRZ3k0YEy+QDrsvHgkC644DoaAgAAaV3CAADZxgIAAUdXAgAXC4QCAAARvAIAAAdMAgAAPjpCAABpqAIAAAKYA
Date:   Mon, 14 Nov 2022 16:31:46 +0000
Message-ID: <PAXPR04MB91854E3A8555B067FDEFBED089059@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20221109023147.242904-1-shenwei.wang@nxp.com>
 <4349bc93a5f2130a95305287141fde369245f921.camel@redhat.com>
 <PAXPR04MB91853A6A1DDDBB06F33C975E89019@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <20221110164321.3534977-1-alexandr.lobakin@intel.com>
 <PAXPR04MB9185CDDD50250DFE5E492C7189019@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <20221114133502.696740-1-alexandr.lobakin@intel.com>
 <Y3JHvo4p10iC4QFH@lunn.ch>
 <20221114135726.698089-1-alexandr.lobakin@intel.com>
 <PAXPR04MB91850496D46660D3B8394B7F89059@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <Y3Jsenmh9dbAauQS@lunn.ch>
In-Reply-To: <Y3Jsenmh9dbAauQS@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AACzuL4VTJYUFrtH9VDvHUawEVn2YWB9/n74UeyBrPo8S3Quy0ZGpkF+Qa2Y?=
 =?us-ascii?Q?/9Mm0D506KymN6JAVU8mhZzfq9mvn4DpRnXxfIxZcW9ZHkS2VhS0AQOK6ZCL?=
 =?us-ascii?Q?Eh0vTFRozYRFEaPj9txyax8TpDNU6qnArEHuYuQ+UKjQYWZsMSCXv9ZH/0ol?=
 =?us-ascii?Q?N49GuBBD6oAN923HYJuIBrK05qa+lPIdZ5BWvRRpD4OH0nyB/wagBnWiNUHL?=
 =?us-ascii?Q?L+2K0SZOAkMyhedWrHRKotmrD95UUEXLKQpAPG+7WrG1zCaXVLL37SBCBAcu?=
 =?us-ascii?Q?Mp+wB4BnjH0/f2JXeiV967HZ23xG4JL8DM0klGTSY0/wvNfIBldCKujAs9pM?=
 =?us-ascii?Q?rrZkyYlb3i/BvNREWMeGi7mfyMMFPHmpWfobG5k8DHrgE8+fkaN3msvbFjMD?=
 =?us-ascii?Q?n4g+CkwJKHNtSF7VofUCb0oo8jpt8wgrI6Z0p3mgilvks/HNwncWeDfHjvVa?=
 =?us-ascii?Q?F5BGmAXZb0sFf+ytWpj+VSSS7FlWp9YhOVifkUI6youRLL70TMYBKPuHuTIn?=
 =?us-ascii?Q?PHY1Dj3Yoc3XZHpp5Ed28Xaz5Z0t+FPE4RzNqJyAsQifHa2MLrBWRshpDYv9?=
 =?us-ascii?Q?GbSLgwIHwQDAvrs1t1tQ1k/SBn2oEx7wj7kZPErBkQ5QAi39lVqkBHJcmGtn?=
 =?us-ascii?Q?uw1IVim+9WmxLdQRTGF6G7hrhU7eYxsU+MczFPRIJkH/SdvDZKs4aqM1rxQG?=
 =?us-ascii?Q?5b8KHnUJc/5cVSdxQ89bND8s3g1WLnpQbHERhJy2/JSAmquJkgMkO0fjbNSd?=
 =?us-ascii?Q?7C4yvFrZqReIHKj4EtC0dS+HavXkU6PEogS7/K8mVL9vgG965wINeh2KltpD?=
 =?us-ascii?Q?MGqognma3+6zLFvp2/GOszzGHA/5TYCNIDYjDvpn62xv1oNYpmMt0/Vd503+?=
 =?us-ascii?Q?Jqx97OtXUsu0FmI7/rythisHAJR1QucowH3/2SmVH1rzPpNsuI4oOdIaFpnl?=
 =?us-ascii?Q?lr5sRu5the8o4DSA9ntRgyHeRYWPxj/UA+adnRRPlQGqXa7dmucJ9a+2Cgkb?=
 =?us-ascii?Q?7MCghCi3bwGMcadJa9qPKc+mKHeidZuio0NCH8wHspvrXjYwgedKzj868szT?=
 =?us-ascii?Q?18OCb1aJuvKnvhFgI8sgC03XynwKLyw/3SBWTxcimQML55vcuxzlM9BGn1Ix?=
 =?us-ascii?Q?4p8kfP9lj94FtVbV57q2/YmfHBD3kweFcb5OSzmKfUELGdpRd1rutkEk7SOZ?=
 =?us-ascii?Q?et4PWlajg8w5vteSilx4+Ajqw/XJiMq34CPohpGPMXWm7bHrJjZhP23zXv9x?=
 =?us-ascii?Q?2rot3B5+9a5XbcM45V0AjAsUPiWpBlq91z4eCoRNSOVzZEmNGe25C/qW9Puz?=
 =?us-ascii?Q?Z6GTo6pHNdCZ3nxku8xpedZ79uona5c72GsyI1yuITDdDaOSbk4rAREinMtt?=
 =?us-ascii?Q?NSKcwXMItceGWQKdRdPL8xaur+4V7v7TZB8axk/Es1VYK1OwJruJIwQyqxeB?=
 =?us-ascii?Q?l/TX41fGyWU4mYQX8XTqV9F46Dk2Ezer1DKCSd6snSXH6qOWKMjW2Xebrssv?=
 =?us-ascii?Q?PE5S9OmVi5aNjbDzwH0+ke8BeMZVWCRAwBt4NKzZYa+ZikD/VeVbW8Xi2HdK?=
 =?us-ascii?Q?w9eIDWQ2wx5+QcieZxd3pYvTdtAE4u0lUx6pOvko?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87e27e6d-1f44-4a1a-106a-08dac65db950
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 16:31:46.9176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2UFm/vXU05Kb+oihVVLJViUxGTm5+Bk4nZfOeQn4i+pEmji2al7H+yUOjZz80aelXBQVeIbT/ivJCpuQurMkbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7565
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, November 14, 2022 10:28 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Alexander Lobakin <alexandr.lobakin@intel.com>; Paolo Abeni
> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page p=
ool
> statistics
>=20
> Caution: EXT Email
>=20
> > I did implement a quick version of u64_stats_t counters, and the
> > performance impact was about 1~3Mbps on the i.MX8QXP which is 1.2GHz
> > ARM64 Dual Core platform, which is about 1.5% performance decrease.
>=20
> Please post your code.
>=20
> Which driver did you copy? Maybe you picked a bad example?

The implementation was not optimized because it updated the u64_stats_t cou=
nters per packet.

Thanks,
Shenwei

>=20
>       Andrew