Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 09:15:35 -0800
In-Reply-To: <2b3f2420.130.184706d34e6.Coremail.wangkailong@jari.cn>
Mime-Version: 1.0
References: <2b3f2420.130.184706d34e6.Coremail.wangkailong@jari.cn>
Message-ID: <Y3J3t/ieGaOG8Qjl@google.com>
Subject: Re: [PATCH] samples/seccomp: fix array_size.cocci warning
From:   sdf@google.com
To:     wangkailong@jari.cn
Cc:     linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        keescook@chromium.org
Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes
Precedence: bulk

On 11/13, wangkailong@jari.cn wrote:
> Fix following coccicheck warning:

> samples/seccomp/bpf-fancy.c:83:39-40: WARNING: Use ARRAY_SIZE
> samples/seccomp/bpf-fancy.c:86:44-45: WARNING: Use ARRAY_SIZE

Not sure this should go via bpf tree. CC'ed Kees

> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
>   samples/seccomp/bpf-fancy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/samples/seccomp/bpf-fancy.c b/samples/seccomp/bpf-fancy.c
> index 1ccb435025b6..548f038924d6 100644
> --- a/samples/seccomp/bpf-fancy.c
> +++ b/samples/seccomp/bpf-fancy.c
> @@ -80,10 +80,10 @@ int main(int argc, char **argv)
>   	};
>   	struct sock_fprog prog = {
>   		.filter = filter,
> -		.len = (unsigned short)(sizeof(filter)/sizeof(filter[0])),
> +		.len = (unsigned short)(ARRAY_SIZE(filter)),
>   	};
>   	ssize_t bytes;
> -	bpf_resolve_jumps(&l, filter, sizeof(filter)/sizeof(*filter));
> +	bpf_resolve_jumps(&l, filter, ARRAY_SIZE(filter));

>   	if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
>   		perror("prctl(NO_NEW_PRIVS)");
> --
> 2.25.1