Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5802000rwb; Mon, 14 Nov 2022 09:36:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Z2A56lQyxUMF68eTgOcuFyXNwYLE61ZA8DbpjQQhpGKPC7aDJxCMoFGK/lwi0kne6XPL5 X-Received: by 2002:a17:90b:1908:b0:213:90f5:274 with SMTP id mp8-20020a17090b190800b0021390f50274mr14103065pjb.182.1668447418782; Mon, 14 Nov 2022 09:36:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668447418; cv=none; d=google.com; s=arc-20160816; b=XhDinN3qSqGb+6E2078WkpOsKPvbwNe9g0Y6OZwuie+Ck4qxpI8f5z4uNO6QrLcRae o0JJnR2/D7jz5eXOoBO51+TTBILqIlmoRepAcL1YWVmcnwxr8B+w+VRKbfpGj4n3PUOw cgZGKursSWSCDsQhMd1OwpdyU3vQaOvn2FApV3cMI7m/lawXjelftXjLwLqJ8oJQCL5n szlpwy6zs7iw9l7oT8xNVDAoTqI/FAZ1FuhbmmtGNkesPYH6+X18F0e5tA3KQ/INSQQd l3ahscCxrNWMfDOOFEdsXuE0jpDKxqvP5ZsHlL2qlEC0SDEqzJkHvZ+id8UpsEVcAfK3 Sl5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wT6o0OrebUSwzOhZh+3/UUhOPE7I7NzbkchRW0gSA5s=; b=KI6SdjHZRljSahUojasEZKI9srTg+yrzWpZqfim2mnbqi/ZMF7GmitWoX6ZgHD7S+H x6OvYRcGuTV/J31JSPVbXFHyYhc3NxkueJWPRZ0hRxftov1aZjhFHhh0yAdXELZn5abA sQwYiGcCP52jLpfj54YdkfZS/9wIvtYPfKf6rzbQERCeK2oMw8bNOJGDdaJgLip4EqI6 /NIjM9grFCEB/onJ6OGyQY7lRY6cwkXIZ+ya1n50VqxH8n/PFvikLrFjq3MuAeFXDBTO yRYMa4kPyMTGx82g+n1Xx4gA7+WoHTxwvOTEeiYLtjrY72N5IYkSqxa5IraonsaUMMk6 4SSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=AdBKKJZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020a170902d70900b001865f96f6f7si8380587ply.104.2022.11.14.09.36.46; Mon, 14 Nov 2022 09:36:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=AdBKKJZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238163AbiKNRIl (ORCPT + 88 others); Mon, 14 Nov 2022 12:08:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238167AbiKNRIk (ORCPT ); Mon, 14 Nov 2022 12:08:40 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 097A938A6 for ; Mon, 14 Nov 2022 09:08:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wT6o0OrebUSwzOhZh+3/UUhOPE7I7NzbkchRW0gSA5s=; b=AdBKKJZdfHU5+/m6Myydrl9v6R z8fHiRwDgKLzpPsKt6V1dSRWNRXE+M8JJD1VqwJH4DpigXSlt1MN2+6iuqoDt6nvCzXq7HSeD0dA6 P+yOyr6NlY35XfWX1c5iu6GsOGyozMW35Enfp35fuzUS96/fDWu05L82DHW6C+4paeODZw7/0hET+ QFnJx0pLEiYUwCOUQ1Y7rs/Zx7yMEdhDz2l0iZqnimmTFnMD3JwEqEaMGrmCKTMF97oTavOSAKYVX eor1OCct6ZN5QUTCKWR3LseG6qCp9t4LFXHXxOJjNJNtvNxLry1s0EhIs/TEOPNBOHE7vVN8bSIy1 iBvXOHfg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oucwi-00FZoN-G7; Mon, 14 Nov 2022 17:08:32 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3438230062A; Mon, 14 Nov 2022 16:51:08 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1199D2C0A1522; Mon, 14 Nov 2022 16:51:08 +0100 (CET) Date: Mon, 14 Nov 2022 16:51:07 +0100 From: Peter Zijlstra To: "Jiri Slaby (SUSE)" Cc: linux-kernel@vger.kernel.org, Andi Kleen , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Martin Liska , Jiri Slaby Subject: Re: [PATCH 08/46] static_call, lto: Mark static keys as __visible Message-ID: References: <20221114114344.18650-1-jirislaby@kernel.org> <20221114114344.18650-9-jirislaby@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114114344.18650-9-jirislaby@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 12:43:06PM +0100, Jiri Slaby (SUSE) wrote: > From: Andi Kleen > > Symbols referenced from assembler (either directly or e.f. from > DEFINE_STATIC_KEY()) need to be global and visible in gcc LTO because > they could end up in a different object file than the assembler. This > can lead to linker errors without this patch. > > So mark static call functions as __visible, namely static keys here. Why doesn't llvm-lto need this? Also, why am I getting a random selection of the patchset?