Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <4fedab7ce54a389aeadbdc639f6b4f4988e9d2d7.1668386107.git.jamie.bainbridge@gmail.com>
In-Reply-To: <4fedab7ce54a389aeadbdc639f6b4f4988e9d2d7.1668386107.git.jamie.bainbridge@gmail.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Mon, 14 Nov 2022 09:31:38 -0800
Message-ID: <CANn89iK-X6hz0F3g1+J52cxVvm7LNizNa5fmnhpyCMJeYZBbaw@mail.gmail.com>
Subject: Re: [PATCH v3] tcp: Add listening address to SYN flood message
To:     Jamie Bainbridge <jamie.bainbridge@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Nov 13, 2022 at 5:00 PM Jamie Bainbridge
<jamie.bainbridge@gmail.com> wrote:
>
> The SYN flood message prints the listening port number, but with many
> processes bound to the same port on different IPs, it's impossible to
> tell which socket is the problem.
>
> Add the listen IP address to the SYN flood message.
>
> For IPv6 use "[IP]:port" as per RFC-5952 and to provide ease of
> copy-paste to "ss" filters. For IPv4 use "IP:port" to match.
>
> Each protcol's "any" address and a host address now look like:
>
>  Possible SYN flooding on port 0.0.0.0:9001.
>  Possible SYN flooding on port 127.0.0.1:9001.
>  Possible SYN flooding on port [::]:9001.
>  Possible SYN flooding on port [fc00::1]:9001.
>
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>