Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Alcock <nick.alcock@oracle.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     thunder.leizhen@huawei.com, masahiroy@kernel.org,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com,
        kris.van.hees@oracle.com, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v9 4/8] kallsyms: introduce sections needed to map
 symbols to built-in modules
References: <20221109134132.9052-1-nick.alcock@oracle.com>
        <20221109134132.9052-5-nick.alcock@oracle.com>
        <Y3BhRvt53xO5A0iQ@bombadil.infradead.org>
Emacs:  because one operating system isn't enough.
Date:   Mon, 14 Nov 2022 17:04:55 +0000
In-Reply-To: <Y3BhRvt53xO5A0iQ@bombadil.infradead.org> (Luis Chamberlain's
        message of "Sat, 12 Nov 2022 19:15:18 -0800")
Message-ID: <87mt8tv554.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LKxKysIenlIISde7sCZ2ghTb9kqgxEELYj14CGS1QICL8XrnANlkj6/rFO4s?=
 =?us-ascii?Q?/y4dZRG49qn5ZPBUy1h7l5yz0V7LGR8B+bcPYV9IZ+ESvRJ00lk256xIGPTL?=
 =?us-ascii?Q?SfuY6Nc6S1iS6WBt9APvsAZ7GnmUvczZiiBsr5BkSrY1mdOgkmUXy5RfsPEO?=
 =?us-ascii?Q?PIz4DILjft9W6EkeWMT33XXoKWYosTSUHJg+CJ+CNckDl8qj/ed9X3QvFXNI?=
 =?us-ascii?Q?MDHZJQs1qM+508PkVgYceSUkujpD00vo5NwtTbx+eJxWPUnSbnbVcdJvUp7N?=
 =?us-ascii?Q?8JiLrSzwm+gWi+j87sPzlLIxaH6NkJSCNjQma/5SVMpvagdC5CAi+vYMTRvy?=
 =?us-ascii?Q?jOa05LYuxmlL08N8CZ7orQSmPKhhmXElrloH3wPnWoXiPl8Omn5CrgvNqxdd?=
 =?us-ascii?Q?g5wm5G+hZvdun+hE4zr++65ciEOJjGehcrdQJlsHZxLldCZLEtF212S/6u9y?=
 =?us-ascii?Q?4m9D4mdIIIbpZHb1ISSEJDotqvUHguFuQKpIU7DjMZFsaVKcMqEIX1VsSPhT?=
 =?us-ascii?Q?bUsTrdyGyTKxgOLnCkkwtGt5DS4AYDi3IZBITZbjSwAvi+pO+LHAx9K/qqkW?=
 =?us-ascii?Q?z218/CpXCd/CejcVgs10WNa/+mooZ7v+hJcReOSjHnW3ckn3lTos/RTyEJko?=
 =?us-ascii?Q?pRMji7iFL3GJ5cCh4Pb2HKEtiK9izvBATeotIOdf2ChrD4jsJAKSDD/O3NLW?=
 =?us-ascii?Q?Vamgs1NPtLC9VaVmAVTJWbdXkowqvkMrOslroiJXXUTz3DYVRvR7cnO3jMrt?=
 =?us-ascii?Q?rFhFt6Ccb1dGDpB998+esWL/nlxYVVJf/pW1yagOXA1zR9LUOnvZuJ5liOv6?=
 =?us-ascii?Q?xH43AqcEEprKWEMK6Cy9KBzXMESx+b+U0HBLZNv/MXOSANPHnZqdkamvlddv?=
 =?us-ascii?Q?+Whx6jGs54cui7fvbv2oyCwJKYUQ7/iXsFiBiRNdZXQHlfsQ5wt8TlfcH9p/?=
 =?us-ascii?Q?x3/XeyXYBexiLsWrypmln/wsZsUyvv+sR7pciYvjaRnZ2AJ2emoY2jcIYGM7?=
 =?us-ascii?Q?d1B6p9YvfQeA4GdC26ozKP+DDlR5bgqQDVyaDZOpdcTf9XORe1Efbb60ClVQ?=
 =?us-ascii?Q?+UTLks5H99RJgfk2RQIdk7DHjlbNBfuXDOSmiypT7Oo8KXwSbnhZM049/0Aw?=
 =?us-ascii?Q?rY+TYzX5XhqpNUifoutBRVquk+Vc38mfVyoWtwFsl9YIgVg8G8gJudFtCjKM?=
 =?us-ascii?Q?f9f8DzSsXaOepsKRhrSi9m3yOv638lBaRZ6MZuC5h0RlJbbFRj6wDEp+SFEH?=
 =?us-ascii?Q?2f5Tu/EvJDifVo1FJSvFhSHyrF+KMfGPdizzKJu8ns+Wx9MKgDxj93C7x1M1?=
 =?us-ascii?Q?0/ET3EhMnb95wfJd3DjpEYelQ1pyJWgpgxB8hxbncwcC4+oCh+wUwWn+1vmr?=
 =?us-ascii?Q?/Y8TsEFb4dPm+c2/hpWurOZUhbr+3vuz784mo6/a5KU0sGM53bu32mvhQCqc?=
 =?us-ascii?Q?SO9V/5+R/OpjPLMJCG4X3PkMR81NTMVPNMkNRz+EoZqxRkWGnoNTlK1xspYr?=
 =?us-ascii?Q?KnINk/fmP9ZCEPyuJRZtDrA3cHw6j0GS0fp6YtadryXBquShsduT9RVoC6LA?=
 =?us-ascii?Q?7RnIvdPL05z+kL9EHwwAWsoURFqOAZSsqg9MfQkC3MC1i6/itgUD5lqERF8R?=
 =?us-ascii?Q?/g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?snZcOYDFUknv5QT5/NcoE+LYZ3dwJmrS5Is4TsQVOPnn0DWESBcg3VXfoWsV?=
 =?us-ascii?Q?hgDi/vRrcbEmcOkMZhvg8J+euGWc2YjtBjnhALjqFrT8W2Eaqk+jPBx30mlJ?=
 =?us-ascii?Q?Bm3KWKFvM4CNMhZ5QXsdrCoMnBXfjv0oMOOVBy7TxHfLGVDJxzsaLljAjhCY?=
 =?us-ascii?Q?gDluUY2LsfMUHn9GGVnaKPQTGj6mChegB4nncLUjkL/s455OdbLRwW7m5N7B?=
 =?us-ascii?Q?87DkZwestvljZo0g0wPXA7nAqMxhumB44YpMMgc50gHgu5MyCHvkDimUVVTW?=
 =?us-ascii?Q?9aewSCpN4MIfv50tDgpnbahcYS816woBzZaoqYwbTePAX7Wtk8B2ob8UU4De?=
 =?us-ascii?Q?dUwm5+GYVY41v3gOayV/7HrHhV3d3gqAa8HB/TOhFA4rUBzr8Tu6SGQ92Pe2?=
 =?us-ascii?Q?zi6UPhYInqZRRvmqC0C9K8r/6XfMXIk0oWy3LQRUWtLi+fFFA5nYkcxseqVd?=
 =?us-ascii?Q?9HQn+x9uqstVc5tPJqJGSfm2EFXEa98slROzhN+ifnL6MMu67ANe4LNucf+Y?=
 =?us-ascii?Q?qashDHtAmngWIyYe/h/KukdGU5MWuUipfaaBHLgPxA19RX5L88/+U4uZZSdv?=
 =?us-ascii?Q?Yljywx1wuE0qy8q5QGKIZFSRk7jGeLVIfMGOjn34kTSq59fA01NXHNyl/gwr?=
 =?us-ascii?Q?VbjcHKUV6CPeGk07SKgKU6c8KXRi8jBX2qHPBCaecxOtTisMgqfbIG3SnJ/W?=
 =?us-ascii?Q?3g/93Ho7wxPsUMlU3fozhCmqA3umw4NgACxkzzbQyFarKg4QdJs2glBW8xkh?=
 =?us-ascii?Q?Jc3quV60B2FaTWQEx5Pt+iLTtPWOg9MxQm5kPnikMLuqlPs7EYSl1enLJ3un?=
 =?us-ascii?Q?jLFyh4t8Do9w5dAFTmHHM6K08p3/70r/602ZDvpualUz2HHktXm+AA7u/6wr?=
 =?us-ascii?Q?gOZzDllmnJSFV/h2uT5ff1g0U4NuKORByM1GNVMJc8zjVKN6GrS9AJ7g5hJx?=
 =?us-ascii?Q?skuKqbNtGBFvu7ohqeQnSUkCDpvJPpk0fYdF6z664CZtCQQLQcm1j+SBW0FY?=
 =?us-ascii?Q?PRFA?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e544e605-8400-41cc-59a0-08dac6625c5b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 17:04:58.6025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pk3q7hE2CWO0VihKRDRUTUFQDJw1yfHQLOj81MmMZSijjcT1BZ1MBlm0ABEFBNIsERWAnYqzZQygjWgjSrQqvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6278
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-14_13,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 mlxlogscore=906 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211140122
X-Proofpoint-ORIG-GUID: c8qYa1lUPjcKT2wnJkxa3cHuPt336vNk
X-Proofpoint-GUID: c8qYa1lUPjcKT2wnJkxa3cHuPt336vNk
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13 Nov 2022, Luis Chamberlain outgrape:

> On Wed, Nov 09, 2022 at 01:41:28PM +0000, Nick Alcock wrote:
>> The mapping consists of three new symbols
>
> The entire commit log does not describe *why*.

... because it's in the other commit logs and the cover letter. I can
repeat the motivation in this log too if you like.

> Can I also trouble you to rebase on top of modules-next [0]

Sure!

> Does the kallsyms loop more than 3 times now with Zhen Lei's work and
> your new symbols on top on a allyesconfig build?

I don't understand the question, sorry. If this is about the number of
KALLSYMS invocations in the kernel build, that should be unchanged by
this patch. This was an explicit design goal because it's quite slow to
run kallsyms more times and I was already feeling guilty about having to
bring back the tristate recursion.

I haven't tried it with Zhen Lei's work: will try for the next
iteration, as a matter of course after the rebase. (And, looking at the
patch series at the top of modules-next, wow is that quite a hefty
performance improvement. And a hefty memory usage increase :( I have a
horrible feeling that one of my machines won't have enough memory to
boot after this goes in, but it was terribly outdated anyway.)