Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <50a9e9c1-68d6-4edd-42e2-c5b8a9ac7e8a@gmail.com>
Date:   Mon, 14 Nov 2022 09:59:09 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH net-next v4 1/4] net: dsa: add support for DSA rx
 offloading via metadata dst
Content-Language: en-US
To:     Felix Fietkau <nbd@nbd.name>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>
Cc:     linux-kernel@vger.kernel.org
References: <20221114124214.58199-1-nbd@nbd.name>
 <20221114124214.58199-2-nbd@nbd.name>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20221114124214.58199-2-nbd@nbd.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/14/22 04:42, Felix Fietkau wrote:
> If a metadata dst is present with the type METADATA_HW_PORT_MUX on a dsa cpu
> port netdev, assume that it carries the port number and that there is no DSA
> tag present in the skb data.
> 
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Is the plan to use the lwoer bits of the 32-bit port_id as the port 
number for now, and we can use the remaining 24 or so bits for passing 
classification (reason why we forward the packet, QoS etc. ) information 
in the future?

Might be time for me to revive the systemport patches supporting 
Broadcom tags in the the DMA descriptor.

Thanks!
-- 
Florian