Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5871539rwb; Mon, 14 Nov 2022 10:35:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf6l/csOVkuuZPdCAC0FrI6JbUkOk3o5SSqi8+MG2ELxi9xr4mxrYIcoHCPZXmWqa1gRvPx4 X-Received: by 2002:aa7:c6d5:0:b0:461:2915:e41d with SMTP id b21-20020aa7c6d5000000b004612915e41dmr12093874eds.184.1668450957526; Mon, 14 Nov 2022 10:35:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668450957; cv=none; d=google.com; s=arc-20160816; b=CM55F/PAEy2EDp+nTDKTMnu+SXPekzkww9i+cy92swGHAs/iDtmqshLl/4P/h626cq ssQn/gSJK/E5IoqDu2p8qka3v+AfuS6vqcrsddWer87pmgOi4/ZZKP0tU6COus2BlXrd cRCuDs9m1BD3WkYDeo5QfgNpNzGXpyaLTDydXUZPmTpnspsSnr617U4kA6HWdj01RoRm jIsIYNiXgZTPNqRl9XMldSj+g4MkK+NDSlct3b1IpBmc5+KjsbJGob0xynMXkph4/all zherLnrI7dUuXOpTUe0pbZRW1KiqL/b9xo/GOgMWPvdQLX/7Mh7UY+IpI2S5Tkff0KiG b8RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UUN6mlrt1JVfIdtNRt5aQaJHhuHU/mNoXeqpisyr50Q=; b=kVL2HzIlNdlG6PvysbXoPgT7y3OJNSnI9c1/3wV2dE/jFzHEYFAEY0D437zA3d0T9r L9emPHwvcn9cHlUSmVC0m+MY4uwqdbUElOutKli6fczkUmiJiRaCv1vYNPV/0tSLUm3a aFS7lkRdMRwgYve+MWaZKo8W/tZWcetWbfL36vo8wTrQT0RLkFsRA9uI2FgmCzSW1J+z CEw+cBzmXbWCNCV9e9vF2yI7bb5OSbf+JtNpDqqHQdxE/peNR4edHBhSilsyZMqtDhkG I2e2n/uTJQ90Kop6TElms/hAG/6wRF4YjMYgYP1QElLG56CzX/9vsQJhaFhQ7tk0/iey lN3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=kDmADc4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i36-20020a0564020f2400b00447d6f244c6si9895332eda.248.2022.11.14.10.35.35; Mon, 14 Nov 2022 10:35:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=kDmADc4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237939AbiKNSJX (ORCPT + 88 others); Mon, 14 Nov 2022 13:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238139AbiKNSJE (ORCPT ); Mon, 14 Nov 2022 13:09:04 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041D023E96; Mon, 14 Nov 2022 10:09:00 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DA2E1240006; Mon, 14 Nov 2022 18:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668449339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UUN6mlrt1JVfIdtNRt5aQaJHhuHU/mNoXeqpisyr50Q=; b=kDmADc4j0TZXhV/24fc3nz5YIr3zFsnsVNOoHs+tgaz6L7k5OA09O4qrq/lCvUANpILSl3 QZO8YE7J15KjXdZS4rA4it9thxwpgcs41FjqEmnWgTlg6YLWqCNWsAPuEjObQM6h5OL6zn IqxM0EPnbqiJmD72VaRqOF79IZfE29SwhfDk8z8goKPI80jmKGkLinja0mYIsf0CdD+bhV HcnVF20y5LLtB330DFPvJdtlReaG1XlrssRLoe7zuQpSPJkKBuNKNDREtnAO8fv117K1q1 rNnYJJ632gnOb6kSG7QviDTaRDKnJSt1zyy1u9769ahjYS5NEsPyg80bOyoZzg== Date: Mon, 14 Nov 2022 19:08:58 +0100 From: Alexandre Belloni To: Alessandro Zummo , Guenter Roeck Cc: linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev, Brian Norris , Benson Leung , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: cros-ec: Limit RTC alarm range if needed Message-ID: <166844930556.2096270.4852750255133310041.b4-ty@bootlin.com> References: <20221029005400.2712577-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029005400.2712577-1-linux@roeck-us.net> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Oct 2022 17:54:00 -0700, Guenter Roeck wrote: > RTC chips on some older Chromebooks can only handle alarms less than 24 > hours in the future. Attempts to set an alarm beyond that range fails. > The most severe impact of this limitation is that suspend requests fail > if alarmtimer_suspend() tries to set an alarm for more than 24 hours > in the future. > > Try to set the real-time alarm to just below 24 hours if setting it to > a larger value fails to work around the problem. While not perfect, it > is better than just failing the call. A similar workaround is already > implemented in the rtc-tps6586x driver. > > [...] Applied, thanks! [1/1] rtc: cros-ec: Limit RTC alarm range if needed commit: a78590c82c501c53b6f30a5ee10e4261e8b377f7 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com