Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Kevin Cernekee <cernekee@gmail.com>,
        "Nyman, Mathias" <mathias.nyman@intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use
Thread-Topic: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use
Thread-Index: AQHY+EVNLB0FKkvj5EatDeG8LWjtS64+uCEw
Date:   Mon, 14 Nov 2022 18:11:51 +0000
Message-ID: <DM5PR11MB1324523623D88188493D7518C1059@DM5PR11MB1324.namprd11.prod.outlook.com>
References: <20221114162207.62559-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20221114162207.62559-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3XMQzCPMbuXS92Svn/XZl0GoGyApJ4kWpXrHB7PZCyNevcfq89MlXTD+zWS9?=
 =?us-ascii?Q?W+/u7JsOLKtIPqV3IiB9+t53yfvSK4a/1P++OVx1tmS1IuG6P0EMtWpM80gt?=
 =?us-ascii?Q?EDpDGbKiwMBTX1x9ELMvFCSL/BlI5t/RGTxjsDXMgmpIY1DoS0ybVtuS+axf?=
 =?us-ascii?Q?SqF1n1CEBA+KWGxv5LC1AwQn2DEvGJRGHV1zGS81Bgvc69isnXHPGMp1QuOt?=
 =?us-ascii?Q?asZxXDOIMHQS7RzCFwqxd2IrLnGXJIe0A9uttR5QY09aca/p4y4oPrr0uXnu?=
 =?us-ascii?Q?/iQMl9BPVbMKOMEgo2zcU6CDN0w68VDdhCWYEKjBSjVjAdoDwSQQbzULSIK5?=
 =?us-ascii?Q?KVz+HsWu6s5HjOGm72EriIpP1DchqO0NrQtut7lZtJkRxWDS/f08r3oFeh9E?=
 =?us-ascii?Q?x31uPZWkDSRrYLlNuu/fN0f5IHhHhcwINoQsPlt8id9GvcMCP3jxpPM9xhWw?=
 =?us-ascii?Q?Py4u71XiRzrLuCGlYI0UpGukzgr4Nu3YT4vBBijSo3pREfJ/efkFuMGTeJqZ?=
 =?us-ascii?Q?1rLbzn0eUjpeD8T5+asR08HffcDsJ8MjVlF6B+QajmbjJhMzRXUPF03AUsA6?=
 =?us-ascii?Q?3dMbQA9dQjbVhOFjuYEy+uXAZPuWnsNPvbFzkXM/ytssNeQ2sC+QC0CY21JN?=
 =?us-ascii?Q?EGzuXFFVSb8S3OHXI1kgmEu3Inyv/GNoqrHq/0hTi07O0bOQ16bV03VfBO5Y?=
 =?us-ascii?Q?MD+bUWXrsKBEd6PIkEQHtBBnvUaYs+5T9xQ4rLWIlOaoGhPhOaPTdGIo6lWH?=
 =?us-ascii?Q?kMDe2VwR5HUmNMDvxaKH4x3qqaeZ+FqZz9DQx4Mbvhmo/x+lsKZOug93dVtG?=
 =?us-ascii?Q?shSTWcVt2++BIm45X5Y1QhZB2NpMb10aPTg2cuWi6yx6t1ZPFQpg5jIPPMyL?=
 =?us-ascii?Q?phZi5voEmIoudD+nsiZy65b3n4QlHTegDMLvgUOV2I4WQGEI2In9xCP201km?=
 =?us-ascii?Q?3aVhkCwfSbVhkmiZzRQeeU1zx6Sz5mTvE3/Ppq1Rz0tn04vPe3+NJvhNLtB6?=
 =?us-ascii?Q?ewyd2nJMUAaXqJPv3CzljO0ZGcUv7IrWFuyE/4Ws4cpgBjRdbNpc8JleqxBU?=
 =?us-ascii?Q?M7s1u3HJR6FQYQTGGYNzI8dPoupDPM5DsJXnVqgFo+p7PwC6Y+XwqHZvQknK?=
 =?us-ascii?Q?3rQN1WpM9W0PuoIg1JGuZ6o3/UwoFnCylMKQOkOH6H0MjXnH7NjKBwgnXL3+?=
 =?us-ascii?Q?FJqrCvwR+v1lztLYzbowEXrq3uw/3B8wVoHRbENxqtK+xGe19Fq/WxIWw6cf?=
 =?us-ascii?Q?9UvyAQu2uk46+YiVQjbzh5V6BVYRgk7xIML4tFReiP/RTHn3WSioMZo4Ql5t?=
 =?us-ascii?Q?8ECrYeRMHXJEY047VF8NlJTllyqVM6OawBfqfyXbn5n9T2i39QJWQ+1ish0+?=
 =?us-ascii?Q?rDtoPajkjEsTLicFgw9rs1tiEwUETkIi566bn+BGGjROYKXa99oZ33IdsR0U?=
 =?us-ascii?Q?U53ujahbEnCqd2eXBeBXhVXO+UvbUw67q6r1vYte3EafJ+eVFQlbCw9qe3tQ?=
 =?us-ascii?Q?k1KgXuff/h7MyRAnpjEyVfj6CD4e8z7/1/aeeHvIdId9m44CBoAgL1G9D5OI?=
 =?us-ascii?Q?vIDyAeNdWguXN3x96INfkOWW/weAj+hQNuY9XKi9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1324.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 544a6bd1-9bd3-441b-9ba7-08dac66bb41f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 18:11:51.1648
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hYVqunhhAGZtgbPn8Egey2jo0kqHmjseeBYvcEIbV4Y8GncFdu4jVR8kmf1GfMtTh+fxphJ1sEYpRG21JIMgnqbRpk3g6laL92179tBXKqQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5807
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Andy Shevchenko
>Sent: Monday, November 14, 2022 11:22 AM
>To: Jakob Koschel <jakobkoschel@gmail.com>; Andy Shevchenko
><andriy.shevchenko@linux.intel.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Mathias Nyman
><mathias.nyman@linux.intel.com>; intel-gfx@lists.freedesktop.org; dri-
>devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; linux-
>usb@vger.kernel.org
>Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Kevin Cernekee
><cernekee@gmail.com>; Nyman, Mathias <mathias.nyman@intel.com>; Vivi,
>Rodrigo <rodrigo.vivi@intel.com>; Andrew Morton <akpm@linux-
>foundation.org>
>Subject: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use
>
>Some of the existing users, and definitely will be new ones, want to
>count existing nodes in the list. Provide a generic API for that by
>moving code from i915 to list.h.
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>---
>v2: dropped the duplicate code in i915 (LKP)
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 13 +------------
> include/linux/list.h                      | 13 +++++++++++++
> 2 files changed, 14 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>index 6ae8b07cfaa1..b5d474be564d 100644
>--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>@@ -2085,17 +2085,6 @@ static void print_request_ring(struct drm_printer
>*m, struct i915_request *rq)
> 	}
> }
>
>-static unsigned long list_count(struct list_head *list)
>-{
>-	struct list_head *pos;
>-	unsigned long count =3D 0;
>-
>-	list_for_each(pos, list)
>-		count++;
>-
>-	return count;
>-}
>-
> static unsigned long read_ul(void *p, size_t x)
> {
> 	return *(unsigned long *)(p + x);
>@@ -2270,7 +2259,7 @@ void intel_engine_dump(struct intel_engine_cs
>*engine,
> 	spin_lock_irqsave(&engine->sched_engine->lock, flags);
> 	engine_dump_active_requests(engine, m);
>
>-	drm_printf(m, "\tOn hold?: %lu\n",
>+	drm_printf(m, "\tOn hold?: %zu\n",
> 		   list_count(&engine->sched_engine->hold));
> 	spin_unlock_irqrestore(&engine->sched_engine->lock, flags);
>
>diff --git a/include/linux/list.h b/include/linux/list.h
>index 61762054b4be..098eccf8c1b6 100644
>--- a/include/linux/list.h
>+++ b/include/linux/list.h
>@@ -655,6 +655,19 @@ static inline void list_splice_tail_init(struct list_=
head
>*list,
> 	     !list_is_head(pos, (head)); \
> 	     pos =3D n, n =3D pos->prev)
>
>+/**
>+ * list_count - count nodes in the list
>+ * @head:	the head for your list.
>+ */
>+#define list_count(head)		\
>+({					\
>+	struct list_head *__tmp;	\
>+	size_t __i =3D 0;			\
>+	list_for_each(__tmp, head)	\
>+		__i++;			\
>+	__i;				\
>+})

So all of the non-list_for_each code appears to be an inline.

This which, resembles the non-list_for_each pattern is a macro?

Just curious as to why the macro rather than inline?

Mike
+
> /**
>  * list_entry_is_head - test if the entry points to the head of the list
>  * @pos:	the type * to cursor
>--
>2.35.1