Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Prabhakar <prabhakar.csengg@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH] watchdog: rzg2l_wdt: Issue a reset before we put the PM
 clocks
Thread-Topic: [PATCH] watchdog: rzg2l_wdt: Issue a reset before we put the PM
 clocks
Thread-Index: AQHY+FQ3i7+8G/jXAEWaK/AAUJtKua4+wHcg
Date:   Mon, 14 Nov 2022 18:42:18 +0000
Message-ID: <OS0PR01MB5922DDCE24ED6F6DD44B4B3F86059@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20221114180843.1125308-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20221114180843.1125308-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ap5rfgmRKO/TKPtHSySdTas5cgA3YINaBLGUN5zB3gpnc09NqeYkgKk9U0Ga?=
 =?us-ascii?Q?Qf4BSiriwMkO94c/Ws3Rhrs+9sx3WFfGG1tazDBcLHtkEB29qnu6tqRVywO6?=
 =?us-ascii?Q?f7wVb9gHwMa7m89ag9A2LGly/D5XjpFlISkhHmalT6Y/c7/AdWTHIUhMsTxU?=
 =?us-ascii?Q?b+CZE6RcHZvVV5GHVn3AvsLrevQ60+GmZksYgzF5rg2TR/91JnsL4hwx3rDQ?=
 =?us-ascii?Q?TdWtGmIAYpnUEbyheghSVK2Fr5WfoDGM8OsN/rNrtiFMx/JGuwJhK4XZKJwF?=
 =?us-ascii?Q?BCjMEGD0h1YKZlWbZ6npoLfyGKdi+WS4Eh3Y+MeLD+871Msw+RRBNvfmM25+?=
 =?us-ascii?Q?mUyfebJcub81W9rogLtu/qx9jfWfcxHQFoCBYMv2G+IyjTupvDe2Tvmbd04u?=
 =?us-ascii?Q?Eikf2pr1UP5GMdTyWdx5pg6JkUoFrL4tU4dBiZguB4SQ/cba9mb+An6fukxf?=
 =?us-ascii?Q?y7yDYHwDkNoSbLwryYdFzQOdtK1qIUYrRFVqPHBDYcQq8JZ4HhRGo+0otrri?=
 =?us-ascii?Q?yLqa7CLONlNUghLf6V/PDRsYzK0AHqxLsBMi5AqdmIdu/fMbYjHPDUCqFPZr?=
 =?us-ascii?Q?MvBUzFmb2nEpMUK9NS55H/N8QlGLXnFgsss/Yoy+pCL86eI93bLq/LN0YEMO?=
 =?us-ascii?Q?1H0FCXsbApa8KL0ko5D6UTGOuNzoP0iBYCwQojGo0HVqOrD0xU4dhePbVnVT?=
 =?us-ascii?Q?r0Rjp3NiFaQ083Fe93Ez3diRUl3WMWb5CRtQZg5RHf6+lqwXyHfV5+Fr9sAb?=
 =?us-ascii?Q?xmSPlKJ6qDjQFZHvumxZkht9CTgrQRgYCG7Z5+CBNIKYfQsZDoLz8h1JkR6Y?=
 =?us-ascii?Q?qLKOl8mGMeQH2NjP/jS3bMiNRmO9Na162wE5d5HHcXrTZopZNgkIdu3MFr8R?=
 =?us-ascii?Q?sY0V6dFFsTKnaqiyBbaWyOzzrHv3twvgS4pccEcDkLpta8ZbZvk3cnKkCwIt?=
 =?us-ascii?Q?p8++cmvLkAQ27mbN+lA1xZtuuGC+BUxjirENjZ8upHWeIZfPVRySfZb2L5lM?=
 =?us-ascii?Q?cKEhYlnYVMWnhE+4AQJ+Ls45tI0rjLVo66VFJX73TzwU7UT862zqtEV/UWee?=
 =?us-ascii?Q?Ak40Vc6dVPLCdtXAOiFiRljBDlB8L/ih3QkpcS90WjYcoDlF7UXVv/49X5sf?=
 =?us-ascii?Q?DgoWer7BVUiSnWtIow8rlI1qE1vVRSjVIvroAapxIXz9oxoce4vmmZTywpEF?=
 =?us-ascii?Q?hnmyZtOB+xlfYyRu+rsyqszrF0+Y55lvhcFq/LNR3Ot5+ia7uVgdviYDsRCd?=
 =?us-ascii?Q?WjSAcrSgIMhEL0hm0foHKDwToDjp637U6Jp6aKgtI0J14RPgErEIWCTwxjiS?=
 =?us-ascii?Q?x5ex59EEK0Uef6Z5RlV9GUfMB4/DAeJghLHsJpSPksw7W4s+57HR9B6SHnfq?=
 =?us-ascii?Q?Gfp7gN54FPCMspJLrq/LPOGWOzx/LsMA0X/7d5zv+/FA4cpYvcTjmulRHIiK?=
 =?us-ascii?Q?SLnekNhVagA+91T6zk1WRQpdi925yH1kgYcHlwDfDF9Vce32WJkQh0bXe7UN?=
 =?us-ascii?Q?QMCi1RNTH3wro2s29UOmYEK5j5Seuv1oszVfwFxzcidSVauSiWS4RfElZ8ik?=
 =?us-ascii?Q?NAXC9UotLF9fNKP4KsNb1vkXdUceq9FHK+f7EQ/N1sgj/gvq3JOZIXpR95Wr?=
 =?us-ascii?Q?Zg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a44ddd-71b8-4cfc-2718-08dac66ff524
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 18:42:18.2178
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h9UAESrcU4QvocAMv1CSghNKH7GOufPGgUp8Jt993zPFMSbY++CiDaa03428G9YXRqNTCEcYVyNEvmBf539tDrExHKe7RLVG2L8RSucfsek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5466
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Prabhakar <prabhakar.csengg@gmail.com>
> Sent: 14 November 2022 18:09
> To: Geert Uytterhoeven <geert+renesas@glider.be>; Wim Van Sebroeck
> <wim@linux-watchdog.org>; Guenter Roeck <linux@roeck-us.net>; Philipp Zab=
el
> <p.zabel@pengutronix.de>; linux-watchdog@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> Prabhakar <prabhakar.csengg@gmail.com>; Biju Das
> <biju.das.jz@bp.renesas.com>; Fabrizio Castro
> <fabrizio.castro.jz@renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahade=
v-
> lad.rj@bp.renesas.com>
> Subject: [PATCH] watchdog: rzg2l_wdt: Issue a reset before we put the PM
> clocks
>=20
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>=20
> On RZ/Five SoC it was observed that setting timeout (to say 1 sec) wouldn=
't
> reset the system. To fix this we make sure we issue a reset before puttin=
g
> the PM clocks to make sure the registers have been cleared.
>=20
> While at it re-used rzg2l_wdt_stop() in rzg2l_wdt_set_timeout() as we wer=
e
> calling the same functions here.
>=20
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Note,
> - This patch has been tested on RZ/G2L, RZ/V2M and RZ/Five.
> - My initial investigation showed adding the delay after
> pm_runtime_get_sync()
>   also fixed this issue.
> - Do I need add the fixes tag ? what should be the operation PUT-
> >RESET/RESET->PUT?

It looks like timing issue, None of the previous devices are affected by th=
is.

>   in case we need the tag is:
>   Fixes: 4055ee81009e6 ("watchdog: rzg2l_wdt: Add set_timeout callback")
> ---
>  drivers/watchdog/rzg2l_wdt.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
> index 00438ceed17a..d1271cc7750f 100644
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -115,16 +115,14 @@ static int rzg2l_wdt_stop(struct watchdog_device *w=
dev)
> {
>  	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
>=20
> -	pm_runtime_put(wdev->parent);
>  	reset_control_reset(priv->rstc);
> +	pm_runtime_put(wdev->parent);
>=20
>  	return 0;
>  }
>=20
>  static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned =
int
> timeout)  {
> -	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
> -
>  	wdev->timeout =3D timeout;
>=20
>  	/*
> @@ -132,8 +130,7 @@ static int rzg2l_wdt_set_timeout(struct watchdog_devi=
ce
> *wdev, unsigned int time
>  	 * register so that it is updated with new timeout values.
>  	 */


Maybe update the comment above with new code change.

Cheers,
Biju

>  	if (watchdog_active(wdev)) {
> -		pm_runtime_put(wdev->parent);
> -		reset_control_reset(priv->rstc);
> +		rzg2l_wdt_stop(wdev);
>  		rzg2l_wdt_start(wdev);
>  	}
>=20
> --
> 2.25.1