Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     linux-kernel@vger.kernel.org, John Stultz <jstultz@google.com>
Subject: Re: [PATCH v1] timerqueue: use rb_entry_safe() in timerqueue_getnext()
In-Reply-To: <BNP2PqwI58CzAxJejDx9BcX2nWxSOo-hoZ1qh_7ZrmvqcNwz49RCBxZscYZCoHTlG7bqz2V12bhc5r88dPKopRgoy_XxO4QypcWoRFe3fMI=@protonmail.com>
References: <20221027212506.3745164-1-pobrn@protonmail.com>
 <87v8nis83n.ffs@tglx>
 <BNP2PqwI58CzAxJejDx9BcX2nWxSOo-hoZ1qh_7ZrmvqcNwz49RCBxZscYZCoHTlG7bqz2V12bhc5r88dPKopRgoy_XxO4QypcWoRFe3fMI=@protonmail.com>
Date:   Mon, 14 Nov 2022 20:16:24 +0100
Message-ID: <878rkds5x3.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 14 2022 at 15:54, Barnab=C3=A1s P=C5=91cze wrote:
> 2022. november 14., h=C3=A9tf=C5=91 1:17 keltez=C3=A9ssel, Thomas Gleixne=
r =C3=ADrta:
>> On Thu, Oct 27 2022 at 21:37, Barnab=C3=A1s P=C5=91cze wrote:
>
>   When `timerqueue_getnext()` is called on an empty timer queue, it will
>   use `rb_entry()` on a NULL pointer, which is invalid. Fix that by using
>   `rb_entry_safe()` which handles NULL pointers.
>=20=20=20
>   This has not caused any issues so far because the offset of the `rb_nod=
e`
>   member in `timerqueue_node` is 0, so `rb_entry()` is essentially a
>   no-op.

Yes. Very precise and informative.

>> Back then when that code got introduced rb_entry_safe() did not exist at
>> all so it's even more obvious that this is simply a missing NULL pointer
>> check, right?
>
> As far as I can tell it did exist and it was actually used
> when the offending change was committed (511885d7061e).

Hmm. I must have messed up when searching in the history.

Thanks,

        tglx