Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liron Himi <lironh@marvell.com>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next 1/9] octeon_ep: wait for firmware ready
Thread-Topic: [EXT] Re: [PATCH net-next 1/9] octeon_ep: wait for firmware
 ready
Thread-Index: AQHY8npGhIOpGkF3kEWfQ40PmZgxTK4zHjCAgAu+zqA=
Date:   Mon, 14 Nov 2022 20:47:42 +0000
Message-ID: <BYAPR18MB24237D62CF4947B889D84BDCCC059@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20221107072524.9485-1-vburru@marvell.com>
 <20221107072524.9485-2-vburru@marvell.com> <Y2i/bdCAgQa95du8@unreal>
In-Reply-To: <Y2i/bdCAgQa95du8@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5yKHWFBBrQCxbe8EjzK2K7PM7bGI3muJWj9IZQuFHYlOPFC5NNcaR8Sqw3J2?=
 =?us-ascii?Q?y+YYJnmM8XbCSnrGcqAsjmydX+2y6ymsbO672NyUnPbl5HVOfkAX/cXR3jv0?=
 =?us-ascii?Q?SLm33VPuNqq+LFg6mmEtKHn36pNoy1O+Mg+TfLCbovrVmqhsFB4rou9tC3t5?=
 =?us-ascii?Q?ZOo9ibqEEobNSElNLgBqQHJjjXnyJ/fiK7GtcBgKIOgDYT1/evZ4bcI7uOO8?=
 =?us-ascii?Q?hnpIsKVEgvSuZIe5juGWjwKrkOFHEgmLPV4dMwpup8j4WVWbS8+NGVMV55Sz?=
 =?us-ascii?Q?55ek4OYSzGnzQmkB0T1R9woLZmohmGAAbRjgu4WTXvyvusJwiItQLeLUWG75?=
 =?us-ascii?Q?MXIdnl4wpCTJTmeqroo3pSYAQLJ3kOFZc+r4K18u6NDQVN0w4mwCS1XAN8Oq?=
 =?us-ascii?Q?/KHNHgiUQ5ZszI3r604OyHBRvDYnyBKNt/+noQ26jdfSORzGCdMMyqudJHEN?=
 =?us-ascii?Q?GuPkPWnVBQx5z9bQABkWWbe8gZ1+1ThvMK588Y8zwtcWJsguK0iNAvQ08ef2?=
 =?us-ascii?Q?iaLqZyaRPcoM5rsoE7Rp/rgQaVldE2N9q5LC0CO6CKVuKcbtG67x6knFjfVT?=
 =?us-ascii?Q?wywDhdL2WSHv157COK78B6fBJ6LmSsPnG9LaN7D/ycGp9gZ+25EcjvqvwqUL?=
 =?us-ascii?Q?I7Mg/AW+ruu3B1+Bxx2MJ1xTEzPTsvaV5KPK0oM3Akp1fXpx0ZgXZ6zNspaB?=
 =?us-ascii?Q?EFOdVa1PmSkpo7z2gpxhMM2Sia2BXitXDxy5+7tqtaLvM0VYHqJ+2b0uCAmy?=
 =?us-ascii?Q?MXBI2hjOXqWTH1gEUgLCYggv3nF+Yh4phLk4I3sBv+fDtds1s865COdV5PF1?=
 =?us-ascii?Q?yv4orHRkNuQi+itJrpm2c+c8NolwuVGCKzj942PB8ZrHLYbBP4GXNO/SaomZ?=
 =?us-ascii?Q?V2bN4fLxoFJ7LovZaBlaXUiFylV+7U2YkqWN+vx6llbcQbdU21JUslDpsAMo?=
 =?us-ascii?Q?fe4vQW7FfdVtLj6VUk8HCl7G6pn1R0rlX1zNLL5MM55yYnbZZbZEFqeK4N1J?=
 =?us-ascii?Q?t76MXtFW3mgdOvkcIkuejBPD9v3umKPx03s4vnBZY7oenSh108JQGeK0ULCK?=
 =?us-ascii?Q?LMMaX+Q97tpTXm/Cl8cfcW2CUDliNvA9bO7c6mYYBLNsAx9VQazJTNx1byq0?=
 =?us-ascii?Q?6SmFR+m45esnKGeP4RFvwpIYW6O7MaUnusfeceoZ9edNFqwIB7rZo7wiGrAw?=
 =?us-ascii?Q?7CdCshEZloIQaW+Z8bLQB/TJMu2OUusSiSdpDZLi1+vdK6tYKpF5SMSJYDXk?=
 =?us-ascii?Q?SFdkttxj1Rix6IgkwLiFFg1x6K0p1coR+CzCYUBAknuKYwo2wfhB6HCAEk1l?=
 =?us-ascii?Q?Dv1aOjz1dj7h0jeBXtxpaQUJe+pJDHFsgNnx9V+uvP0vZb4YTrLZk8+ABehs?=
 =?us-ascii?Q?ucu2xFcSEiMZ0BaWdd+EoHaUjQYRXbou+4G3g7TX500C1eV66TSb57OZVpk3?=
 =?us-ascii?Q?V4t7inETcyamRvCTrtoo9V5TTOKVc+L6XICPC8hX9SXE6OF5j9bFR1fg1wZY?=
 =?us-ascii?Q?d2VPby36UF7gbtbP3ggTn44Ie9RCF5pcRpmfxndS7Fd/JnA4jyQRtc5GwKQb?=
 =?us-ascii?Q?aypknWiURbT8dbbNces=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4effde8e-05a9-4f85-8722-08dac6817a64
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 20:47:43.2523
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UhVPmlbp4OsjGQXMs8nyFikB5z7T1EcohU5L6NQLuSYUBMmyMZytjKjyDR0UY+v8ZLSZAe0l7nRH/jxvrikctA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4047
X-Proofpoint-GUID: ecBp8dQ9lL75OhLqvePm3ZEzJFkI9u4T
X-Proofpoint-ORIG-GUID: ecBp8dQ9lL75OhLqvePm3ZEzJFkI9u4T
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-14_13,2022-11-11_01,2022-06-22_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Monday, November 7, 2022 12:19 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Liron Himi
> <lironh@marvell.com>; Abhijit Ayarekar <aayarekar@marvell.com>; Sathesh
> B Edara <sedara@marvell.com>; Satananda Burla <sburla@marvell.com>;
> linux-doc@vger.kernel.org; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next 1/9] octeon_ep: wait for firmware read=
y
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Sun, Nov 06, 2022 at 11:25:15PM -0800, Veerasenareddy Burru wrote:
> > Make driver initialize the device only after firmware is ready
> >  - add async device setup routine.
> >  - poll firmware status register.
> >  - once firmware is ready, call async device setup routine.
>=20
> Please don't do it. It is extremely hard to do it right. The proposed cod=
e that
> has combination of atomics used as a locks together with absence of prope=
r
> locking from PCI and driver cores supports my claim.
>=20
> Thanks
Leon
          What is the alternate approach you suggest here ?  Are you sugges=
ting usage of deferred probe ? the driver initialization cannot proceed til=
l firmware ready is set by firmware.
Thanks