Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76570217-12b0-0501-53b6-45100c3effe1@amd.com>
Date:   Mon, 14 Nov 2022 16:29:19 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v4 9/9] Documentation: amd-pstate: add amd pstate driver
 mode introduction
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221110175847.3098728-1-Perry.Yuan@amd.com>
 <20221110175847.3098728-10-Perry.Yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221110175847.3098728-10-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzRBUkF5WTkwQTAxM3d3SjBzRlFIZ2pEVFFkRVQ2dHJGSmlPVWFUTjFoaE1I?=
 =?utf-8?B?QmJ2Z2F3R0Q3NmpocHJVM29XY0NVRENHbDdIdXVRdHM2UGZXNlFoN05iQzhI?=
 =?utf-8?B?VlhjUVVlaGxuZnZXR0ZpYjhLUmN6QUw5MmZ1emFLQWQwR1RlN21Jc0xNSHdo?=
 =?utf-8?B?WUs4NkZQOVBmVVRESEd6R0dyZm0vYUppNGo4M0V5Rlplcnk5cFVTL2VrMjVv?=
 =?utf-8?B?Y1kvNWFwd2o0cm1HTDJxN0h5OEVoYld6Nk5LaHNpNmVvMHhhVFl6SW0rWmNY?=
 =?utf-8?B?ZC9NSVgzekg4bGpaNVg1M0lFYzM0K2NyUTFnUDBpOWJUUHNkNmJka3BKeHpx?=
 =?utf-8?B?c20rTTU4VzNKZjhQU1haL21UbUh5YWh2cXBjeFp4RFE4RDRiNHhaeWFGNHRC?=
 =?utf-8?B?TitDcDVQSGFnSHVqL05GUDA5YUZNdnpxNE0rSUtXNHdBaUMwakliVnpvd1VL?=
 =?utf-8?B?TDR2NmIxZzZwWHhBb0Nmbzh5OWMweTdqeGp3Y09hVFA0eHJhYmw2YTVzYnZy?=
 =?utf-8?B?VEg1K0tlb1ZBVkVKMGEwY2ROUnpRcVNJWk4zZ3lMNHhBSXkzVDZxeVJGWGFN?=
 =?utf-8?B?ZGdKZlA3T1JrTFRtZG5UTzVBa3dtelVnSXBvRFFORUVGbThMT0RqSWo1UnhK?=
 =?utf-8?B?bklSQmFpMVhYNW1KRFJUcjFJeVgxVy9LUFBmbkRMN29KdklGTHpVRTk5OUQy?=
 =?utf-8?B?cXV2ZjVadnNyemg4MFE0VEh0NW5EWHRrSnZvb3B5ekdFdzZiQi9PZG5DS3hw?=
 =?utf-8?B?WmlzdjA2R0czbWJoOG43WThvZGdRMGdQM1ZidStPWE9raU9LR3ZvZEJzbUJI?=
 =?utf-8?B?N0s4cUYyajJrMjFweGpnSUJpUXpTMlBXNlRkY21TVkRId3RFbHpKazc3ZGdk?=
 =?utf-8?B?NnJ6YWg2N1pDOWVlcW9SYTNPRHdkcGhtaGsrNks1TVh3bEhYU1A3Y3ZSOEph?=
 =?utf-8?B?QklZYjZIUmtWU05oQzBBUHIvOG41dUFmbUtGYVJyUzdZeCtOVTNlVDNjYTlK?=
 =?utf-8?B?SVEyWnJIai9aSDh6S0NHaFAyOU1ucTVialRRRmc0N24vMGFnTEZESzhZREtG?=
 =?utf-8?B?c2dEeUk0QjMrNzN1bE1Nd2FJbTZEZ0FHK3pDeUZObVNzLy9LTERndWNNTk9t?=
 =?utf-8?B?NXp1bFhXS2dVcXpQVmFmMmRhNjVtcWZhK3BIcVhsbUM3WnZCZG9Ddko1cG0w?=
 =?utf-8?B?bHBhVlhCclNzYW9pTGxMSEdISTJYODhrQ0xKNHN3RTJCdk9IV2dGbmJVRk41?=
 =?utf-8?B?MENHRzZkMW9MdUovT1lmditoNWxKdFh5c3lESVZxR2x0L1JxMG5PTmwweVBZ?=
 =?utf-8?B?N1VLTXVDN2Y5MDJWVkV3ZEJNOXJlYlRUTXpzYXRmZ21VcVgweHkzbmdQTER3?=
 =?utf-8?B?MnZlYkljWld4QSsxLytZdEwzbURqNnY1ZFlKQlhucHhmQXFrd0NSQTR1VVRi?=
 =?utf-8?B?d3puVFhKNjBmZWRPd2RpdGpQazBVWFBYSi9RTkZGY1NBSjVLR0w1b3VsR2RG?=
 =?utf-8?B?MmcwbHpHM3NUTDBLQWdUQzZIQkdrNUV1VGNpcFQ1aW0yZ2haVGZFaFpOd0pQ?=
 =?utf-8?B?amRMZ0ZqdUpmVk43TnhFb0U3bTE4dTREcC9KRXFTVGhtclNrUUZ1MGU5cUc3?=
 =?utf-8?B?R29HYmNIS09nYUVMOVZzRnBWSmo2SzNmSmtSUkZIQUpzYk0wR0k3bThCai90?=
 =?utf-8?B?aitOa0MvbHk2NE8zcW5jb21peUZLUi9Gc2wxYzluYUZXQXFVa0JtUzVuNDJR?=
 =?utf-8?B?c0FaQ0R6aGJKalhIbWhPWENyRHM3blJQN0hMbVlwbW1YWWlPU1FNcXdUd3Bl?=
 =?utf-8?B?USt5KzJtZmpyWTB0T1R5NThHbUdYYm0xdVZ6K0Z5cDZEeFlMRFE4czNWdXJ0?=
 =?utf-8?B?bTMrbllzUTlSVThBQnJQTTFlSkpRZC9pcko2b1BsY0ZuTllWaXFHbkExTmoy?=
 =?utf-8?B?b0lYcWU4UXdDS2EyUXIyQlMxWTlENTZZSWlRbExtUHJmN0hEbFVXTk44QXI1?=
 =?utf-8?B?MVJuK3BDMU0zRk1YNW85Q2VpSVVlTkljcXRmREJtK0U4WDhpdzJWcC92eFI3?=
 =?utf-8?B?L21QODdZZHVWcnk3L2xGMC9EZWI3eEp2SjBac2RPQU1TeS85QStVMU4ya256?=
 =?utf-8?Q?HeVi7fMYeTAxkQjktVxaoym7S?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26524a71-a05c-4237-bb85-08dac68fade0
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 22:29:22.7561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 56Tmtegb4+90l9E+8khkCsZNd3YSQWYzYf+O5VQ4/zz8go6JadBEBST5uhOfK4RkRghuunk43i9g38ssthR+3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4954
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please run this through a spell checker before v5.

On 11/10/2022 11:58, Perry Yuan wrote:
> Introduce ``amd-pstate`` CPPC has two operation modes:
> * CPPC Autonomous (active) mode
> * CPPC non-autonomous (passive) mode.
> active mode and passive mode can be choosed by whith different kernel parameters.

can be chosen by different kernel parameters

> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 47 +++++++++++++++++++--
>   1 file changed, 43 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index e7488891b12f..6ba02a658b31 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -302,11 +302,11 @@ efficiency frequency management method on AMD processors.
>   Kernel Module Options for ``amd-pstate``
>   =========================================
>   
> -.. _shared_mem:
> +.. legacy_cppc:
>   
> -``shared_mem``
> -Use a module param (shared_mem) to enable related processors manually with
> -**amd_pstate.shared_mem=1**.
> +``legacy_cppc``
> +Use a module param (legacy_cppc) to enable related processors manually with
> +**amd_pstate=legacy_cppc**.
>   Due to the performance issue on the processors with `Shared Memory Support
>   <perf_cap_>`_, we disable it presently and will re-enable this by default
>   once we address performance issue with this solution.
> @@ -321,6 +321,45 @@ If the CPU flags have ``cppc``, then this processor supports `Full MSR Support
>   <perf_cap_>`_. Otherwise, it supports `Shared Memory Support <perf_cap_>`_.
>   
>   
> +AMD Pstae Driver Operation Modes

Pstate

> +=================================
> +
> +``amd-pstate`` CPPC has two operation modes: CPPC Autonomous(active) mode and
> +CPPC non-autonomous(passive) mode.
> +active mode and passive mode can be choosed by whith different kernel parameters.

can be chosen by different kernel parameters

> +When in Autonomous mode, CPPC ignores requests done in the Desired Performance
> +Target register and takes into account only the values set to the Minimum requested
> +performance, Maximum requested performance, and Energy Performance Preference
> +registers. When Autonomous is disabled, it only considers the Desired Performance Target.
> +
> +Active Mode
> +------------
> +
> +``amd-pstate-epp``
> +
> +This is the low-level firmware control mode which is implemented by ``amd-pstate-epp``
> +driver with ``amd-pstate=active`` passed to the kernel in the command line.
> +In this mode, ``amd-pstate-epp`` driver provides a hint to the hardware if software
> +wants to bias toward performance (0x0) or energy efficiency (0xff) to the CPPC firmware.
> +then CPPC power algorithm will calculate the runtime workload and adjust the realtime
> +cores frequency according to the power supply and thermal, core voltage and some other
> +hardware conditions.
> +
> +Passive Mode
> +------------
> +
> +``amd-pstate``
> +
> +It will be enabled if the ``amd_pstate=passive`` is passed to the kernel in the command line.
> +In this mode, ``amd-pstate``driver software specifies a desired QoS target in the CPPC
> +performance scale as a relative number. This can be expressed as percentage of nominal
> +performance (infrastructure max). Below the nominal sustained performance level,
> +desired performance expresses the average performance level of the processor subject
> +to the Performance Reduction Tolerance register. Above the nominal performance level,
> +processor must provide at least nominal performance requested and go higher if current
> +operating conditions allow.
> +
> +
>   ``cpupower`` tool support for ``amd-pstate``
>   ===============================================
>