Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6239857rwb; Mon, 14 Nov 2022 17:00:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Woj3BsR2W6jeT+JVcf4TOITl8B2IfG4MGxv8wIhQdIdZJciQyK952WOXGnxTXlm88+FuN X-Received: by 2002:a17:90a:5506:b0:212:e5ad:cd3a with SMTP id b6-20020a17090a550600b00212e5adcd3amr15951519pji.122.1668474017712; Mon, 14 Nov 2022 17:00:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668474017; cv=none; d=google.com; s=arc-20160816; b=RPekqNxwsG9SBVSF/79Tt2vryYsU95SmiMriGp4sSDLv0AJeB88Lp8WyxjCrBqQ481 Bq3mf5u7GzZrBPuXHJTYCjCx/Gh1ACK5UCoPDAHZB0ijy17qmJPynlwG1sPSc5AG0wGg B0N51lAlGpC6/iJ2uCDQja1lKvqZl5FBYHfmOdwhtqP0Ky/qjbyBMy74Yca2ebgWN98P QRgGYsl9bqw4jMf0WUYpIh/9479RHfirPAzw4z2M+oXH18YNN6csKyxLXFuFf10yEFRy xbVJXYXdkhxoEwynM+Gqpl0PLzfmysKRlT3f8tnGr2UTG9OlvYDJE7BrSPpFG07e+Xdz 7oJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=U9WtyFjfUCr3EXsv59jM0Uq8xTAz5w+9nR4N7uzysOg=; b=H42zcB43ySCYwu3HMEzkN6JliyFUG7+Baqecfu9TfI8rwtD76fezasd8OFUa2LpWFz 7H9aN1sSb2+J6FqzBP/UYd2A+CQuhAjniJtKcuRQ2op8kzNnHhxqTP4KHwXnJoe/gspU 7E3VZxaujUltX3uF64naUjR25oRdO42A1YLlBsOrHC2jPH21VWBlL/2ZMZZp2RQJpxDB C0uBz38zFhpCmUEljLqAwcdloCb7NcEDnTGtgCE3a6gZ7ek9j1ENnOXvCmTwzjhdPgJ6 IdlCv4XaN37UMdyDFdDdYEW0FIRDvH8CsbocJ/gnTlOHVYw3mernt9ZzQjaVrJ5HbNqY MbVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020a63d910000000b004349119ea7bsi10864150pgg.401.2022.11.14.17.00.06; Mon, 14 Nov 2022 17:00:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbiKOAkF (ORCPT + 89 others); Mon, 14 Nov 2022 19:40:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbiKOAkC (ORCPT ); Mon, 14 Nov 2022 19:40:02 -0500 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63411AD95; Mon, 14 Nov 2022 16:40:01 -0800 (PST) Received: by mail-pg1-f171.google.com with SMTP id q1so11765748pgl.11; Mon, 14 Nov 2022 16:40:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U9WtyFjfUCr3EXsv59jM0Uq8xTAz5w+9nR4N7uzysOg=; b=vn4cdZ7U8kBsNsO+Pi5HfO9LqYqEQvW4eUbb6TkNnfFTLapA16EYNcFXZ10xJFh2HG JSnt6QJztDJ0A/bITWpVx//JXR//kFXBTuXHZ0Ffe7g+wFUAXlu7lbq3Nwyn0wZTJySI lmvjV2zw1fFljLJsj53qD9mnxhBgfdOAYQxqm0nJJurvbk0PCs5GSgRrMtXvosywCPkx 6lGc/95fncfrGTXSBsF/HnpjCND9cGJpL1wKGLBgfVHQ4Cghn45fpKug/yaLtgLfiFNg EM87LpIjNY5V1BA+f8q+xaFK1AExqw/FRJtB0995En+BqkPubgp+RLoybd+cbuLcGxFv wz2Q== X-Gm-Message-State: ANoB5pkbe1Iy/KR/CuUFATFa/CXazbbxlPdOgmtA0vTHucQzGUNWakk/ HHpZXoviAoZYA1+sMOAWq+xrJzs/sXo= X-Received: by 2002:aa7:9902:0:b0:56e:8ed7:569f with SMTP id z2-20020aa79902000000b0056e8ed7569fmr16006453pff.19.1668472800948; Mon, 14 Nov 2022 16:40:00 -0800 (PST) Received: from ?IPV6:2620:15c:211:201:637b:9535:5168:c84f? ([2620:15c:211:201:637b:9535:5168:c84f]) by smtp.gmail.com with ESMTPSA id f15-20020a62380f000000b0056c360af4e3sm7326858pfa.9.2022.11.14.16.39.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 16:40:00 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 16:39:58 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V2 3/7] null_blk: initialize cmd->bio in __alloc_cmd() Content-Language: en-US To: Chaitanya Kulkarni , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, damien.lemoal@opensource.wdc.com, johannes.thumshirn@wdc.com, ming.lei@redhat.com, shinichiro.kawasaki@wdc.com, vincent.fu@samsung.com, yukuai3@huawei.com References: <20221006031829.37741-1-kch@nvidia.com> <20221006031829.37741-4-kch@nvidia.com> From: Bart Van Assche In-Reply-To: <20221006031829.37741-4-kch@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/22 20:18, Chaitanya Kulkarni wrote: > The function __alloc_cmd() is responsible to allocate tag and > initializae the different members of the null_cmd structure e.g. initializae -> initialize? > cmd->tag, cmd->error, and cmd->nq, Move only member bio that is initialized > from alloc_cmd() into __alloc_cmd(). Thanks, Bart.