Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6273251rwb; Mon, 14 Nov 2022 17:31:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ciZf/BWGqBvL22HLo1GA61K1hxA2KbZPk3LPy5bfTPhR7Z/HWlIQwrmZbUsD4/t1gd95P X-Received: by 2002:aa7:d553:0:b0:458:f012:bacb with SMTP id u19-20020aa7d553000000b00458f012bacbmr13261547edr.345.1668475886031; Mon, 14 Nov 2022 17:31:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668475886; cv=none; d=google.com; s=arc-20160816; b=Mf/MdnSfaFpOkY36RaOrRZgRi1OuJtL7s65vUlmzT8bkr+kk4dbtZ4YBucesejMAUS VhtZTb6q2lvIJ2RHOGeI0Re6sy0ICscG2fEmXIIK49/TOTkqOIW3Dc8DrhVgQ1jcwyr5 Ak97IKP0RNQaydRkdyHti/1R07PsEeWAZYOwkGKkvj8755pZ0LVS+rwj7Ga0SehQDhEY xLenNqY7+Jgxj3qtHuMI/fqZYlyN1ISliexZRnvJJi28k5/9Ga/PhKu0XbG4yj1jdcEi QpF+zsXx9xyriou2nTt2UswY38flLtz6iaIlvJLL2sk7j4kWU3L+xmDvFVAZM+bW0s4w rGYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hB5Kxtwkzy2WQ2B6FnTtD5MnijvpxL0Nr18t1+rbyuI=; b=Jy66vHHiezPnC8jAt3K8ujiw93NAPUfLP6cITBDlHXIfbiPD0lKuqFwC2J/8BlWtsO PJ7dD2aDYxNXpRJkg2NAP3wFetHxAccvKsjsX5+OT2bEfbG8/NDzEYit4Vw8g4kkfBCI ZYVWxZJfn4fW+fo1I1oXQUeMGQcvJIuzGYdO+q0eSR7Q3lsPmeEpnJwFZpgg4E4HYJxQ +TVFr7eHzepKa0OTEOI74dZHk1w9DhT8cpg9Q82r0vGRHc79gkpYR7WkxOyzx2K2ew39 kiJa9XOMgbv9HcNed21oDF3VnBRkcDR2gz/dPKxIy5JFKqYYnwsU7ORBTj0fzh8MXNwI NMbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=X0BAYPLG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 27-20020a50875b000000b0046270f01409si10730467edv.40.2022.11.14.17.30.59; Mon, 14 Nov 2022 17:31:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=X0BAYPLG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbiKOBPj (ORCPT + 88 others); Mon, 14 Nov 2022 20:15:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231774AbiKOBPZ (ORCPT ); Mon, 14 Nov 2022 20:15:25 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 550CF140B4; Mon, 14 Nov 2022 17:15:24 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id o7so11943733pjj.1; Mon, 14 Nov 2022 17:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hB5Kxtwkzy2WQ2B6FnTtD5MnijvpxL0Nr18t1+rbyuI=; b=X0BAYPLGZC6QLMCHKDZ+9jlyLGC2tKlNDJ2qkNuliDg+2TxYVO7lkUn78qE4ptrp0r oH0qWTB4bTXzPCNpVBKIEf8QM4VarlNLG4+nR0x24UtjMljvEtIdHUzirNv/ul1cIR3b mLm8CXetvxB7ABJ0VRqmPpA/EPnjYsB+iRNTh2066ETdCj9ndsg8msUwf+g34+49WSiv 4Xh3U8yYDDqVmbKkf2Pj2std0A98eCfVcJG5OPhe6OueEl5y47IuSVea1seetuGG6NHi kKBXE2qiHcVRa1GiNcEiIjbko11rv8f57Rp44upjlEcNFlW9OfDbvNyGrxk6/WI35+XR Tezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hB5Kxtwkzy2WQ2B6FnTtD5MnijvpxL0Nr18t1+rbyuI=; b=PD6hs/Qa7yvmWBDLk+HUrYApFbyE/GhE0Qr5gUF2x+oehDKEgBURFkcgT2NmHCfgq6 8bH+Knv3vFVng9ugGylWubjiuVNdJwJfot/akEzVYbTnF3ARhvkiZMgp7xmegWUngMDp 3LLwLT43x4L1lFbpMaWg4iUl3XVddm3tbDWwLVxYV4gQdGOgQEger0Iwbp75ehht6iZT X2BpD2tDxu8pHOcNrFwG5o8o3kFMF6P2nJzuT3C/ipEXJ0BVtNlMCQAxdkyodhgDbaEP qj6ebm9RLk5Vw0oW4RhyNsJi2O5JIZfpC/wzc+vfS/ztjG+TMrfqnBuJX+vr8LDBBoA2 ff+w== X-Gm-Message-State: ANoB5pmipA0qctGyw5kO3MVKCLDtvBunasxmzK8SWU6fLjagOL16Sk/Q 8WcvK+dKkg+vNphFlKsQGX8= X-Received: by 2002:a17:902:f790:b0:186:6180:fb89 with SMTP id q16-20020a170902f79000b001866180fb89mr1632383pln.142.1668474923457; Mon, 14 Nov 2022 17:15:23 -0800 (PST) Received: from google.com ([2620:15c:9d:2:718:95ee:2678:497]) by smtp.gmail.com with ESMTPSA id t6-20020a170902e84600b001785fa792f4sm8280725plg.243.2022.11.14.17.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 17:15:22 -0800 (PST) Date: Mon, 14 Nov 2022 17:15:19 -0800 From: Dmitry Torokhov To: Vincent Knecht Cc: Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, w.david0@protonmail.com, stephan@gerhold.net, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v4 3/5] Input: msg2638 - Add support for msg2138 Message-ID: References: <20221110171952.34207-1-vincent.knecht@mailoo.org> <20221110171952.34207-4-vincent.knecht@mailoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110171952.34207-4-vincent.knecht@mailoo.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 06:19:46PM +0100, Vincent Knecht wrote: > msg2138 only supports 2 fingers presses, and needs different processing > since second finger press is encoded as a delta position wrt. first one > and the packet/touch_event structs are not the same as msg2638. > > Add support for it by implementing distinct structs and irq handler. > > Signed-off-by: Vincent Knecht Applied, thank you. -- Dmitry