Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937232AbXHHRgg (ORCPT ); Wed, 8 Aug 2007 13:36:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965120AbXHHRgA (ORCPT ); Wed, 8 Aug 2007 13:36:00 -0400 Received: from smtp.nokia.com ([131.228.20.172]:34315 "EHLO mgw-ext13.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762945AbXHHRf6 convert rfc822-to-8bit (ORCPT ); Wed, 8 Aug 2007 13:35:58 -0400 Subject: Re: [Patch 05/18] fs/logfs/dir.c From: Artem Bityutskiy Reply-To: dedekind@infradead.org To: =?ISO-8859-1?Q?J=F6rn?= Engel Cc: akpm@osdl.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Thomas Gleixner , David Woodhouse In-Reply-To: <20070808171554.GV15319@lazybastard.org> References: <20070808161234.GB15319@lazybastard.org> <20070808161626.GG15319@lazybastard.org> <1186592854.19606.49.camel@sauron> <20070808171554.GV15319@lazybastard.org> Content-Type: text/plain; charset=utf-8 Date: Wed, 08 Aug 2007 20:34:34 +0300 Message-Id: <1186594474.19606.52.camel@sauron> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 (2.10.2-2.fc7) Content-Transfer-Encoding: 8BIT X-OriginalArrivalTime: 08 Aug 2007 17:34:34.0609 (UTC) FILETIME=[62C25E10:01C7D9E2] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1153 Lines: 33 On Wed, 2007-08-08 at 19:15 +0200, Jörn Engel wrote: > On Wed, 8 August 2007 20:07:34 +0300, Artem Bityutskiy wrote: > > On Wed, 2007-08-08 at 18:16 +0200, Jörn Engel wrote: > > > +static inline void logfs_inc_count(struct inode *inode) > > > +{ > > > + inode->i_nlink++; > > > + mark_inode_dirty_sync(inode); > > > +} > > > + > > > +static inline void logfs_dec_count(struct inode *inode) > > > +{ > > > + inode->i_nlink--; > > > + mark_inode_dirty_sync(inode); > > > +} > > include/linux/fs.h: inode_inc_link_count() inode_dec_link_count() do > > this. Although not sure they exist in the old kernel your patches are > > against. > > Almost, they call mark_inode_dirty() instead of mark_inode_dirty_sync(). > I wonder if that's necessary. > Ah, right, it is necessary as long as you do not have write-back implemented, sure. Pardon :-) -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/