Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6395519rwb; Mon, 14 Nov 2022 20:04:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf6TaW8Qariq24IYTDmit8HXgvuRzw095ERV0btjvDXFxS6zTCaeqRmbvEvttjvhsFB96Gcl X-Received: by 2002:a63:5745:0:b0:470:250f:e7e9 with SMTP id h5-20020a635745000000b00470250fe7e9mr14739282pgm.112.1668485044320; Mon, 14 Nov 2022 20:04:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668485044; cv=none; d=google.com; s=arc-20160816; b=JENZzVoK4S31w1K/C3r6R+OmQ0C1Znz9D04bfc1cOLK8aqD0/X9dnv6ciZAOtVloSH 4zw+TJ34tCiYKLKYRD+Exxle8bRCE2rsGCH1Sv1id6/3Xrl7gCPrzDQt/Y9lBF+RNvNi Nqc5H2t4bh4C2xQbr73yhoKWbJqY5QN8ZXhZZi+xbHBzdLjyvqfZwWSw3bxiu0p/YqPX l3spR2E/criMfrn90SGpmgW2FTA2wjDd2yqk/0tcOl0EPFqGKzAH83ZDCPnEPyBdgHKu 1+8gQVDjFVQehnkW5uuvsoh9d7HOKJEbZFb7sprgm4OZjgXMmew0tmOGQmSqx0a9BzBG Trrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=1toJ6maaSUZFFMSZwWMbHkXqP3roPhchwfv90NsBhds=; b=x/JnWLjMl3S6g54BjjNTgkoS9xHXuv1dJgp+GDRip8lOpjdhit5wqXM9FxPoDW35wP CHyCQa3kBBTc0F14zBalrkFv9CIgV4cLfQGY/vVYXRwjfT0TEOPeUtqC37cmkBnp4dCq xuZUWtwp/4Ts6qS6wZPfxf8ey5BRwJfsL+sC89lctpHdccvui8PvaQQ/f06cwxrbJZaK gtMXQFPw9j8nG7fmxufF2aLMLDUT7hWDfMyAYD8yPB02s8lvtZHu/E5oJY50Y0FlHevw A7m5cLggM1flqJZFgfCybZbQg+zJbvrCHaBZE+Y0BfbBpPI8lA7c9rm+9G7X+yFl6HnT BAkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e12-20020a056a001a8c00b0056c2e395593si11879395pfv.167.2022.11.14.20.03.52; Mon, 14 Nov 2022 20:04:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232445AbiKODDb convert rfc822-to-8bit (ORCPT + 88 others); Mon, 14 Nov 2022 22:03:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237795AbiKODCs (ORCPT ); Mon, 14 Nov 2022 22:02:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F234DF50 for ; Mon, 14 Nov 2022 19:01:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8BCF061520 for ; Tue, 15 Nov 2022 03:01:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09166C433C1; Tue, 15 Nov 2022 03:01:34 +0000 (UTC) Date: Mon, 14 Nov 2022 22:02:16 -0500 From: Steven Rostedt To: Jianlin Lv Cc: alison.schofield@intel.com, davidgow@google.com, thunder.leizhen@huawei.com, jianlv@ebay.com, linux-kernel@vger.kernel.org, Masami Hiramatsu Subject: Re: [PATCH] tracepoint: Allow livepatch module add trace event Message-ID: <20221114220216.05dd0541@gandalf.local.home> In-Reply-To: References: <20221102160236.11696-1-iecedge@gmail.com> <20221114122255.72588f45@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2022 10:38:34 +0800 Jianlin Lv wrote: > On Tue, Nov 15, 2022 at 1:22 AM Steven Rostedt wrote: > > > > On Wed, 2 Nov 2022 16:02:36 +0000 > > Jianlin Lv wrote: > > > > > In the case of keeping the system running, the preferred method for > > > tracing the kernel is dynamic tracing (kprobe), but the drawback of > > > this method is that events are lost, especially when tracing packages > > > in the network stack. > > > > I'm not against this change, but the above is where I'm a bit confused. How > > are events more likely to be lost with kprobes over a static event? > > We have encountered a case of kprobes missing event, detailed > information can refer to the following link: > https://github.com/iovisor/bcc/issues/4198 > > Replacing kprobe with ’bpf + raw tracepoint‘, no missing events occur. > Masami, What's the reason that kprobes are not re-entrant when using ftrace? -- Steve