Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 19:47:16 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary
 exposure of stats structures
Message-ID: <Y3MLxNIQBiZKmtNs@euler>
References: <20221111204924.1442282-1-colin.foster@in-advantage.com>
 <20221111204924.1442282-3-colin.foster@in-advantage.com>
 <20221114151925.p35ynwi7ejmr6zhc@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221114151925.p35ynwi7ejmr6zhc@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kiYIwxF8OIoHazMCj4jVU5+1EArRr4ciDhIwbKLR8KoXMnwcoK2LghdPw2AM?=
 =?us-ascii?Q?5dTuldhCzKfU8DVuN9HSk5o6NgJQ+pRXJdDZIuDyIWf/79Oc/O9+/POhTi7Z?=
 =?us-ascii?Q?OHJ+AYqn9c02SjUtCKOr2LWejHcrcQN6RR58bSUz7l2+0cuTZMV34lXEFPqH?=
 =?us-ascii?Q?zMnzevAFJh/hF/C8f84ZJV8D5RbrWr1AxhPUlddkKA8G1sorDaNvgsMcd2lY?=
 =?us-ascii?Q?poh7TOJEY814e9bhTUHmvBhMH6WbTSYdIKVG6xPQKob0nwnRpqEbcH/CxQe5?=
 =?us-ascii?Q?OBoXIaNtMegpR8EywIGGFA6uxBJWneJCrIM9pYHPbF0bL5bRVvEGbymlRdTV?=
 =?us-ascii?Q?jB/rD/5J2bzMOiEoNS9+yqlGOxLOUzcphBSd32gTRpMcGEFPPF4Re0QqJfZ2?=
 =?us-ascii?Q?Er7JvjadJJJNSlVi7vrDborFXV7Xd31vyqKJdZpZXr31HJBbn2a7XWJL1/u+?=
 =?us-ascii?Q?8SnCjHPvif6JPd5CLpzupL1Cv4hBZkUPiHH6Tn08OWWOZe7PaNEZqknPgdfn?=
 =?us-ascii?Q?q9HpU4cnopC2nMf92tuv0s6UXE++yVsP38F5nowpBs3VRnKgJEfBggL3FKgs?=
 =?us-ascii?Q?MHbfNKavdQ3etPiNzbZogp8Hr2Hc0WlT46uFmur/Yh6LxMBx4Ce4rprt8I4a?=
 =?us-ascii?Q?sf9POGA648yTPHWt4l+u5Wu1DYBuk6fKehlO65khLvJeNj6oWPB9q+p1OjVM?=
 =?us-ascii?Q?+jJKML/4ln6/KM/sAIeKqBLTaAVdDdvnLCkU+iP3fw4saBGG5dGXDdTmHQ9c?=
 =?us-ascii?Q?9+IsZ1f+qN6nYokJ5NIFhM1+6ZBtLibVgxe1vzKiKWUWS9Gui7HwJhFv1vFm?=
 =?us-ascii?Q?j2H5zQEyz4uldzzLJHeTv6njBmcgQAF6/3DBhU5D9Zd4nPV/K7znTG0A1GwF?=
 =?us-ascii?Q?CEmQqZW/ydfTCKEMj9ypUhASOQPeWjeBGzfm7PGSyIZG9kQNbzNJYIuTxq9A?=
 =?us-ascii?Q?CaqpcKoFmxZ2Ra7RrdViCWUAwkTSFvFPIZu66TYw0kt3NCpwgC7tYLe88ivW?=
 =?us-ascii?Q?V9SiybrOlWioew2gDabfZBOIVQCJjZvm4h3rgqHS52OGoFds6dCEHZ4fnpGJ?=
 =?us-ascii?Q?H/MBgd18YkrE9VAQY0ea3+xbTseVFM9G0ayXprvsXD/Xau9zK5sX3xIJXle5?=
 =?us-ascii?Q?5wSuFavuHE4oB+iT0Jp0aAmKF10bTeI6JmU/mYAp39oAilX/RZU3cvPmV/3b?=
 =?us-ascii?Q?DMjaCSMFb/oM5vDqDdEwra0CvN6T+xsOMUdHGIniMG1n1yF3qH5/I8zDx+j7?=
 =?us-ascii?Q?pvB3jo2AYzG6sKlTEKwh43dXcb3yWZHsbgDp29wwBjU/V9tp6asbQHYruWG6?=
 =?us-ascii?Q?Nlydy5g39MIAtDCrkPL+P5cfbsQsANe+AEkadgk9S7WtLM2mdQcJH6zv8HJd?=
 =?us-ascii?Q?vqMaiumbuwvI7F9erI19kCVFIh+zQ58UPCkh4kSOF5e3NNUEmPHDTES70Mr7?=
 =?us-ascii?Q?O0Jp9QzHpKQ/QqEhCsAKOpS/HLUdKHHh9/hGjzmY/xRTIKgtyM1sG1BeGvjd?=
 =?us-ascii?Q?4p131ods1PufAuH2LLDIACGbKagJvW5J0yKKBN4t0W5SoCm8YxzkujK+LbBW?=
 =?us-ascii?Q?WzJoC4HT3kvU/D2h+8QFnyy6q3jyUCZDrmL3rMzAa+xMhlSr9TAoEICgMwBo?=
 =?us-ascii?Q?Sw=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c50cc3e7-e2c2-4f85-9f31-08dac6bc1881
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 03:47:19.5520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KDH6PsEEXFUvimdlPKAf3CUQkraz6Pra6qF5Iw7HLCqq8pNCwkHGT8CnZ6ZPYM9j6LoBhbRBc+PDv8LdERZZci2Zde7Qcrmko+pftgXrMWk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5549
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 14, 2022 at 03:19:26PM +0000, Vladimir Oltean wrote:
> On Fri, Nov 11, 2022 at 12:49:24PM -0800, Colin Foster wrote:
> > +#define OCELOT_COMMON_STATS \
> > +	OCELOT_STAT_ETHTOOL(RX_OCTETS, "rx_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_UNICAST, "rx_unicast"), \
> > +	OCELOT_STAT_ETHTOOL(RX_MULTICAST, "rx_multicast"), \
> > +	OCELOT_STAT_ETHTOOL(RX_BROADCAST, "rx_broadcast"), \
> > +	OCELOT_STAT_ETHTOOL(RX_SHORTS, "rx_shorts"), \
> > +	OCELOT_STAT_ETHTOOL(RX_FRAGMENTS, "rx_fragments"), \
> > +	OCELOT_STAT_ETHTOOL(RX_JABBERS, "rx_jabbers"), \
> > +	OCELOT_STAT_ETHTOOL(RX_CRC_ALIGN_ERRS, "rx_crc_align_errs"), \
> > +	OCELOT_STAT_ETHTOOL(RX_SYM_ERRS, "rx_sym_errs"), \
> > +	OCELOT_STAT_ETHTOOL(RX_64, "rx_frames_below_65_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_65_127, "rx_frames_65_to_127_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_128_255, "rx_frames_128_to_255_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_256_511, "rx_frames_256_to_511_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_512_1023, "rx_frames_512_to_1023_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_1024_1526, "rx_frames_1024_to_1526_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_1527_MAX, "rx_frames_over_1526_octets"), \
> > +	OCELOT_STAT_ETHTOOL(RX_PAUSE, "rx_pause"), \
> > +	OCELOT_STAT_ETHTOOL(RX_CONTROL, "rx_control"), \
> > +	OCELOT_STAT_ETHTOOL(RX_LONGS, "rx_longs"), \
> > +	OCELOT_STAT_ETHTOOL(RX_CLASSIFIED_DROPS, "rx_classified_drops"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_0, "rx_red_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_1, "rx_red_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_2, "rx_red_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_3, "rx_red_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_4, "rx_red_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_5, "rx_red_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_6, "rx_red_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(RX_RED_PRIO_7, "rx_red_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_0, "rx_yellow_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_1, "rx_yellow_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_2, "rx_yellow_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_3, "rx_yellow_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_4, "rx_yellow_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_5, "rx_yellow_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_6, "rx_yellow_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(RX_YELLOW_PRIO_7, "rx_yellow_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_0, "rx_green_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_1, "rx_green_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_2, "rx_green_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_3, "rx_green_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_4, "rx_green_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_5, "rx_green_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_6, "rx_green_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(RX_GREEN_PRIO_7, "rx_green_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(TX_OCTETS, "tx_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_UNICAST, "tx_unicast"), \
> > +	OCELOT_STAT_ETHTOOL(TX_MULTICAST, "tx_multicast"), \
> > +	OCELOT_STAT_ETHTOOL(TX_BROADCAST, "tx_broadcast"), \
> > +	OCELOT_STAT_ETHTOOL(TX_COLLISION, "tx_collision"), \
> > +	OCELOT_STAT_ETHTOOL(TX_DROPS, "tx_drops"), \
> > +	OCELOT_STAT_ETHTOOL(TX_PAUSE, "tx_pause"), \
> > +	OCELOT_STAT_ETHTOOL(TX_64, "tx_frames_below_65_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_65_127, "tx_frames_65_to_127_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_128_255, "tx_frames_128_255_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_256_511, "tx_frames_256_511_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_512_1023, "tx_frames_512_1023_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_1024_1526, "tx_frames_1024_1526_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_1527_MAX, "tx_frames_over_1526_octets"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_0, "tx_yellow_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_1, "tx_yellow_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_2, "tx_yellow_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_3, "tx_yellow_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_4, "tx_yellow_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_5, "tx_yellow_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_6, "tx_yellow_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(TX_YELLOW_PRIO_7, "tx_yellow_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_0, "tx_green_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_1, "tx_green_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_2, "tx_green_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_3, "tx_green_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_4, "tx_green_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_5, "tx_green_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_6, "tx_green_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(TX_GREEN_PRIO_7, "tx_green_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(TX_AGED, "tx_aged"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_LOCAL, "drop_local"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_TAIL, "drop_tail"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_0, "drop_yellow_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_1, "drop_yellow_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_2, "drop_yellow_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_3, "drop_yellow_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_4, "drop_yellow_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_5, "drop_yellow_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_6, "drop_yellow_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_YELLOW_PRIO_7, "drop_yellow_prio_7"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_0, "drop_green_prio_0"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_1, "drop_green_prio_1"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_2, "drop_green_prio_2"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_3, "drop_green_prio_3"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_4, "drop_green_prio_4"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_5, "drop_green_prio_5"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_6, "drop_green_prio_6"), \
> > +	OCELOT_STAT_ETHTOOL(DROP_GREEN_PRIO_7, "drop_green_prio_7")
> 
> If we're moving these anyway, and stopping providing anything *but*
> common stats, we could as well move them to ocelot_stats_layout and
> delete the OCELOT_COMMON_STATS macro?

I noticed that as well. Depending on which way is best (if the v2 patch
looks anything like this patch), I'll remove this macro.