Date: Wed, 8 Aug 2007 14:00:56 -0400
From: Dave Jones <davej@redhat.com>
To: jschopp <jschopp@austin.ibm.com>
Cc: apw@shadowen.org, rdunlap@xenotime.net,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Make checkpatch warn about pointless casting of kalloc returns.
Message-ID: <20070808180056.GF26440@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	jschopp <jschopp@austin.ibm.com>, apw@shadowen.org,
	rdunlap@xenotime.net, Linux Kernel <linux-kernel@vger.kernel.org>
References: <20070808024321.GA6316@redhat.com> <46B9F7C9.9060406@austin.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46B9F7C9.9060406@austin.ibm.com>
User-Agent: Mutt/1.5.14 (2007-02-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1095
Lines: 37

On Wed, Aug 08, 2007 at 12:05:13PM -0500, jschopp wrote:
 > > +# check for pointless casting of kmalloc return
 > > +		if ($rawline =~ /\*\)[ ]k[czm]alloc/) {
 > 
 > It looks to me like this will catch
 > 
 > foo = (char *) kmalloc(512);
 > 
 > but not
 > 
 > for = (char* )kmalloc(512);
 > 
 > I haven't tried it but how about something like:
 > 
 > if($rawline =~/\(.*\)\s*k[czm]alloc/){

Hmm,  could even just drop the check for the '*'
)[ ]k.. should be good enough.

 > which if I got it right should match the typecast with any combination of spacing.
 > 
 > > +			WARN("No need to cast return value.\n");
 > 
 > Could the warning be more descriptive?  This describes what, but it should also describe 
 > why; after all if somebody made this error they may not know they why.

I'm open to suggestions..

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/