Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Tian, Kevin" <kevin.tian@intel.com>
Subject: RE: [RESEND PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq()
 for NMI/IRQ reinjection
Thread-Topic: [RESEND PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq()
 for NMI/IRQ reinjection
Thread-Index: AQHY9M9YytlyKV7ob0GK/oJbeBhPY6433PwAgACmfxCAAO8aAIAAL0qAgAAENoCAAAgUAIAAGnuAgAA1qHCAACERAIADuBAAgABQYICAAXpoEA==
Date:   Tue, 15 Nov 2022 07:50:49 +0000
Message-ID: <BN6PR1101MB2161299749E12D484DE9302BA8049@BN6PR1101MB2161.namprd11.prod.outlook.com>
References: <Y2y+YgBUYuUHbPtd@hirez.programming.kicks-ass.net>
 <BN6PR1101MB2161976800EB14B74A24D9F3A8019@BN6PR1101MB2161.namprd11.prod.outlook.com>
 <Y24SoNKZtj/NPSGy@hirez.programming.kicks-ass.net>
 <6097036e-063f-5175-72b2-8935b12af853@redhat.com>
 <Y24908NWCdzUNqI0@hirez.programming.kicks-ass.net>
 <6fd26a70-3774-6ae7-73ea-4653aee106f0@redhat.com>
 <Y25a0Z2tOMWYZs4j@hirez.programming.kicks-ass.net>
 <BN6PR1101MB216141A21353AB84CEA541DFA8009@BN6PR1101MB2161.namprd11.prod.outlook.com>
 <Y26jkHfK9INwU7Yy@hirez.programming.kicks-ass.net>
 <BN6PR1101MB2161E8217F50D18C56E5864EA8059@BN6PR1101MB2161.namprd11.prod.outlook.com>
 <Y3IFo9NrAcYalBzM@hirez.programming.kicks-ass.net>
In-Reply-To: <Y3IFo9NrAcYalBzM@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ekVvbvdgeIg0zlaNLS7vrl4PnOdI6BlhgLCb5/l4a45gp693aJCG1AZXPTdI?=
 =?us-ascii?Q?uGk2Tq5JrtouGNdf+VF/wlkaJ4m/Zim4mSgJitGinGd0KHPMSX6+r+XmQkgn?=
 =?us-ascii?Q?iZF96WS2AkjNKqoD1xRxEIRDtO39c1nGu/mkb3s3miwxda9kpBlGqmDrjPY+?=
 =?us-ascii?Q?2asLk3nViAj5ICRbhIJ77ej6fMLzixUYredG2y+0BUCNLwxFiDZIwLkkCysf?=
 =?us-ascii?Q?4CdzrmFcloNR1M6sT4V/bOKd6OrhOZH+stbkiquKyJDh9kmSI+8sHxVHvXts?=
 =?us-ascii?Q?w3SaA76PXiOBrwYdQR9vqzaz5k9+EgzRVEODMV3Ut+9oXMRi8j9sQH5+pO8L?=
 =?us-ascii?Q?LUQ8rn5SLn+b9cGB1FrlsML+Mmj4q5ZTs42TJO9fyiAqrbXJcmt2WTrTZpz9?=
 =?us-ascii?Q?L4AtvNtMSohw7K+qNVkvUGTfBbKYIKB9rE1yiRJ/r3Bs4LwyFHfKmUlDIhxX?=
 =?us-ascii?Q?WUyTWV6/7RnUwPIrgdM1+WwljlcS2GYIWChHSyIaZPksIUR7jKXaTueUYUeU?=
 =?us-ascii?Q?LThs+jK1e1fsj3DV/UrC1WhHA35bxZzgyA5AJstJgxs38IR7GExRTy+O0zcq?=
 =?us-ascii?Q?gqXtbdQntXpWQKDOiWtL8vye7zDeikNb1wdnYsDkLsudf6D9iD42gzwP4o8B?=
 =?us-ascii?Q?RTBc9XL6QM/3EkSIA78n34p+h5M1uBT2bPPhI5eyDwvl4/Tij5i1Iw3kgP96?=
 =?us-ascii?Q?68sPASKVNfq8Zw17Z8+ZtcEogfYkfbt3TOQ2sAyXof/hOxDRX7NRLrQ1YeAs?=
 =?us-ascii?Q?8QPHJa/5RnU7j0gHmE8ye9HzCY605BiZZUoV5JNXObnfqPU2RG30QSYoyS49?=
 =?us-ascii?Q?0pJOw741YJK/xb9q188E214CySO8OYYhlEmcPRpPv1Dti1eXRyqmHCrKykHW?=
 =?us-ascii?Q?CVjl7KhLWMTGFKHHB95AhdSOhGeh6O4K5J4a8q/3ry1vm9znfd20IxabLJ0w?=
 =?us-ascii?Q?MpRVc+M6rhn1nzVt2f9RxL1O1mEAy0s/N6bmjU/Ta7V50RwMMcZjvCqgsXyn?=
 =?us-ascii?Q?BMKLq5mV+HwWB0tmw+WnKna9dVorqU9R39tR/BIdKcR2Z5OVt75aWJkC/n9m?=
 =?us-ascii?Q?41GUFByEB0RuyPwCQdcUnGQtBQO2KYiG5YalYMyPRO/deocSivFFROuTziXe?=
 =?us-ascii?Q?Yzdd83N/1SNgMgepzivDKRTeVbPzMp9BP7liH0WKrRJR1TXR4aCStZfSWO25?=
 =?us-ascii?Q?jyR9Njl/5rAdseflExfzLYRMflW7D/IYBXVs/aR1wXweLnzyH1UW8VtLzigd?=
 =?us-ascii?Q?XYOKHqvt5g9yF1IUPpCru3vH5d8gEFK4qY3pJTQY3ivYK9YyU+p55Pgvl1CH?=
 =?us-ascii?Q?EHUDN1aZc4eIs7RDApVlZvMlQ9G51h0fb8oJc0h/4z9+kRbt49UZh9lk5KJ1?=
 =?us-ascii?Q?UNtGi6/MDkL82yJgBGJfWD/pKyhmJsxhKdP17SwizQh+bsv+ePmhKP2mgJ8m?=
 =?us-ascii?Q?zV/DNzlhvpHKUesIhrd+63wuUWw8uqZ5AlFRsJZ9BUDYT6lZhQsok2qXlgyx?=
 =?us-ascii?Q?USgA93lJ7pZhWrjNh7gM6wjazgSJtCHx0D80AFqE9IrvjO+sZS9c1jitqb90?=
 =?us-ascii?Q?YxViuNZ0CoA4Q02hmMA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2161.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 624394ea-6108-4177-205f-08dac6de1c98
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 07:50:49.0805
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wxC4/8dF9jzQT6sU3+57aA8Ax7JdL3FUul94ef2dsDb/efbBITWLxR45JdILku4Xd6lyWrzFo1AKzlR3Yfey5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5376
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > But what about NMIs, afaict this is all horribly broken for NMIs.
> > >
> > > So the whole VMX thing latches the NMI (which stops NMI recursion),
> right?
> > >
> > > But then you drop out of noinstr code, which means any random
> > > exception can happen (kprobes #BP, hw_breakpoint #DB, or even #PF
> > > due to random nonsense like *SAN). This exception will do IRET and
> > > clear the NMI latch, all before you get to run any of the NMI code.
> >
> > What you said here implies that we have this problem in the existing co=
de.
> > Because a fake iret stack is created to call the NMI handler in the
> > IDT NMI descriptor, which lastly executes the IRET instruction.
>=20
> I can't follow; of course the IDT handler terminates with IRET, it has to=
 no?

With FRED, ERETS/ERETU replace IRET, and use bit 28 of the popped CS field
to control whether to unblock NMI. If bit 28 of the field (above the select=
or)
is 1, ERETS/ERETU unblocks NMIs.

>=20
> And yes, the current code appears to suffer the same defect.