Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6639527rwb; Tue, 15 Nov 2022 01:16:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf4x5jvGbeQxNOcHtUlyC8ZaytMXzjcsbN+7eP6NPKs/F+WYJybPeg9ozzlUH/MQM34wcxpc X-Received: by 2002:a17:90a:e81:b0:212:c216:50c1 with SMTP id 1-20020a17090a0e8100b00212c21650c1mr1257011pjx.163.1668503800857; Tue, 15 Nov 2022 01:16:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668503800; cv=none; d=google.com; s=arc-20160816; b=cK9wscnPxhNkAVH25xWTCllynGpw0nTp+4X3ZG5z+CLlT0XSLH9CJrY3pQM/dzB1di QIRiDoVSgng3u7BQ+DevSuLDkvhct2JxqY59fwIvYrtJWwnaFfPnZaFk601EIcEiVIdH t5FfOehmI2BCVQaz8R+6yJRx1kY82wAOnIh8Xywm3/qydZnikboUeFP0DfaKpeLEwFmU U4C2D1MfXot6HvM0ciTReIxeib8RGEMXqiWLE+PvvdATya7fML8G2nUpYsxvLDg4If/8 dm8oge6Z3sTarZIg2ojzBK11OJTeZ2MXFq3KJB84uKHfxiSpk2lYrYKQztQcr1y4U+62 L/Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=UqMA6Tje+3ZsVcAAIQPTB3aQZjTGfrywbsqDdzk9JQs=; b=unWnMef8ciMkqDiO3xCF8N+cENcFWNJao/YF1L1y2tz/Nr4/QCUbC8BvYLtfEDTB2l q8bSGsCMTPkiPf/9AanUW2lW7UhdVpu8VQx8CZ6db+2ommztByvjGqo2dQnQ4VuGenNY JFdVE4pmxOlGZWNySFn4Jrh+0JJk8iqGIe8fNpZhFm9lXmXniBMjweMbCsCjkgeuvQSi 1XPAa7+rfkFMmApjP8wZRbpASYThMp517myOg+EGBrZsExjodK1InKOkEtJteX1MZLfA JaiqHDNLk7xNmM1+c2EhIi8aQE1rdwPjmGR+McQz6sV5MjcHaZ+uBduD+I2Sk9IzMciv Y6Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b="KIp2+/ch"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ieee.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a632c0c000000b00476ba5e977bsi1124596pgs.327.2022.11.15.01.16.28; Tue, 15 Nov 2022 01:16:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b="KIp2+/ch"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ieee.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233032AbiKOJAj (ORCPT + 88 others); Tue, 15 Nov 2022 04:00:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbiKOJAh (ORCPT ); Tue, 15 Nov 2022 04:00:37 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5D6E95B1 for ; Tue, 15 Nov 2022 01:00:34 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id o4so22947701wrq.6 for ; Tue, 15 Nov 2022 01:00:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UqMA6Tje+3ZsVcAAIQPTB3aQZjTGfrywbsqDdzk9JQs=; b=KIp2+/chwKI09PZkHXOBaaLZqJANenWBoecDu/vhLEPD8onbbS1Dlly1mkfV7tefeZ 6sw8kVUIFff+j7w99uAp1bPMm5B8+hngwOFKybRZBl0BhBYmWMmsMzSaTxCLetRaLhNE hdkGZwUdt7t8k9QhYgHQU8zJ7bVLuZ2IErfgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UqMA6Tje+3ZsVcAAIQPTB3aQZjTGfrywbsqDdzk9JQs=; b=HlJnTeMWEvyZXGz8r+Cczo6lEhO1ysaMX/yFg3da7SDTvhMgSSOKcvV8iORPPxcoL/ JIM0wcrZnpkanj0oJzQ3iupRfxDyWR/RYJdfMaEhcWU3LqoUW8jMeQoWE/djeFhOviJl xc+49woIlDNaO0ZdCoqTizf7rtgg1cTiKQdpgZeQJaqdIU6tLntt/vAZgpf2biiwpreL m77eTS6/IxYikZOHM2nuQ6dRhc1/ccnFnk6njMoJTdIsZcP6X1XSnXxvPGo4ja2zV8/i 8b5EQdzcSBnoESAVAd17ccA71AXRO+VOPdNKCw8okT2pxKsWeDrydceu1L4C1RWJpasM a/fg== X-Gm-Message-State: ANoB5pl2DbjgxQM1ZBFrEQuW0xdvRZhdQ91xxAqVs3JpgaSK4JAuU5tv WptOu0Cu4hNBueEPKY2PSd3Zmw== X-Received: by 2002:adf:a4c1:0:b0:236:6f18:37e6 with SMTP id h1-20020adfa4c1000000b002366f1837e6mr9637216wrb.262.1668502833056; Tue, 15 Nov 2022 01:00:33 -0800 (PST) Received: from [10.211.55.3] ([167.98.215.174]) by smtp.googlemail.com with ESMTPSA id w9-20020adfee49000000b00228cd9f6349sm11842579wro.106.2022.11.15.01.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 01:00:32 -0800 (PST) Message-ID: <48fbae83-728e-d7ec-7516-4f8c972a1a1d@ieee.org> Date: Tue, 15 Nov 2022 03:00:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH net-next 1/5] dt-bindings: net: qcom,ipa: deprecate modem-init To: Krzysztof Kozlowski , Alex Elder , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, agross@kernel.org, elder@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221112200717.1533622-1-elder@linaro.org> <20221112200717.1533622-2-elder@linaro.org> <2f827660-ae9d-01dd-ded8-7fd4c2f8f8ae@ieee.org> <88fd2f42-6f20-7bbe-1a4d-1f482c153f07@linaro.org> Content-Language: en-US From: Alex Elder In-Reply-To: <88fd2f42-6f20-7bbe-1a4d-1f482c153f07@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/22 01:59, Krzysztof Kozlowski wrote: > On 14/11/2022 18:48, Alex Elder wrote: >> On 11/14/22 03:56, Krzysztof Kozlowski wrote: >>> On 12/11/2022 21:07, Alex Elder wrote: >>>> GSI firmware for IPA must be loaded during initialization, either by >>>> the AP or by the modem. The loader is currently specified based on >>>> whether the Boolean modem-init property is present. >>>> >>>> Instead, use a new property with an enumerated value to indicate >>>> explicitly how GSI firmware gets loaded. With this in place, a >>>> third approach can be added in an upcoming patch. >>>> >>>> The new qcom,gsi-loader property has two defined values: >>>> - self: The AP loads GSI firmware >>>> - modem: The modem loads GSI firmware >>>> The modem-init property must still be supported, but is now marked >>>> deprecated. >>>> >>>> Signed-off-by: Alex Elder >>>> --- >>>> .../devicetree/bindings/net/qcom,ipa.yaml | 59 +++++++++++++++---- >>>> 1 file changed, 46 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> index e752b76192df0..0dfd6c721e045 100644 >>>> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> @@ -124,12 +124,22 @@ properties: >>>> - const: ipa-clock-enabled-valid >>>> - const: ipa-clock-enabled >>>> >>>> + qcom,gsi-loader: >>>> + enum: >>>> + - self >>>> + - modem >>>> + description: >>>> + This indicates how GSI firmware should be loaded. If the AP loads >>> >>> s/This indicates/Indicate/ >>> (or any other grammar without describing DT syntax but hardware/system) >> >> OK. >> >>>> + and validates GSI firmware, this property has value "self". If the >>>> + modem does this, this property has value "modem". >>>> + >>>> modem-init: >>>> + deprecated: true >>>> type: boolean >>>> description: >>>> - If present, it indicates that the modem is responsible for >>>> - performing early IPA initialization, including loading and >>>> - validating firwmare used by the GSI. >>>> + This is the older (deprecated) way of indicating how GSI firmware >>>> + should be loaded. If present, the modem loads GSI firmware; if >>>> + absent, the AP loads GSI firmware. >>>> >>>> memory-region: >>>> maxItems: 1 >>>> @@ -155,15 +165,36 @@ required: >>>> - interconnects >>>> - qcom,smem-states >>>> >>>> -# If modem-init is not present, the AP loads GSI firmware, and >>>> -# memory-region must be specified >>>> -if: >>>> - not: >>>> - required: >>>> - - modem-init >>>> -then: >>>> - required: >>>> - - memory-region >>>> +allOf: >>>> + # If qcom,gsi-loader is present, modem-init must not be present >>>> + - if: >>>> + required: >>>> + - qcom,gsi-loader >>>> + then: >>>> + properties: >>>> + modem-init: false >>> >>> This is ok, but will not allow you to keep deprecated property in DTS >>> for the transition period. We talked about this that you need to keep >>> both or wait few cycles before applying DTS cleanups. >> >> My intention is expressed in the comment. Is it because of the >> "if .... required ... qcom,gsi-loader"? >> >> Should it be "if ... properties ... qcom,gsi-loader"? > > You disallow modem-init here, so it cannot be present in DTS if > gsi-loader is present. Therefore the deprecated case like this: > qcom,gsi-loader = "modem" > modem-init; > is not allowed by the schema. > > As I said, it is fine, but your DTS should wait a cycle. OK, then this is exactly as I intended. I am planning to wait until Linux v6.2-rc1 is published before I post the DTS updates that implement this change. It is not technically necessary until IPA v5.0 is fully supported, and I don't have confidence all of that will accepted before then. If I did it "your way" first I could get it done now, but then I'd want to do another round later to make it this way. I will still send an updated series shortly, to address your other comment about wording in the description. But I will not be changing this part. Thanks for the explanation Krzysztof. -Alex > > > Best regards, > Krzysztof >