Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6641332rwb; Tue, 15 Nov 2022 01:18:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf6WGcKRGE0vQGP7mro0YUzaKmvTNNWFfHjLNDCCQ6qXmsYFKxb6a1s01UfChe+t0P2n65JS X-Received: by 2002:a17:90a:13:b0:213:cb87:8cd4 with SMTP id 19-20020a17090a001300b00213cb878cd4mr1305351pja.78.1668503923527; Tue, 15 Nov 2022 01:18:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668503923; cv=none; d=google.com; s=arc-20160816; b=Mt+3hExaXCQed6dPOBVlkJb5IRM61lvkXb1YucLRvf8xS/TLN2lVg7Ln+pO9VHr6hV lje5u5WHq9G7wa1dg90micNRWoJk5E9CMvse21leKgGZRo09vC31B9BeyEwoLhrV6MZ9 52v3A3ro5zh9EG6i844exQ09cgnXFC6LIbqP3D12j95mrko2suZJb0t7PPLKmWnt/+sV SmijGzjxRtJjNXPaznjZZgNk0BLFVHlwgKottk9G4+mdzqt2/ijmW+99+0HFyqkomsFR RSoC7Eauu9Kv0OsoeykJklYHpYO08qsfQ6xUrzmbPpEMba7/VVRoq9edd5e1vtRbJkuP AigA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=jy+YcAHGGRI7naN8Xlp4Mg8tyW78c4FvFGkovwWZ8gE=; b=LbMkWJ9VDw+Pchch+0trHal5arRtrcGG1Gc1xBp01zyWCjdzjQBcIQ7xLMdQL/xT21 I1mkQZ2fGIksCljHXctQ7qtctuO9hlvlU97G0L/gNMGSUuDyKnMRXx+swsOyyfYdyhVQ DBspiSKcCr56rI5P2ZPh9+k9NqhGAItSnfNqlk0EFjNoC0ar3TpGXUZ7Cjfzcac6SzK8 FSDUY8fhkCQesXO3iVDtodBjV/ZEYvE10BM5c8CrrOvB+0gujwpAzMWkgnj8ZtOHneTb JxHy0IupyaNMQU3WOfLZ9X3t3LiXDIKPe5Bo9p3Y9sBnUq0FGPEztdBeHNqw6z1w3diD RiuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x23-20020a634a17000000b00476bfca38b0si798516pga.71.2022.11.15.01.18.31; Tue, 15 Nov 2022 01:18:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237631AbiKOJI0 (ORCPT + 88 others); Tue, 15 Nov 2022 04:08:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237649AbiKOJIS (ORCPT ); Tue, 15 Nov 2022 04:08:18 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A9A1E71F; Tue, 15 Nov 2022 01:08:15 -0800 (PST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NBKy95RNpzJnj5; Tue, 15 Nov 2022 17:05:05 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 15 Nov 2022 17:07:44 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 15 Nov 2022 17:07:44 +0800 From: Hui Tang To: , , , , , CC: , , Subject: [PATCH net v2] net: mvpp2: fix possible invalid pointer dereference Date: Tue, 15 Nov 2022 17:04:33 +0800 Message-ID: <20221115090433.232165-1-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause invalid pointer dereference to priv->cm3_base behind, if PTR_ERR(priv->cm3_base) in mvpp2_get_sram(). Fixes: a59d354208a7 ("net: mvpp2: enable global flow control") Signed-off-by: Hui Tang --- v1 -> v2: patch title include target --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index d98f7e9a480e..c92bd1922421 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -7421,7 +7421,7 @@ static int mvpp2_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "Fail to alloc CM3 SRAM\n"); /* Enable global Flow Control only if handler to SRAM not NULL */ - if (priv->cm3_base) + if (!IS_ERR_OR_NULL(priv->cm3_base)) priv->global_tx_fc = true; } -- 2.17.1