Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 0/5] Add kprobe and kretprobe support for LoongArch
To:     Huacai Chen <chenhuacai@kernel.org>
References: <1664326209-13995-1-git-send-email-yangtiezhu@loongson.cn>
 <CAAhV-H47oPC6mYkeDh7NfmvL2jAHO32ugM-PK2mmFY6XdqF8_Q@mail.gmail.com>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <1af099bf-123e-06bb-cd9a-5fd939f9cb79@loongson.cn>
Date:   Tue, 15 Nov 2022 16:44:05 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAAhV-H47oPC6mYkeDh7NfmvL2jAHO32ugM-PK2mmFY6XdqF8_Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/14/2022 12:31 PM, Huacai Chen wrote:
> Hi, Tiezhu,
>
> Thanks for your patches, however,
> 1, You should rebase your code, since some functions such as
> is_pc_insn is provided in the github's loongarch-next branch;
> 2, Your code may have some problems about preemption, you can do
> something like this commit [1];
> 3, I don't think Kprobe should be enabled by default, distribution
> configs can enable it if needed.
>
> [1] https://github.com/loongson/linux/commit/023d5412ab5c154b87d57d70d465a4243df53717
>

OK, thank you, I will rebase and address the review comments,
and then send v3 later.

Thanks,
Tiezhu