Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221115090433.232165-1-tanghui20@huawei.com>
In-Reply-To: <20221115090433.232165-1-tanghui20@huawei.com>
From:   Marcin Wojtas <mw@semihalf.com>
Date:   Tue, 15 Nov 2022 10:16:36 +0100
Message-ID: <CAPv3WKc_iwojwpBqX+QK0_atp3vQiN4C8h_qqj=OPEQUJzMpeg@mail.gmail.com>
Subject: Re: [PATCH net v2] net: mvpp2: fix possible invalid pointer dereference
To:     Hui Tang <tanghui20@huawei.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        linux@armlinux.org.uk, leon@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, yusongping@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

wt., 15 lis 2022 o 10:08 Hui Tang <tanghui20@huawei.com> napisa=C5=82(a):
>
> It will cause invalid pointer dereference to priv->cm3_base behind,
> if PTR_ERR(priv->cm3_base) in mvpp2_get_sram().
>
> Fixes: a59d354208a7 ("net: mvpp2: enable global flow control")
> Signed-off-by: Hui Tang <tanghui20@huawei.com>
> ---
> v1 -> v2: patch title include target
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/ne=
t/ethernet/marvell/mvpp2/mvpp2_main.c
> index d98f7e9a480e..c92bd1922421 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -7421,7 +7421,7 @@ static int mvpp2_probe(struct platform_device *pdev=
)
>                         dev_warn(&pdev->dev, "Fail to alloc CM3 SRAM\n");
>
>                 /* Enable global Flow Control only if handler to SRAM not=
 NULL */
> -               if (priv->cm3_base)
> +               if (!IS_ERR_OR_NULL(priv->cm3_base))
>                         priv->global_tx_fc =3D true;
>         }
>
> --
> 2.17.1
>

Thank you for the patch.

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Best regards,
Marcin