Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Nov 2022 09:36:01 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Wei Yongjun <weiyongjun@huaweicloud.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>, openbmc@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/wpcm450: fix memory leak in ap_init_qci_info()
Message-ID: <Y3NPcfuS9M6BSoEW@probook>
References: <20221114110854.554220-1-weiyongjun@huaweicloud.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="OpoW+8ODgSOojoM3"
Content-Disposition: inline
In-Reply-To: <20221114110854.554220-1-weiyongjun@huaweicloud.com>
UI-OutboundReport: notjunk:1;M01:P0:OJBTx31lpRg=;Uf9LVFh/uWQET4QMzShH3U0PXhA
 ESsYM+KiwJ1wlDCcOwtWtkBcblRQgF5JUkupzTZsbTJXWi/TDOZ0vdoJl2cqVUXFF15dabY9g
 9j/xh4rl3uDepnDMjPnuM5RSXSq+W9mPLZTJjUKwwHJx1K3dtXNp2WXYJtnBeJWWn4FtRXTfp
 wmw2Nh5iHVmV4KLS86XU2aYeWPNpOJ8NEZROTBdyCzbBQmTgP3WGB0XKtX50wZU7fwlKwwKno
 3GGZFDm1+qQvtvRX+1xd2p+SRbZITop+SzExkOK8pXgFWS/M++Bs70GY64f0+jNBZ798RNjZt
 DyY1BcOjIJx16OcGxEkbQcDtiCRqUg6jvR3gD1CCRUBvFyyzmTuENRuPyj2hrstFM0mBgGfGI
 bwCYNi4f8ry0Z8eX8Y0i+NlVFsKePmcAhrjrvyDUm2/4fYd4aakXgRqJJZ13+dJacHAwY7giS
 4RQgP+9LfoiuUg4pUkyfN4Rr093cS7Lth3REvtM8f2N6qWmCJsE+V9coQQ5zkOX82lOAgXgcG
 Gp9uCmeDAqvuAyuLrKQfZXURgqDRoJmJbBaNkv5JmTc8iWP+K/n+ddFoP0kfF+GCCocAD16OG
 dEu3xOccHCOFCEPFmWx8ySaB1gjGxvn8pzLQUI1o32GvF5uz1blMXBIx1GQFcnnNRhDNnKai5
 bJu9lgE9emYexBXc1Y6tndAv+v1YdhxeceMuUpHI1XVWTuq/pSsMEMIorZjig5zViWTxYpwN2
 1sAvxe78ae9hgt5/434CU2ZL6Gs4RI0+++BKLSe6Uy4auiIkJxkRd3uqZv7jqs8ctlCSLaewT
 FWgAvUzhfHbFoz2RL64E5Ddak0NVVe2uoWrPpkl/Ku98tACN4hcGz9nWWctC7Pj248jNQZd3G
 iGp09fSXy/oJsbMzlmXxRJ97uScIO+Q+HsNbcb4L1zExVjuei7WWVSl5KmyOZLcqmZByeLSZ8
 NXw4kg==
Precedence: bulk


--OpoW+8ODgSOojoM3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

the function name is wrong in the in the subject line. Other than that,
the patch looks good.

Thanks,
Jonathan


On Mon, Nov 14, 2022 at 11:08:54AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>=20
> If of_iomap() failed, 'aic' should be freed before return. Otherwise
> there is a memory leak.
>=20
> Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controlle=
r")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/irqchip/irq-wpcm450-aic.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm=
450-aic.c
> index 0dcbeb1a05a1..91df62a64cd9 100644
> --- a/drivers/irqchip/irq-wpcm450-aic.c
> +++ b/drivers/irqchip/irq-wpcm450-aic.c
> @@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_n=
ode *node,
>  	aic->regs =3D of_iomap(node, 0);
>  	if (!aic->regs) {
>  		pr_err("Failed to map WPCM450 AIC registers\n");
> +		kfree(aic);
>  		return -ENOMEM;
>  	}
> =20
> --=20
> 2.34.1
>=20

--OpoW+8ODgSOojoM3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmNzT0sACgkQCDBEmo7z
X9tK2RAAjTt5BNtkhcsie3OPZWUiTCBinyz3x/TksHO9LRDI+DNoO7dVCLnZFYsX
Rc/ucClYW8qNxsLF462dXKSxSUZPA/hqcnsr9rU5nbRSCob5gMrpKiUVuXgi4/tT
/OvO8R5RGa0v55xpE3m9QZHK1oOLTzXCvq8MYZtKBajU92nrZN7KqSrF1BSt3mSZ
pUmioq+qZnEcHnIXJEF89W2DVqwyTmGhcXI3AUdPyiNCkAjw1quJqzQgDY7BUOBH
UbMpBxqdntxcaVy9s+4q5/GLIovYaTxtJNgY/TD9Q7Tl3Z7kRR3wGmKzeE3BJ2Tm
dgm0fbk4M28M6Y3GRAHKtT3emiRg8iIJ3/h4SFC18rv+tczqHUz1kKHJ2Wg0zzKL
P59GgslJIWdjwPKWzGjQ6SqGiKpEDJxx0qS+2PM3jLrULBQWQhmNnmA7t5vfUJn5
eoZuygQH8/XISq+JciA2WGr9evUwKc5jeH1sL22UjkRpEFyhvLByxkmKnKT8eGvG
6Y7AcTRWrzuyDMzoC93uQ5DrRP2wsSKS6sZMFzw9quDdqjZrI69n3Z6aF+aYlWBS
RdZl/z9x9rIaWWu6Ea/6LlLxa68bwIADjEx7mX18qSvpdD9lZIm18jX1qZHwkfB/
J+69kdFfAkJ2V0I7o5TpdoC8xPfhkDQReRsuy/hnj3cr/Mb4uX0=
=klm6
-----END PGP SIGNATURE-----

--OpoW+8ODgSOojoM3--