Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6673688rwb; Tue, 15 Nov 2022 01:56:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf4kpwU6mgvBUsMWv+fcnxwMerJYEvC2BdMVAaXhvu1q0xayqMp+6muwZWTVl41f67IfXDM7 X-Received: by 2002:a17:906:3046:b0:7ad:8f76:17c7 with SMTP id d6-20020a170906304600b007ad8f7617c7mr12879928ejd.315.1668506190489; Tue, 15 Nov 2022 01:56:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668506190; cv=none; d=google.com; s=arc-20160816; b=MP4bdHzxJlf85LdA50HXFFj0uUjxx/D7HKJKuXr0umHsz9z4y1FMqFJatmMPDJm8rs YXnk2wYi66TMjhxgUKHaIsxmTZUoETQqj/+RNGRq5VWEk/E6/f7EELCMpP0KQ7/i8Htr E/DeqtlN9EZgdyh/VB+Uc7HJWOaLcQfDhpB+SjuQbCdsna0Ji4t9ekW1GfksstA+nlW2 BRPMbAWFv6zX/AOeUZawTYHD/y9WED8EWg/VNB6/DtVXj6K1BKACv1WYho68sqgrtfyg 3NI9btcxdwu17S24hN4PpTkiJPsrAf5zq7z+foVEN3WAxo2gzvfxcOdbjK6xWIcLZlbF rpyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nNmdNr72F7JnqSK5T7GGDKWQNE+gfCD7Nu7AVN1iiIo=; b=QlUAua24p00oM+bH/lXfSvRS77B0sIso56Gu0ZQrIeGC5qy3rZfC5p5gAp0d9hdSbC s0ZJkePq5tCtOIgTvzXfvO1KVKHb2Du/lycn9zD341/ouAguTWmK62X0Ob9APISYAO70 1PJBCrDctRh6rH/jab0yWilBVnEgNOYsMOKotuRZz2zN8XgsYAhlo7J8N0c1MGVrinUL 9F9QQfYrYvZpnt92xHuIVq9lxdHwLyZJRmEMTYHDYh8NyaSEt8MI/2sQtOI6eUfvgOkc ydHtxhkMCQryErMvLHtZfAw4qu5mA6TKQVEzZUOAmZAsrFKAjRqZyRx0gOJC0YVx2+9u tM5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SW8L4WsN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a170906600f00b00782e85ae302si9111464ejj.574.2022.11.15.01.56.09; Tue, 15 Nov 2022 01:56:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SW8L4WsN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237906AbiKOJNL (ORCPT + 88 others); Tue, 15 Nov 2022 04:13:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237701AbiKOJNK (ORCPT ); Tue, 15 Nov 2022 04:13:10 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6AA321E2A; Tue, 15 Nov 2022 01:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nNmdNr72F7JnqSK5T7GGDKWQNE+gfCD7Nu7AVN1iiIo=; b=SW8L4WsNy8yyQUdTdG5ZYEXJZ+ 9mXaKQ3S1/iWWsMdDncHfptCDhfA0bnRGlVXe5BC6AXR5nSUFNpsrlk1OOd3L6aey3Q+7FQ+2hQZm h2yfySIVHCksLL59ter4Ezk8nHA6oI8GFSSiKQHFkNBO+dDY0Opt7pH5j4C35THvR+4TJJnk/RDqe WjR7ny+havRvsFAf2sx+75vIA1Fa55hUJo4KtKixDyRpsp/GFje0HgVyLP5vvMB1u/qLi9Isx5qa4 yA7R1iZLMDVaV46sc1wGzKkV0FJ/G3a8QOYUnDZEAjTSliXEgROLwH5e+F9+CuCtvRA4uPkAWoA7W whSwXFtg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ous0B-009EFP-TN; Tue, 15 Nov 2022 09:13:08 +0000 Date: Tue, 15 Nov 2022 01:13:07 -0800 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] blkdev: make struct block_device_operations.devnode() take a const * Message-ID: References: <20221109144843.679668-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109144843.679668-1-gregkh@linuxfoundation.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 03:48:43PM +0100, Greg Kroah-Hartman wrote: > The devnode() callback in struct block_device_operations should not be > modifying the device that is passed into it, so mark it as a const * and > propagate the function signature changes out into the one subsystem that > actually uses this callback. Yes. In fact it really shouldn't exist at all. I wonder if we can do another attempt at dropping pktcdvd?