Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6765858rwb; Tue, 15 Nov 2022 03:29:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf7MeeAyljS2kdtrYK8QgFGTVphtev3Ih8no064sVvuE1zYudQQu9eRyiL3iu7/JBsEY4GTk X-Received: by 2002:aa7:88d2:0:b0:56b:8181:fe3e with SMTP id k18-20020aa788d2000000b0056b8181fe3emr17918929pff.57.1668511753370; Tue, 15 Nov 2022 03:29:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668511753; cv=none; d=google.com; s=arc-20160816; b=XrhiDRCsESC3Mm1zPZIuvStxfDLR7h7wGiTou2bMCTh9jH8mHiIJGbb9H5LawbauO3 ehjqEtwdDtEA8Iz3EZMtdGN67xn+kBsBlqpJWPVlIJa664txzaGgd0gtZSbk2UI7ynQB lvEdciQaidgv8UvKkZdXBBjm+zO/2feLYBixGn8v9LtmHIJ/yh3rhmQqxflQuytgIuZ6 Iolyaszc7LdqwfwkdxEXXb4lKtARqaoue0/PiaW8ma16HRd7vNDHjERgOLvCh1VjEa8K 6dYLFODRfeeE5CJlLGsGEuMJ7AggHxooMukSoXApXnWrXRy8Zk25K7+jCVCNgFBlHdK8 21eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7rjjuG4MhWSWvJIH4DsOcCy+1gVkrN814g410rEgjz4=; b=ZeAQcX0fzFWq/jHdO6liH3o4Dw8qRHbjpmqUXnm2SuUgBcGwr6PE3IH43IdIMuGI/G B7UC1krMqbk5aXryQrv5cKMWTXmvEwKo+pD4ocjQiuTd5mx5iTTxdanto/YiSEtLhuYf e6rLXxMVTC0WPeA08SJQIpZ5zmfcJUpWqFoGYyu/J6Kfe7ecHMl/6rQoox/OhPAhXHCl ktMn65ajvvstUS+a3kYVAIOAjm7aaVoSALJ7L28k7Gwh5ffodbi5pN/2SFgGBis+9FTv m1I40bcrM+oIasYI2WFOyCdYx05qGfU+pTJkiGlKmlU2pQhpSWpSZPrkD2R8XKwBteuc WSfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=enAVznMC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw15-20020a056a00450f00b00572899f993fsi519832pfb.306.2022.11.15.03.28.58; Tue, 15 Nov 2022 03:29:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=enAVznMC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbiKOK15 (ORCPT + 89 others); Tue, 15 Nov 2022 05:27:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238332AbiKOK1f (ORCPT ); Tue, 15 Nov 2022 05:27:35 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED28D1F9F3; Tue, 15 Nov 2022 02:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7rjjuG4MhWSWvJIH4DsOcCy+1gVkrN814g410rEgjz4=; b=enAVznMCK/RCROvdDARJDbzBoz kxDyIP8h+D6lJx4lvrfd1axgekqzg56kfgGA3FBr2JNukrRzzYqXfIoJzkTZS9ysKlb+dRG62pXVk q1LBFTTNn9OdUjgIYHvn0Lwj0mI3ssiYn+UNIpmyYcWgh9K/n8DygdqXz9QyTPWp/E5fhu9O8xbGH tpnjBteP1e0swrboXUYztS4CNT4M2Y4xHGGRBtimRtIrgStskNKBVUzgOOsOsJw2MVk7NqA09ZAym i6L0euegCdnwQcr1t6wA7l3tSBghwV69XBcegSuB4aYAe49nOdJhjr0VKbkbywkU72XNCdl0UEeCo gCY0PrOw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1outA5-009ugK-OR; Tue, 15 Nov 2022 10:27:25 +0000 Date: Tue, 15 Nov 2022 02:27:25 -0800 From: Christoph Hellwig To: Jiapeng Chong Cc: nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting Message-ID: References: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2022 at 01:48:47PM +0800, Jiapeng Chong wrote: > + if (vmd->irq_domain) > + vmd_set_msi_remapping(vmd, true); > + else > + vmd_set_msi_remapping(vmd, false); Why not go one step further: vmd_set_msi_remapping(vmd, !!vmd->irq_domain); ?