Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764832AbXHHT0Q (ORCPT ); Wed, 8 Aug 2007 15:26:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757224AbXHHT0A (ORCPT ); Wed, 8 Aug 2007 15:26:00 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:45955 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755733AbXHHT0A (ORCPT ); Wed, 8 Aug 2007 15:26:00 -0400 Date: Wed, 8 Aug 2007 20:25:58 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: linux-kernel@vger.kernel.org, John Johansen , Jan Blunck , Erez Zadok , "Josef 'Jeff' Sipek" Subject: Re: [RFC 04/10] Temporary struct vfs_lookup in file_permission Message-ID: <20070808192558.GA28278@infradead.org> Mail-Followup-To: Christoph Hellwig , Andreas Gruenbacher , linux-kernel@vger.kernel.org, John Johansen , Jan Blunck , Erez Zadok , Josef 'Jeff' Sipek References: <20070808171622.632749741@suse.de> <20070808171643.922193525@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070808171643.922193525@suse.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 622 Lines: 13 On Wed, Aug 08, 2007 at 07:16:26PM +0200, Andreas Gruenbacher wrote: > Create a temporary struct vfs_lookup in file_permission() instead of > passing a NULL value. NACK. file_permission is special in that it doesn't happen in the context of any kind of lookup operation, and the nd/intent paramater to ->permission should be NULL in that case instead of faking up some crap. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/