Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <03b93c24-f055-fd56-972c-fd5ad4e9a67e@nvidia.com>
Date:   Tue, 15 Nov 2022 12:18:44 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 06/13] usb: typec: ucsi_ccg: Add cypress,firmware-build
 as a well-known regex
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-7-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-7-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0F4U3hHaXJmeHQxTU9HU3RnNlN1eEJsWkgyNkU4di9yV2Job3ZyNjRENGpi?=
 =?utf-8?B?OEc5VGIvclV6WkpQTkZwMlZJc2s1a28xSlRjbit2VFBidWtQTVFhTmVrQ3pK?=
 =?utf-8?B?R0JlY1Y1SFcvVUVCUWpSMGtLbVlrckZVVkYxSWU5TE9GeEYxdm93UE9lZC9x?=
 =?utf-8?B?MG1jMFBxQUdVRkExNUN0MWVrVFR6TWt1anZEL2hHK2pESkxFMXpZQi9XcEJx?=
 =?utf-8?B?cVJaZ1hXZHV0NHBDODBpQ1ZiVndXMGJKTUF5Tk1kVW95T0oyWnJyYW1mNm9U?=
 =?utf-8?B?djlvMWxZd2syWXhTUU1MeGNXaGJjb3FkbUZMYURMcnpwVnJUWVpUQllPMmxp?=
 =?utf-8?B?NjZWL28ybkFvNWFyeVZ3MDM2SjZhWTk2TndPYlNxYWJGTUpxQW1EMGRrMUNp?=
 =?utf-8?B?S2pCNzZFdWNKWXhja2ZlR1RqS2VTTzJyZy9zQk1XeThHbjV4eEtuUjBlRFhW?=
 =?utf-8?B?ZWRnejdsY3EwcklWSFdONzdRZ1RzcEszYllMSXZZdFVNQzdDOHJjVEg1b0NE?=
 =?utf-8?B?ak51ZnZMOCttWHB4cDl1alpzQkNnbWNzclAxSzRJMmtvc0lLMnFYdFB4a1pQ?=
 =?utf-8?B?d1g1cTJ4cDhTcU5kdUVwWW9NQ2VnUkRTcHZOYkQ5L0dXTEtLV1IrWDVjaHhW?=
 =?utf-8?B?dS92VnRaVmpoYXBOOU5TNjVMa1JCL3ZjTGxHdEM0MEM4MU9NNnV3ZnovNkdL?=
 =?utf-8?B?ejdZdHVnUUV2dEFoUW9CZG0rWHBHOUM0TEY5M0NQbGVtY2dyeVhrT1ppSGJM?=
 =?utf-8?B?RkdmdS9NY1N4VVROYi9mNk4xZnYwNTh6VlN2WFFFeEJqQTBSSHQ2MklWRlN6?=
 =?utf-8?B?TW1aNWdBZ3hSOGN5YTNycGg0OVpuSzdtb05maWJHd3V4ZU1QSXc4SkNCdHUw?=
 =?utf-8?B?RGYzNDhJZWM2N2RNR0FRT1RUZmF6ZSs0M3kyNWJMek93TFdGNDlyZTVyRUxu?=
 =?utf-8?B?ODNXTVVmSlMvdVQ0aXRkNG9hVHpIQUlZZ3djekRjbnR0eFR2eHdZSHlhQzVH?=
 =?utf-8?B?ZzIzd25DTXRjeWRkd1N1UEQ5WUJWYlVvazlwQlRCaWVIWW50U1lBaWZ1VWtR?=
 =?utf-8?B?OGt1YkpoQWJDL1pITTFCeEpTYy92c296MFdZWS9RTDY4NHNBb1VsMTl2T1Ew?=
 =?utf-8?B?V1pmZzd1ajhqUkpYSTdGQ1J5UzMzbzJ1Zmg3cnFCUmZSbWpJSTFhcTMrQlU5?=
 =?utf-8?B?MDlzZ3Rnd01zamVWV1k3MjVZWk0yV3JzS0hEQVMyY3JBekwvS0FxMStXNlAr?=
 =?utf-8?B?QkNaNlZXaFhWK3VsL3hLQ05Gd2x4bUs0a3FxNkloZFNzNzI5Szg0MnlOVzlQ?=
 =?utf-8?B?SkRraGJhNFRDeCtqR21KT0thWUd6dlRHT3FiTDk3Q05ycy9jTld5SEZCQ2Nz?=
 =?utf-8?B?OUlrSUxRVmVHT3VuM2xUWitUa0Jud1NxbHQrRmgwQXRCVlZBdXUvSnhVMTlX?=
 =?utf-8?B?ZXlhS1duN0FlWlVRT2tMY1BkbXdORTl6U2JPU05ncERrRUorZ2xYdVo4Skto?=
 =?utf-8?B?emYvb2xMbTBMU1FRb0hrcFQ5VUorYXlxOWR2dFZUV0QyVE5kemliZmNqQktM?=
 =?utf-8?B?NHBDaEY0Y2FEMHlUUjdnMlB4WGR2QWtHMHFHSmVVdGx0QXJCOXljTXdIdjFB?=
 =?utf-8?B?aGM0M0szTVZ1NTl6VGZzak44SWJCZDgrTUVtMEFzSmd2dGE5NDhqQmpEL1Y5?=
 =?utf-8?B?M3VJYy94V28xd1hOcUhnZ1l6Q25VRFQ1TEc5YkV3Sm85OC9nT2N1QU1nVk0z?=
 =?utf-8?B?T3ZOSXNsa29DSm9zR1hCaHdIU21wMTJhYXdiREJhR2c1bTJBLzRSTFZXVjRk?=
 =?utf-8?B?UzlqV1A0SjlwV1NYMkcwd2RJbStmODJ3RllFWU1RMmRSc3duY0hELzZybHda?=
 =?utf-8?B?bnE2ZjZYT3pDUUZGS3Q2OUNLeDI3RkNZNXF1OWN0Y1hqQ3V6MUdQV1RBTWsv?=
 =?utf-8?B?SFZ5RnZON2pBRHBqM21BL0RBalBWSm5pNldidTFjY1lJd1RraHRuZUhiUldP?=
 =?utf-8?B?R25aenNjNmlIVnh3WVQveThDWStCclFVK04zTlB4T2kyMDBweUc1Sks5QjB6?=
 =?utf-8?B?b1ZHOVM0YVAxdHV2TVE1cTVSS3BPU3BsMThDZEtWcTlDQVdBdHl2azZGVkxO?=
 =?utf-8?B?VWNKeDY3OVNob05YVG1QbUFEbU9ZMmNwWUlLY2pGY2NiUHpwRzM4a3BBZzhX?=
 =?utf-8?B?SVE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3e98dcc-f329-48b2-49dd-08dac7038e24
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:18:51.2600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pSUGvtmwI+EN6BiB1bno0m5xTGWQxFumY/GpVdsKyH0YBqyi/Ft2lxaOYBcgNHfeZYXEcioJmm2ItAhDa1s6eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5036
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> ccgx is refer to the cypress cypd4226 typec controller.
> add cypress,firmware-build as a well-known regex.
> 
> 16-bit value is not sufficient for descriptiva names.
> Using string instead of u16 to make it more descriptive.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:new change added for adding cypress,firmware-build
>   drivers/usb/typec/ucsi/ucsi_ccg.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 139707a2f3d6..e412a457bbfc 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1343,6 +1343,7 @@ static int ucsi_ccg_probe(struct i2c_client *client,
>   {
>   	struct device *dev = &client->dev;
>   	struct ucsi_ccg *uc;
> +	const char *of_fw_build;
>   	int status;
>   
>   	uc = devm_kzalloc(dev, sizeof(*uc), GFP_KERNEL);
> @@ -1363,6 +1364,17 @@ static int ucsi_ccg_probe(struct i2c_client *client,
>   	if (status)
>   		dev_err(uc->dev, "failed to get FW build information\n");
>   
> +	status = device_property_read_string(dev, "cypress,firmware-build",
> +					  &of_fw_build);
> +	if (!status) {
> +		if (!strcmp(of_fw_build, "nvidia,jetson-agx-xavier"))
> +			uc->fw_build = CCG_FW_BUILD_NVIDIA_TEGRA;
> +		else if (!strcmp(of_fw_build, "nvidia,gpu"))
> +			uc->fw_build = CCG_FW_BUILD_NVIDIA;
> +	} else {
> +		dev_err(uc->dev, "failed to get FW build information\n");
> +	}
> +
>   	/* reset ccg device and initialize ucsi */
>   	status = ucsi_ccg_init(uc);
>   	if (status < 0) {


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic