Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7da6c4db-84cf-3532-3d16-ced2696e1ef1@nvidia.com>
Date:   Tue, 15 Nov 2022 12:18:53 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 07/13] i2c: nvidia-gpu: Add cypress,firmware-build as a
 well-known regex
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-8-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-8-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ry9pckNLc051N3NNck9JZTcySThBWGJHVEVVZnY1ZGMxaStYWVZLaVVXcFhL?=
 =?utf-8?B?SXZMS0dlZS83OUlOSTlqV3MwdmFKR2gvdmRvOGVEeXk1eUMrVTdaeTA1Z0Q0?=
 =?utf-8?B?V3JxUGZNeURPQ21GSjdNMUM2ZXR5bFJpVitrTklsL3c2QWVIS04vN3J4Unhp?=
 =?utf-8?B?Ujhqd0F6dXAvZ2tMUVZtNXhoYkpZV1RqSTZNZFZTVWNFVEdHbVcrSCsxVUVv?=
 =?utf-8?B?VlUwbUNpbUpJNEJ3aDhzMzNDQzJPYy8zQ2NoVGV0bUxwakMwa2ovckUxcGpw?=
 =?utf-8?B?ek5BYVArS0lQZ09NTXN1emxiUnpzWkRGK2VUdlg4cnRGNUlGMlVVTHMyL29S?=
 =?utf-8?B?TTB4a2ZVQ05KVFh0b0VaTllqL2NBUmI0ZFBqUUVlRGwvaHF5SmFoZDVOWjZr?=
 =?utf-8?B?UkVPajIwcENpQU9IS2duOFZxTjdrSDB3N2xsSWN6cVNTMXY4ajBhMThCcnMw?=
 =?utf-8?B?T0ZWR09pK25LOWxVQTRQTDZzaHYvZ3kzcFJOOWEzOEVQQmwxWEUvVk02d3Ay?=
 =?utf-8?B?eSs0dGhlTjRhbHBUMWRiWHFFRDRFd3ozU2FnTk5kMkxheEFRRkpFOUJHWDlY?=
 =?utf-8?B?SSt2RmNxSHdIUXVjNFdNcGxxRE1jeTl2MEtyQlQ2V3ZoVXFDdS9yUVpxckg5?=
 =?utf-8?B?QXhDNFNDQTZYRmdvc3FkNXBmTmE2T0hhalFncWozWlFhYndXQVVldFpNd20y?=
 =?utf-8?B?WElRNzQvWFMrdHBCNFNxcmhkdEZNeGhPZUFtL01SRVZ4eTEyVG5qTFZOcmVF?=
 =?utf-8?B?WjBKOStBTmluMnNTVUcxL090emYrL2tETXJhK0NrOFY3S01VQ1oxbU92MXBM?=
 =?utf-8?B?Zm1RdWx4V3lLV0pZVXc3dy8ySjRpcTZSZGdUQy9ZQTB4TUVvTi9uSFQwa2Nr?=
 =?utf-8?B?QndzcU9kU0M4VHpYY0Z3SXppeWRIQytnOWk1VmxLV25scllGemNiOFBTYUU0?=
 =?utf-8?B?T29UUFNTUTZBKzU5MEh2bXNhWkNtZTA4SUpkNDlFRi83eEV4U0M0TGl4OGVy?=
 =?utf-8?B?dkVCV3Jya1JlV1NJUGY4TlFuZDBySjZZSCtaM3lIMmhrUFRZZVJCNW8vMDV3?=
 =?utf-8?B?Vi9mcTRqV3V6SEowSHd5dC9PekVlKzYxQVpqZjNqWVVQODhtWmJzNXFRVXNz?=
 =?utf-8?B?SGFSemNzVVVXOUhUamFua2FTZG1za3o0amJ0SEtMN2w5cHU5SkVqR2FEQStL?=
 =?utf-8?B?dVl5V3lqUTJGVkh1SEFSVG1oakI1VExnZ0NvQmpsOVFZNlZjTnRWRUJ6SVFK?=
 =?utf-8?B?RVVmTnBmL01DV3dXRHhDR2pQL2pLNUNzU2tsemtLbmwyazk1K29pSDU4enc2?=
 =?utf-8?B?MXM1bWJPd2RnbWtwcHFmMzdnaGJYQVJoNm8zQm9oNVFESzNqMmlNVzJUOHNm?=
 =?utf-8?B?RHNwRkphZHhvUllmYlRMZ2dOTU5HdEV3WkRHM0txYm96cXdsZUpoYjNWQk1W?=
 =?utf-8?B?U2VIdGd5NnRuUDlkWXR0a3phNC9sSTFJN0RKV0c4K2phdVdBU3ovTEpkcWZt?=
 =?utf-8?B?YTBHMTJoVXVVNGd6dmVlR2JETmcyYmcrQ24rcGMxaG9sTThhZTB6MnJGS01s?=
 =?utf-8?B?b05VT0xHRCtETnBIcmtXaGJoZE53QlI5MVZPb2p1eDYxR08wdlFRd29OVHZv?=
 =?utf-8?B?VGt5b0xObUFWUHJpOVZYeTZpSThzaTJ1QndBR2t1N0l3eHdGa1A1YndLK0JZ?=
 =?utf-8?B?RG9CcUgrN1lIKzhLZy92WnRDRWtLaVV6SHlMcXBQak1XQWpONXJEcmYrOUJw?=
 =?utf-8?B?anlCekFIUFlJT0NUQWQwSFNUZTFFQVRrWGhPQlZsdmhDdDNib2h2cWRDeHd0?=
 =?utf-8?B?TzFBcDhoRWhscFhMMHoxdjFLSmpSbnlHV3czQUQvdUUvUjhncGNSTzY3b3pG?=
 =?utf-8?B?ckVNbVhqeTJZTlE3dmRsRWJRZnduZ1RHVnQ3bnBZMDFxeEJtaG5vZHE2NlBT?=
 =?utf-8?B?L3Q0dzBXODIzVDdKZXZSRkN6WStmK1Rod0VYNW9rbE43V3pVb0xZZHlCYnVE?=
 =?utf-8?B?YVhBTWgvckgrUnJmSXFhKzFKZlg3N0NIVy9QNTd3VU5TWjRqdXhRaENQTUZx?=
 =?utf-8?B?UmdTM0JTbzZFRnh0Vi9MaHQrZk1ZS3B6REpCNk9SSEJEekxLQm8rMHgzT0lr?=
 =?utf-8?B?MTR0N1crS0NoS3pkTVY3bkV4WUdaSGIxRE1kNjEzc1FuTzBEd3huSm4vZ0R5?=
 =?utf-8?B?a2c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3941e217-2789-4cb5-9aec-08dac70393c3
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:19:00.6901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FKX+Rml27HvWYdHdZVLY+7oN+xN2Jl62pkwvFE1q9RZ3DWYK2pg3Imzn0p6AZkADZBrQ1jCcYyG2GXy3UYME1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5036
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> ccgx is refer to the cypress cypd4226 typec controller.
> add cypress,firmware-build as a well-known regex.
> 
> 16-bit value is not sufficient for descriptiva names.
> Using string instead of u16 to make it more descriptive.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:New change for adding cypress,firmware-build
>   drivers/i2c/busses/i2c-nvidia-gpu.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index 12e330cd7635..9b2e13bd44db 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -261,6 +261,7 @@ MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
>   static const struct property_entry ccgx_props[] = {
>   	/* Use FW built for NVIDIA (nv) only */
>   	PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
> +	PROPERTY_ENTRY_STRING("cypress,firmware-build", "nvidia,gpu"),
>   	{ }
>   };
>   


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic