Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935564AbXHHTgr (ORCPT ); Wed, 8 Aug 2007 15:36:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762883AbXHHTgi (ORCPT ); Wed, 8 Aug 2007 15:36:38 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:40478 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761188AbXHHTgh (ORCPT ); Wed, 8 Aug 2007 15:36:37 -0400 Date: Wed, 8 Aug 2007 20:36:36 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: linux-kernel@vger.kernel.org, John Johansen , Jan Blunck , Erez Zadok , "Josef 'Jeff' Sipek" Subject: Re: [RFC 08/10] Pass no NULL vfs_lookup to vfs_create Message-ID: <20070808193636.GB31354@infradead.org> Mail-Followup-To: Christoph Hellwig , Andreas Gruenbacher , linux-kernel@vger.kernel.org, John Johansen , Jan Blunck , Erez Zadok , Josef 'Jeff' Sipek References: <20070808171622.632749741@suse.de> <20070808171644.407320917@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070808171644.407320917@suse.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 20 On Wed, Aug 08, 2007 at 07:16:30PM +0200, Andreas Gruenbacher wrote: > Never pass a NULL vfs_lookup to vfs_create() or iop->create by creating > temporary vfs_lookup objects where needed. Remove the obsolete NULL > checks. ipc/mqueue.c should be rewritten to use vfs_path_lookup instead. nfsd is special - people need to deal with the !nameidata or !intent case anyway because the fs/exportfs/expfs.c code uses lookup_one_len all over when the filesystem is mared nfs exportable, but fortunately the filesystem that are nfs exportable are usually not those using intents. We might eventually fix this one day by having some kind open by handle intent, but that should come as part of a large patch series where we qualify the type of lookup for every single lookup. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/