Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44ee7109-71a2-a172-e840-483e2db716b3@nvidia.com>
Date:   Tue, 15 Nov 2022 12:17:21 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 05/13] usb: typec: ucsi_ccg: Add OF support
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-6-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-6-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHpScDl5NklQbHRrUzdDWlNIOGlvYVFkQ25FUm4zU2puQ0wxY1FHRlpVM2NK?=
 =?utf-8?B?bVhSYjRJUzFDRU0wcFE5MjhVMVQwUmU5SkJUaC9KN3o0aWhzTVZtbXhWb3Ry?=
 =?utf-8?B?RXk1bXdzekxvOEhzcTdMdnprZ0ltVGhoUXVLT2RPWmZzTEtKODFGS3EzaWJG?=
 =?utf-8?B?aXc2NEIrZjE5aTVGaTBsaDFBQnQvTi9adXpoM1NReW5iNkQ3VUduSmNpY1RP?=
 =?utf-8?B?NjFBWktyUGg5aUtCRFJyOWUxVGovaHRiQTl3WGRqd3dRZHRIdXFsazllWkFv?=
 =?utf-8?B?ZnpYdm0rbDdEYU54ZGhxSS91d01NMHJyUFlMTHlKY1RQakNReFNKMk9tbFcz?=
 =?utf-8?B?TG94Z3M5SVNMU1ZnRS9rd1RBSHg1SkxlL2FMN1g5SFQvZ0R3TU1HcjdpZWpq?=
 =?utf-8?B?MjB5R2hMWVhSengxWXdKR0xXVnZPNnk4OFFFdTFjL1JQL2JNTXZWNlNhOWMz?=
 =?utf-8?B?S3VpLzluT25RcjB6SkRGR1QzTGZKRm9nRnNhM1h6NEVBQnljUkFaZWRxSEhE?=
 =?utf-8?B?VU9ydWdkNU5peElPM1VTQTM0djBVUUlUbnVEaXFYRmk5dDY5NDgyMEkyYjZz?=
 =?utf-8?B?YUQ5eHBYQUZzRjB5cTBvZTZjVVlWTDZ2MUc2Zkkzc0pKbkEvdmdqTUJpZ01Q?=
 =?utf-8?B?dmFsUXY3QjhhSXduVjFFUmZSNUk0TUlGN0dNZmJXMCtZUVVJN2NyWVNVSkEx?=
 =?utf-8?B?aUdCWXpIZy91UjFpQTduYWNkMXM5VitXK3pxQnVlRzZ0M0NCeEZNRXY3QlN1?=
 =?utf-8?B?L0Y5V29GSVRjRU9yTjFnZExPVnE3dDJiV2M2a291WGVGVXpnMHhZNGxwL3ZM?=
 =?utf-8?B?Ti9PM1AwVndvTUlYZFkvbVY3ZGE4QTQ2WVNyb1VRSXpwQXlSdExDMkkvMjdO?=
 =?utf-8?B?bVNoNFdRaWdiMXgrS2JtSFBTdVdKZXpFQ0h2R256cjBKQms2cXI5bktUNGky?=
 =?utf-8?B?UW4xV3FkZGQ4UTRzK3RERnp6c3ZZRFlldXhybUM2UlpEbm1NK2dieVZyUktw?=
 =?utf-8?B?Y3FTRTlXUUdNQ2lFcEtMRGgzSFBZV25WTUJ2Z2I3aHpHUDZIdUpFL3lyUFlo?=
 =?utf-8?B?ZXZxRnZjQzN6VVY4amN3WTJ4ZVE3U1ZxYlB0ZWsrYmhSNzlOSTdOc2c4TDJC?=
 =?utf-8?B?OURHcXZsRjlGOHZhTWQ1S254bmJHM2ZXY0xvckdaTkx1Zno3a2padVFaVW4z?=
 =?utf-8?B?bHlBdUlSazkyUVNlRnp4OHVQRDNVcjRGd2ZBRW1WU1ZHbmp2NjBwakRPZW9F?=
 =?utf-8?B?L1VzQWNUNXU1VmJCMHBOMTRyQmFmVDlVc1EwZkhDQVAxZ3R1cGhVNnhxT3dW?=
 =?utf-8?B?SVVLV2R3cE5qcjRmVjFRZGQ4YVZjdTk4UXlHcjZ1bm9ieGpZamdHd2JWMkZ5?=
 =?utf-8?B?V2lKLytzZzE1QVlwQjNWeWFpeHRXQS9LQ0d5eDN5VDRSZis2SUc5Njk5cWVS?=
 =?utf-8?B?dEU1YWJCK3R5OGZvOXZDdDVaR010SFJEdlJWQ1M1Vm8weDdVQm1QZ3V4bjkr?=
 =?utf-8?B?Q2h1eDJYTDcrNENLTmdRcFNKVlp1bHpPWkxmWkRsQlJmYlFTc01Oak5melNC?=
 =?utf-8?B?Qnk0anUyODdNK3VqOThRejRvQmJkWUVGRW1GL29kbjdZZ1ZUcnhsOEhZQ2dC?=
 =?utf-8?B?UU9ROHZGZ3V5bGpsQmxiM2d6R3VRSzJyeC80L3FRR3NId2RhN3NaVGVtb3Zn?=
 =?utf-8?B?ZmFRcEY3R1NBUTNWRWd1T2EvekpERkZlcWRQMlA3ZTlaQ3RlSWlqQ2pnUTZV?=
 =?utf-8?B?MnNjaTlNKytzMkRlS2FSWUFlVWgrYitMT3RUSjZXU0NkaS92U0dzakdOODJn?=
 =?utf-8?B?ZnpKRmwremZIa1UrTDRLYnZsLzVHUnIrZTVsSEgyUzJTWEEvVTEvbzVyWnY4?=
 =?utf-8?B?aGFDc0pVSnB3UzBMN3N1b2dmMDQ5TU9UTEh3WExqWTlqT3VaRTJOSUFjTVJK?=
 =?utf-8?B?eWZ1MEZSeHdQVGhseEtLcnpwSUZUR2NvVkhNbmp4djM1V1gxM3pnRlBJRnFp?=
 =?utf-8?B?RkdPbys3OGllSFU3WmpsQWlrSkVkQXoxR2VOd2VxUzhoaWZOYjR2QW9uZHlR?=
 =?utf-8?B?ajZIM2tyL3ZHZ09hTUJ6T0s2ZTZNWHJGN1pUbk9PTHljV0xXV2pTNGs0MlVJ?=
 =?utf-8?B?YkgwMDZ0c0J5SlJxWWRjM05tOTBmb1RuRE9JSlUvcVRrQnFxOEZ5c21KY0RX?=
 =?utf-8?B?RFE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ce0e439-0b4f-401f-93f9-08dac7035d75
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:17:29.5662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: st+/8e4+vKhc9vkfndnk6Mirgocks1iFKds0amO+fjcGAp/D2dCUnSDyYgyelLg1KMOtzO7zZpfdRJzVngAjLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5036
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> The change enables the device tree infrastructure support.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:nothing has changed
>   drivers/usb/typec/ucsi/ucsi_ccg.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 835f1c4372ba..139707a2f3d6 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -643,7 +643,7 @@ static int ccg_request_irq(struct ucsi_ccg *uc)
>   {
>   	unsigned long flags = IRQF_ONESHOT;
>   
> -	if (!has_acpi_companion(uc->dev))
> +	if (!dev_fwnode(uc->dev))
>   		flags |= IRQF_TRIGGER_HIGH;
>   
>   	return request_threaded_irq(uc->irq, NULL, ccg_irq_handler, flags, dev_name(uc->dev), uc);
> @@ -1427,6 +1427,12 @@ static void ucsi_ccg_remove(struct i2c_client *client)
>   	free_irq(uc->irq, uc);
>   }
>   
> +static const struct of_device_id ucsi_ccg_of_match_table[] = {
> +		{ .compatible = "cypress,cypd4226", },
> +		{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, ucsi_ccg_of_match_table);
> +
>   static const struct i2c_device_id ucsi_ccg_device_id[] = {
>   	{"ccgx-ucsi", 0},
>   	{}
> @@ -1481,6 +1487,7 @@ static struct i2c_driver ucsi_ccg_driver = {
>   		.pm = &ucsi_ccg_pm,
>   		.dev_groups = ucsi_ccg_groups,
>   		.acpi_match_table = amd_i2c_ucsi_match,
> +		.of_match_table = ucsi_ccg_of_match_table,
>   	},
>   	.probe = ucsi_ccg_probe,
>   	.remove = ucsi_ccg_remove,


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic