Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cdf81530-3bb8-ace5-e70f-a20403891c57@nvidia.com>
Date:   Tue, 15 Nov 2022 12:19:02 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build
 property
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-9-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-9-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?empRWUdhTHBPTklRaDVGdWgrNXZHM1g1NHJUbGdhQit3aEZoSFZIM2JVdVlv?=
 =?utf-8?B?YXFqZzdBTDJmWUR6dWg4NVVRUFJ0SWpKWmxNYWRtZ1lOTzI5SWo0MXZvWUVS?=
 =?utf-8?B?ZjZUMDdsL3p6YjlYTXIrdzQ5Rjl3ZDJpTWJCQ1ZYYnk3Skc0WG4wdjRYaXJr?=
 =?utf-8?B?enRPWVVNQUE5cGIzeUlPZzZVTE5QZWNUTkoxRmpndjJWc2xxZnJOY0hEMlht?=
 =?utf-8?B?dU9aQnNMWkh5eUZXREZ2VEEzaHFWa0IweURqUGdabHZoVzFtdzR1SGtacXZy?=
 =?utf-8?B?VXdZc20vYnk2eVcrdlQ4SnJNbVRsVmRlWDBXc0FtWWQzdk45aWVVZXBSVzd2?=
 =?utf-8?B?bHFMTGF1VGVOMlFmM04rWGpvdWphL216ck9acHF6S3gwS2ZhU2JkdTFYQzl5?=
 =?utf-8?B?ajNlVnlJNXVKUDhxK3JFWExYT3FsRGVUK0V0M0xGQkV5eTZ6aGdYZk1LaGtN?=
 =?utf-8?B?YWYvenFSZWVZMVI2cDdXMjYvbGtMQVJIb2tpNmcyV3VZQjhqWXBXWGRRQUsw?=
 =?utf-8?B?aVBmeS82Z3JLcGppb3RLNEU3ZlcyZE5hMzRjYkpEdExPenN4RWZhWnhneHpt?=
 =?utf-8?B?ZllDQU5YZDFCOFRwWDVFc25TTUdiUWMyU3BER21NVDJUY2xWSUJzeFlHT3dh?=
 =?utf-8?B?SlpUWWxTNk1XRWZDbDNLOFNLY2tCQ1NuaE5tNzhTbFdGaG41bW9rL3hCZnhn?=
 =?utf-8?B?MFoyeGlXLzlHWHl5Y0IvcVM1VGN2Y1ZES095UHJ1UzBFVU84ZVg4Yjh1Zmsw?=
 =?utf-8?B?ZTREczIzZEFTK1FtdVY5YzRGd1RTSjMxNHNSRHJSSktyQkg3RkNOYTJ4Wk93?=
 =?utf-8?B?UGNrb2pUeEkrM3AvcHJNZmRBdXRjZTZKdlgrUXRPeTBwME1meHo4TzdXem03?=
 =?utf-8?B?QmJTUzRpeUVkeE9WdzJuRzNXbVdIbHR1ejlCYXg4dDlPOXFocTM1Rk4xYUdW?=
 =?utf-8?B?WVRZZFR4UklpcDcyUFNIV3pSRmdNbXJaK2VVOVYxMzlFMkVJbm5BTzV1OFU4?=
 =?utf-8?B?bDBkbXlEaDYzUEhUZXlGQ2M3WVFrK2NkWiszRG1TRzdPcDdod3duK0lrcFFJ?=
 =?utf-8?B?TXVlY0d5bDg1S3YxTlVjbHdHWVZUa3FWd05wMzBieGpyTEd1bEpJK0ZTYWtJ?=
 =?utf-8?B?ak1DZWdMWmZvWU0va1kydHJTRGNobkp2aTZtYnRLYWl2ajNwMEdlT1BLUW1q?=
 =?utf-8?B?RVBrUkU4aVBzQ2NZZlJpYXlNQzkzR2diSFI4U0F0N21EWjZXTkdSaCtSeUV0?=
 =?utf-8?B?TkppYXJsUDJ5elJON1NHaUdwUkw1U0ZLU3ppbm1KZ3ZZbmRmVDF1YmVwcWsz?=
 =?utf-8?B?bGlsNGRmdjd0M0R6YjViU1NXM2VTK01FUzhIOHBhYTVYY0pncEtNd0VPM2pr?=
 =?utf-8?B?b1R5REhCempsVVUwNzYrRXF4Si9pVENvdFNkTHVkMmZtSlBvSUVNT0RnVUIr?=
 =?utf-8?B?MFBCSVR3OWJ3T3o0RjB1ZC9CZTlPREpMRWRwZ0NKNnN3OWRiZjk1d3JGZnov?=
 =?utf-8?B?WDRRSURmdDNwQVFmQVRrOHlxRFRZb2VGblVMQkZVOUFxanloTUIzZERyNUJK?=
 =?utf-8?B?aEwzYmdGM1UyWnJnTi8yVjFvWjJiaFZjUFVZbmlacDNpQXlOaDNpc1I5OGZC?=
 =?utf-8?B?SE80eEV2NUdPb1hOMXdUcmVIWERnWlBMRW53ejdtTUZOUjcxVEZETGhzY0ox?=
 =?utf-8?B?VWFrSmdIL2xidThHUTFzZnhwWHBKM3FMNjNoSXNaVlVURjJwOEtBMWZkZ1FM?=
 =?utf-8?B?OGlUTWN2WWM1NzV4NXczanVKSFUraUpveU9VdWpDb0RYNjZXbzQ2NDhQaUp5?=
 =?utf-8?B?RWNFQ0hjK05aTHdsTXR1d2E0WXR3NjBXRmY5MEhBclIyamMzeGp2clQ2Smxu?=
 =?utf-8?B?ZXcycE9yZ3N1SzcvbzJXRElyK1loTzZsU09SVVNCN2M3citheHBtRUJ6K1Fh?=
 =?utf-8?B?TlNvdXZPaVpLT0trMkZWclJBMi9SUll1YThHTkxkM2t1aE5CWlkxbDNIUUh1?=
 =?utf-8?B?d1Bnb1NpZ1dNNVlQZmJ1TW5UeFBLcHpWNExhNzBUbXk5ZHNtVkwzZ2xRWEd6?=
 =?utf-8?B?VXZKWU8wMXVkZU51ckJCUnEyRWM4VEpaV0t6emUwMUt6Q2dLaWUzdkVJZEhl?=
 =?utf-8?B?QUxsWjArQ256QzlYRElvVkhaSXpVS1NmeWVZbmRRKzRwZm1na08zcE9uWTV4?=
 =?utf-8?B?S1E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 395dea04-2601-4a68-8db2-08dac7039996
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:19:10.4599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +gcYm/4h+cwZbUAFZfRDZiJ8UsmZDIlpXiTAfRmmSB80wy/WXmGLltV15RfaTATquSuEIpChN1BE498zAGtbBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> Remove the property ccgx,firmware-build as we have added well-known
> regex cypress,firmware-build.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:nothing has changed
>   drivers/usb/typec/ucsi/ucsi_ccg.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index e412a457bbfc..eab3012e1b01 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1359,11 +1359,6 @@ static int ucsi_ccg_probe(struct i2c_client *client,
>   	INIT_WORK(&uc->pm_work, ccg_pm_workaround_work);
>   
>   	/* Only fail FW flashing when FW build information is not provided */
> -	status = device_property_read_u16(dev, "ccgx,firmware-build",
> -					  &uc->fw_build);
> -	if (status)
> -		dev_err(uc->dev, "failed to get FW build information\n");
> -
>   	status = device_property_read_string(dev, "cypress,firmware-build",
>   					  &of_fw_build);
>   	if (!status) {

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic