Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2eb2dc4-3b80-8d48-0e91-34939395898a@nvidia.com>
Date:   Tue, 15 Nov 2022 12:23:11 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 13/13] usb: gadget: tegra-xudc: Add Tegra234 support
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-14-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-14-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFFlbWVzT1hhVkN6L0ZnalZiY0NxcmZYaEpDOExDdnJoSG1EKzIwR3ZsSUE4?=
 =?utf-8?B?T0ZLYVdSTFo1Vk9UemhOcSsvMHNKTU53MnhLSGNiU3RSbkNZQXgvN1V0SWRH?=
 =?utf-8?B?UmYvRUcveTNsVDY3dHNRSzl5UFZFdmJpQjNPVUN2aWJBT3hyWS9Fd0RidnFR?=
 =?utf-8?B?MGFreDNwWjdBM05ldWJHc3VrR3MwNDlCcTdNZCs5cURDVXdYOVlwaHZxSHdY?=
 =?utf-8?B?dGFrM3picVhYWnRGWXNOV1d6ejZZT1lNUUNSYnZJOXVjczRlSFFiYjN0Unkx?=
 =?utf-8?B?R1BIaWVyWlJUVGVGb3lzV1V3UkJ5SmZpUzZMK0ZVdDB0T1c4QmE5bUtuVHpP?=
 =?utf-8?B?UXQyRzF6ckJMNWZDZHdRKzVTaTNkVkhIRG1RTnpmVEtRUm16OHBNUzVyM2J5?=
 =?utf-8?B?bTdrR28zdFB0eTZZdzRUbGRxZHNYZmwwbkY5M3FuTHJBbStiRHVGOEgyYlFF?=
 =?utf-8?B?V3Y2cmxVNlBtYXVVNE84RjNETjlGWi84SStSeUFoY214bHZUNFc1RmxKNTVt?=
 =?utf-8?B?MFRvdWpEcFdvbzFkNXM4Mm1yQ2R1UlJLeHdkL0tGYlhRdnJndm1VTmtoRlBr?=
 =?utf-8?B?QzBlUGM2bktUS242dUNPZ3JoODZoUGU0T1pnNWF0NGx1ZEJQUGVCMnV2aHpY?=
 =?utf-8?B?TUkxVTFBZmswdkpZQkxOTlFSbkFPclM0ekZHK0d3OVZETnQ3Nk84MHVXR1pR?=
 =?utf-8?B?VWNudnk4MkYwMHZ4dFlIVWRWVC84SURmOE8veFZBOVIrVnNVOHZweUpPeFlM?=
 =?utf-8?B?N1huOWdwMTkvVXhUR2NtQ09pOTQ1TmNpMWFuOWVBdWhpTmNPRjNLdlg0dC9z?=
 =?utf-8?B?MnB2dDg4bk8vV3oxR3g3RnZLMWpTOHVoL0xsRFpuSnQ0Mm5oaElEdjZPNzRC?=
 =?utf-8?B?K0JkbHBGTGc5am1FRzcyMllRcmxVb1dUUXRGUmJLM00zOGxkbnB2NFE3NGlR?=
 =?utf-8?B?R204RlN1clV6N2tSVkdnc2lGRWF2dTh0cFZsVllSR2xnbENTaWczNm92QmVD?=
 =?utf-8?B?K2ZGZmcwVk9kMFRhSUl4cm92aWJSV0lMcnNNS1hXZk1WSUZmT1FxS3lpVVpY?=
 =?utf-8?B?WkJEckRzeVhXeXlmS1hjeXZTVzZwaTZWS2RSQzc5ZjhDc1RicnZPMDJEUDRv?=
 =?utf-8?B?LzNxazJKMFlGT2d3L2dIZFBUNk5waHhtTCt4VlMyVit6OGc4V0gzY3Bkczht?=
 =?utf-8?B?KzAvQi9NNTcyTjVwMllqQlJRSS9ZN0FTdDNqSC9ZaC9qSnFEU3lId2padTFv?=
 =?utf-8?B?anhwbmEzaDVhVHROM3NFWFZza3JnUjNEOGlrNGsrN2lFUTB1VVlXTWxtOEdh?=
 =?utf-8?B?dmFIckZJdUlZWGdIMVdPYWNEOFFrRXBPelZ0OXZDWWxpMGp1czV2K0JTeVFN?=
 =?utf-8?B?S2daajRyNlczU1JXYTRmeURHSmVpV200TUdKQVJIUGtlVUV2ZjNlVHpnVUQ4?=
 =?utf-8?B?MUZoM3FRUlZoNUJWL1JURFJHVWxwcEQyZjk2OVBONUpIUHNhNW9DMitaQUpL?=
 =?utf-8?B?a0RTTVIwZkJtcGFrRWR1Um8zdTJVQys2UEtMU3B6b1gxd2NFb2hmMmM0TVB4?=
 =?utf-8?B?dHM4UTN0UWx3ZE1uQmZiaUtoMHJIbXllczV2K01MOUNtNm5UeFhxZU1XRnFu?=
 =?utf-8?B?bW4yYVJ1YWdQTXVubnZGZElBUTdNbTIzQzk4ZUVvb202UmhHSUIzd3pKbTZh?=
 =?utf-8?B?SHB6VFIvMGV3cTE4V2tuekQxaXpKMmFpdEJma2M5R3dSckR2QXhQYzhuSFdL?=
 =?utf-8?B?blJzQWcvNytmNXRQOExkTW5tT3VRbU90dE1tRmdBQnhRT3ZMRUk1Q2gvRXVH?=
 =?utf-8?B?ODNPbVdHS0I5c3JKV3Rsb2MzdFowK3FtbHZLN0tCazI0SHo3R0Nad0ZFbkxs?=
 =?utf-8?B?TXNlN3AyRUFxMWhnTTJZdTJDZHUwbzJRcndxTVdIWGdvSldCL0UrSitBSFd4?=
 =?utf-8?B?aHNra0NyTHhGaTJqSjNPRWlWRHhUTFFGbFJObC85ZElwK2xwZUtSeStFbGpL?=
 =?utf-8?B?MmhaV2xHWlNwbjdzZmRxM3Z3ZlZieTdTajA0RGxRaWloS042c2J2UjNLUEpR?=
 =?utf-8?B?eWgrakp1NlUvZityVFM2T2pCckRMTlpoTGc1Mm0waHlZZTl2akxqZ3doM09k?=
 =?utf-8?B?c3NXazk3TVFRK21CT3d1ZHRJMGFNand2dlZDTS9LUnFaSGFLb1pJV0FoRzVE?=
 =?utf-8?B?L3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb37baa2-d2b5-4391-e400-08dac7042e04
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:23:19.4715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PscnvBNgz1pUowGsPQ7MpyGcBD+mPfbtijpaC+7DSxB2/oLzLtmb+9FkyWVbro+zEVVe5gb2ypVL9BbpSlZOBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> From: Sing-Han Chen <singhanc@nvidia.com>
> 
> This commit adds support for XUSB device mode controller support on
> Tegra234 SoC. This is very similar to the existing Tegra194 XUDC.
> 
> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:nothing has changed
>   drivers/usb/gadget/udc/tegra-xudc.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 76919d7570d2..ff697190469b 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3660,6 +3660,19 @@ static struct tegra_xudc_soc tegra194_xudc_soc_data = {
>   	.has_ipfs = false,
>   };
>   
> +static struct tegra_xudc_soc tegra234_xudc_soc_data = {
> +	.clock_names = tegra186_xudc_clock_names,
> +	.num_clks = ARRAY_SIZE(tegra186_xudc_clock_names),
> +	.num_phys = 4,
> +	.u1_enable = true,
> +	.u2_enable = true,
> +	.lpm_enable = true,
> +	.invalid_seq_num = false,
> +	.pls_quirk = false,
> +	.port_reset_quirk = false,
> +	.has_ipfs = false,
> +};
> +
>   static const struct of_device_id tegra_xudc_of_match[] = {
>   	{
>   		.compatible = "nvidia,tegra210-xudc",
> @@ -3673,6 +3686,10 @@ static const struct of_device_id tegra_xudc_of_match[] = {
>   		.compatible = "nvidia,tegra194-xudc",
>   		.data = &tegra194_xudc_soc_data
>   	},
> +	{
> +		.compatible = "nvidia,tegra234-xudc",
> +		.data = &tegra234_xudc_soc_data
> +	},
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, tegra_xudc_of_match);

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon
-- 
nvpublic