Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6057b1b-229d-7350-91f3-d26be0e5090e@nvidia.com>
Date:   Tue, 15 Nov 2022 12:19:23 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 10/13] phy: tegra: xusb: Disable trk clk when not in
 use
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221114124053.1873316-1-waynec@nvidia.com>
 <20221114124053.1873316-11-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221114124053.1873316-11-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmRseVRneEJ2YVdhMUNod0dYWVNKSUZWNk9kaFNQWmFWSVF1bVdud09pT29v?=
 =?utf-8?B?a1JmbjVvRFdlaGY2WFZ3UHNWNGlpdDJ0SU00YTJNSyt2RVNGclZZRDFLZUp3?=
 =?utf-8?B?RTlRT1o0WlVSWXJ2VGRKSVY5TXM0SGJ4cVFWYXZWcHNERFgybUVJbDFaS2Rm?=
 =?utf-8?B?b2o4N3hicXBYSmVqaFloOVBndytTalcyRVlFUEJDeWZ6cWhIR2lEQXFHNzNs?=
 =?utf-8?B?QmFHZ21uUzcrbHBoVXpuaHFwZkw1S2lFNndneDUralF6MTg3Sndhc2lWVCtK?=
 =?utf-8?B?TGNUTE5ncU5nQ2RzTEpGTysrZDFsZ2tFTUZ3REN6bXVuTnlzRk96RFRkalUw?=
 =?utf-8?B?bjB5VXI1WmRjcTVnYUdKUXV4TkI1dWhaS3lhUndXTlQ1YWV3NWNsNWNXVXdR?=
 =?utf-8?B?cW5lUjhqRnVkZlpBMDFxU2R4c3E2NTl0Q0ptb1VhSG5GWCtoV0YzZWRuYisr?=
 =?utf-8?B?UDM3eitTZDRjYmVJbUR0MHhpK3BVaStaQmNWK2lhMTU4V3pkVDV4OUtCZHZ0?=
 =?utf-8?B?ZEZiMjlWWnhIUlhvY2ttU0RuN29VamtaNDRVQ0YyRmtuWFBxYTRhS1dBVllx?=
 =?utf-8?B?NG9DNkRkQmxiU1pPWDRLY3dMbm9BM20rRHRmcFdGNUgzaVNQSWE3Z1d0andX?=
 =?utf-8?B?Zmxpek1wRFVxaU81S29PYzlkSGVleHRRNkFpc1FBWk1ZRitLcXVXSXVPcndJ?=
 =?utf-8?B?Q1FIaGQwOEpMTnNvd3pvTjVrT3RqTTlZblJ5TnhPdFozd1ZFMzY2M3hTYnFR?=
 =?utf-8?B?eDZIcEthWjdIQy9wK0ZpNEdSUEptb0lpSnZFVWtOekxlQ1lZbjVqMk8zbGli?=
 =?utf-8?B?cUI5RkxCUEp2VENlL01QeE14WHVuellsTmVqdzNXa2lMMEZOUWhUR0ZpRkVa?=
 =?utf-8?B?cUNESW5DeHE1MXVzR05aVkNJRi82aSs5OWlGL21vc2FEOTlxdzEreUZHTThk?=
 =?utf-8?B?R2Vzd01jVHRIcWJGOU5IWm42bWhIaHRYbHh5SFljRDY3d2hBQU45QXNQaEdV?=
 =?utf-8?B?b2hUUEkyNFJXeGp1RW83V2d6N0RsRGlycWJyTzhJMVYwMm5TMEdFcFV3Q29M?=
 =?utf-8?B?N0tLRC9sVUQwQmlEd2xBeTNuZ2Vpc3ZQempRNG50c3d2cHpLdjVsN05wazFk?=
 =?utf-8?B?cnhIb0l1dVNoYTQrU3plOHdHd05GMVFnRC9DeGZmMEJCNlZ3V2tzN0VGNGox?=
 =?utf-8?B?VGIreUhPbjkrVEMyZmxOVW1hZDVkZmlwZEZ1MFlkZ1pvdTk2Z1ozbURjMGRm?=
 =?utf-8?B?VUg2M29wTW1IYmNYdXFSUEtxdmRtSy96MG9McnpJa2ZIUDEraWE3K05mZjZy?=
 =?utf-8?B?dHpkallXNWowNmpYYTVzUGFWbGdOdktMUW5hMGRHbDhCTVZlelVCQ3YybHNn?=
 =?utf-8?B?UC9kNUl2clliekowQ1JkRVJtVkZEM0ZRcTljanl2MWMrN2RKQzhWYXllWndh?=
 =?utf-8?B?YlUrYnducVpXeXg3Z2ovY1IzQjd5Z2FwUVR0cm1VNEViaDBUNmRuRkUxNGVx?=
 =?utf-8?B?VUQ1Z2ZxODBXdlEwZncyRFJuKzdxd2p6S2JNYTNFQ1NHemd3NEk4RFdtOHdk?=
 =?utf-8?B?WVFYZ0NKc3h0SmFBVDNHT3J6L1A3M3BodnZSQ0lnSVZ3SVRMOER0WUlYaVJi?=
 =?utf-8?B?Zmxsa1hLeWxUcU1GdEV0Z0dCWG9kRWhwTWV5ZmVpb3VIZndXckprNWhYbCtp?=
 =?utf-8?B?Q0tyUHVDeldrT2k3MSs4dVJXRDJJRG40Q0NsNURab1BJK0xVNUE1U3RQYmdx?=
 =?utf-8?B?WlRCUWhibjV3RG1zQ0p4eWdQZG01Vnhic0NyVkpseU5QNGpBZmQ1K2krOVZ2?=
 =?utf-8?B?QXk0SjVWVDNtaitjeVRFajFYN0ZnVTFRTGsvbERIMDVFaVJncGhIbWdQZGs4?=
 =?utf-8?B?MnM1UTFIZzNaV1F2YTZiMUo5V2EvaVg1amxCVTQ0Z1N0dUlIL0pKK05IaktP?=
 =?utf-8?B?T2l1bnluZjFVQVpDL3diVk9rRldsM1lPQnlUelhpWFhTYWFMbTlZODByaDRx?=
 =?utf-8?B?b0ppWTlaWUxqd0ZKblY3WHhlbWIyYnl4USthcEI1ZkMxOSszeFA4QlViT0FJ?=
 =?utf-8?B?K25hVXJKQVYweEphVFQvWXdMclhwWjV1TFNPY3RXOGwzcURrSXNLd0NaNkow?=
 =?utf-8?B?Y2dZRjhUZkhiZzlRL2sydGU3eDZTSXJjY1JBcEdNaWk0S0VPK0lzSjVSejlM?=
 =?utf-8?B?U0E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a55a5845-2f10-4859-f459-08dac703a5bc
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:19:30.8454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KHcgqEZxrRzXhIMeRxAlDXdN2KECw/DX4TlUo/TmsXF7CzrXptTehDpeuQWMdott0pD8uqV2+Fxe0XVdMQJgZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/11/2022 12:40, Wayne Chang wrote:
> Pad tracking is a one-time calibration for Tegra186 and Tegra194.
> Clk should be disabled after calibration.
> 
> Disable clk after calibration.
> While at it add 100us delay for HW recording the calibration value.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:update the commit message.
>   drivers/phy/tegra/xusb-tegra186.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 0996ede63387..f121b4ffbbfd 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -609,6 +609,10 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
>   	value &= ~USB2_PD_TRK;
>   	padctl_writel(padctl, value, XUSB_PADCTL_USB2_BIAS_PAD_CTL1);
>   
> +	udelay(100);
> +
> +	clk_disable_unprepare(priv->usb2_trk_clk);
> +
>   	mutex_unlock(&padctl->lock);
>   }
>   
> @@ -633,8 +637,6 @@ static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
>   	value |= USB2_PD_TRK;
>   	padctl_writel(padctl, value, XUSB_PADCTL_USB2_BIAS_PAD_CTL1);
>   
> -	clk_disable_unprepare(priv->usb2_trk_clk);
> -
>   	mutex_unlock(&padctl->lock);
>   }
>   


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic